Re: [PATCH 1/3] firewire: fw-ohci: PPC PMac platform code

2008-03-01 Thread Stefan Richter
Benjamin Herrenschmidt wrote: >> +#ifdef CONFIG_PPC_PMAC >> +/* Necessary on some machines if fw-ohci was loaded/ unloaded before */ >> +if (machine_is(powermac)) { >> +struct device_node *ofn = pci_device_to_OF_node(dev); >> + >> +if (ofn) { >> +

Re: [PATCH 3/3] firewire: fw-ohci: shut up false compiler warning on PPC32

2008-03-01 Thread Stefan Richter
Stephen Rothwell wrote: > On Sat, 1 Mar 2008 02:50:44 +0100 (CET) Stefan Richter <[EMAIL PROTECTED]> > wrote: >> Wasn't there a macro somewhere for this? > > Yes, uninitialized_var() in linux/compiler*.h Right. I actually did look into compiler.h and compiler-gcc.h but somehow didn't make it d

[PATCH 3/3 update] firewire: fw-ohci: shut up false compiler warning on PPC32

2008-03-01 Thread Stefan Richter
Shut up two "may be used uninitialised in this function" warnings due to PPC32's implementation of dma_alloc_coherent(). Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> --- drivers/firewire/fw-ohci.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: linux-2.6.25-rc3/drivers/f

Re: [PATCH] [POWERPC] 40X: Add Default Restart Machdep Method to 40X Platforms

2008-03-01 Thread Stefan Roese
On Saturday 23 February 2008, Grant Erickson wrote: > This patch restores the reset on restart functionality to 40x-based > platforms that was formerly provided--but not used in arch/powerpc--by > abort() in head_40x.S. This functionality is now provided by > ppc40x_reset_system(char *) in a fashio

[PATCH 0/4] firewire, ieee1394: bus power lost after resume (PPC PMac)

2008-03-01 Thread Stefan Richter
I wrote: > Benjamin Herrenschmidt wrote: > [...] >>> @@ -2211,6 +2241,16 @@ static int pci_suspend(struct pci_dev *p >>> if (err) >>> fw_error("pci_set_power_state failed with %d\n", err); >>> >>> +/* PowerMac suspend code comes last */ >>> +#ifdef CONFIG_PPC_PMAC >>> + if (mach

[PATCH 2/4] firewire: fw-ohci: refactor probe, remove, suspend, resume

2008-03-01 Thread Stefan Richter
Clean up shared code and variable names. Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> --- drivers/firewire/fw-ohci.c | 100 ++--- 1 file changed, 42 insertions(+), 58 deletions(-) Index: linux/drivers/firewire/fw-ohci.c ==

[PATCH 1/4] firewire: fw-ohci: switch on bus power after resume on PPC PMac

2008-03-01 Thread Stefan Richter
The platform feature calls in the suspend method switched off cable power, but the calls in the resume method did not switch it back on. Add the necessary feature call to .resume. Also add the corresponding call to .suspend to make .suspend's behavior explicitly the same on all PMacs. Signed-off

[PATCH 3/4] ieee1394: ohci1394: switch on bus power after resume on PPC PMac

2008-03-01 Thread Stefan Richter
The platform feature calls in the suspend method switched off cable power, but the calls in the resume method did not switch it back on. Add the necessary feature call to .resume. Also add the corresponding call to .suspend to make .suspend's behavior explicitly the same on all PMacs. Signed-off

[PATCH 4/4] ieee1394: ohci1394: refactor probe, remove, suspend, resume

2008-03-01 Thread Stefan Richter
Clean up shared code and variable names. Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> --- drivers/ieee1394/ohci1394.c | 113 +++- 1 file changed, 49 insertions(+), 64 deletions(-) Index: linux/drivers/ieee1394/ohci1394.c =

Re: [dtc] breaking out libfdt from dtc so other progs can use it

2008-03-01 Thread Fathi Boudra
> I think people are confusing source and binary packages. > > E.g. on Debian, the openssl source package is used to build 3 binary > packages: openssl, libssl0.9.8, and libssl-dev. Hence to install > applications that use libssl, you don't have to install all 3, just > libssl0.9.8. That make sens

Re: [PATCH 1/2] firewire: endianess fix

2008-03-01 Thread Stefan Richter
On 23 Feb, I wrote: >> This needs to be tested on different big endian PCs, if possible with >> the Apple Uninorth FireWire controller and other types of controllers. I tested it myself now with VT6306 on PPC32. > it should be triggered by replacing > &fw_high_memory_region > by > &fw

Re: [PATCH] [POWERPC] 40X: Add Default Restart Machdep Method to 40X Platforms

2008-03-01 Thread Josh Boyer
On Sat, 1 Mar 2008 12:32:54 +0100 Stefan Roese <[EMAIL PROTECTED]> wrote: > On Saturday 23 February 2008, Grant Erickson wrote: > > This patch restores the reset on restart functionality to 40x-based > > platforms that was formerly provided--but not used in arch/powerpc--by > > abort() in head_40x

[PATCH 1/2 v2] [OF] Add of_device_is_available function

2008-03-01 Thread Josh Boyer
IEEE 1275 defined a standard "status" property to indicate the operational status of a device. The property has four possible values: okay, disabled, fail, fail-xxx. The absence of this property means the operational status of the device is unknown or okay. This adds a function called of_device_

[PATCH 2/2 v2] [POWERPC] Ignore disabled serial ports

2008-03-01 Thread Josh Boyer
Some SoC chips have multiple serial ports on board. The usability of these ports can rely on various factors, ranging from pin sharing to unpopulated connectors. This checks for a status property in the serial node and ignores the port if it is set to "disabled". Signed-off-by: Josh Boyer <[EMAI

[PATCH 3/2][NEWEMAC] Use status property for unused/unwired EMACs

2008-03-01 Thread Josh Boyer
Convert ibm_newemac to use the of_device_is_available function when checking for unused/unwired EMACs. We leave the current check for an "unused" property to maintain backwards compatibility for older device trees. Newer device trees should simply use the standard "status" property in the EMAC no

Re: [RFC 08/10] um: dyn/uml.lds.S cleanup - use PAGE_SIZE macro

2008-03-01 Thread Cyrill Gorcunov
[Jeff Dike - Fri, Feb 29, 2008 at 10:43:03AM -0500] | On Wed, Feb 27, 2008 at 11:58:39PM +0300, [EMAIL PROTECTED] wrote: | > This patch includes page.h header into liker scripts that | > allow us to use PAGE_SIZE macro instead of numeric constant. | > | > To be able to include page.h into linker s

'next' branch of powerpc4xx tree

2008-03-01 Thread Josh Boyer
Since all the cool kids are doing it, I went and created a 'next' branch in the powerpc4xx tree. I'm basically using it as a place for me to queue things up as they are submitted that look pretty good for going into the next release. While I'll try hard not to rebase it, I can't guarantee that.

Re: [PATCH 1/3] firewire: fw-ohci: PPC PMac platform code

2008-03-01 Thread Jarod Wilson
Stefan Richter wrote: > Copied from ohci1394.c. This code is necessary to prevent machine check > exceptions when reloading or resuming the driver. > > Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> I was able to reproduce the system exception on resume with a 3rd-gen Titanium PowerBook G4 6

Re: [PATCH 3/2][NEWEMAC] Use status property for unused/unwired EMACs

2008-03-01 Thread Benjamin Herrenschmidt
On Sat, 2008-03-01 at 08:41 -0600, Josh Boyer wrote: > Convert ibm_newemac to use the of_device_is_available function when checking > for unused/unwired EMACs. We leave the current check for an "unused" property > to maintain backwards compatibility for older device trees. Newer device > trees s

Re: [PATCH 1/2 v2] [OF] Add of_device_is_available function

2008-03-01 Thread Stephen Rothwell
Hi Josh, On Sat, 1 Mar 2008 08:16:00 -0600 Josh Boyer <[EMAIL PROTECTED]> wrote: > > IEEE 1275 defined a standard "status" property to indicate the > operational status of a device. The property has four possible values: > okay, disabled, fail, fail-xxx. The absence of this property means the >

Re: [PATCH 1/2 v2] [OF] Add of_device_is_available function

2008-03-01 Thread Josh Boyer
On Sun, 2 Mar 2008 09:02:18 +1100 Stephen Rothwell <[EMAIL PROTECTED]> wrote: > Hi Josh, > > On Sat, 1 Mar 2008 08:16:00 -0600 Josh Boyer <[EMAIL PROTECTED]> wrote: > > > > IEEE 1275 defined a standard "status" property to indicate the > > operational status of a device. The property has four po

Re: [PATCH 1/3] firewire: fw-ohci: PPC PMac platform code

2008-03-01 Thread Benjamin Herrenschmidt
On Sat, 2008-03-01 at 14:43 -0500, Jarod Wilson wrote: > Stefan Richter wrote: > > Copied from ohci1394.c. This code is necessary to prevent machine check > > exceptions when reloading or resuming the driver. > > > > Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> > > I was able to reproduce

[RESEND] [PATCH 1/2 v2] [OF] Add of_device_is_available function

2008-03-01 Thread Josh Boyer
IEEE 1275 defined a standard "status" property to indicate the operational status of a device. The property has four possible values: okay, disabled, fail, fail-xxx. The absence of this property means the operational status of the device is unknown or okay. This adds a function called of_device_

Re: [PATCH 3/2][NEWEMAC] Use status property for unused/unwired EMACs

2008-03-01 Thread Josh Boyer
On Sun, 02 Mar 2008 08:33:15 +1100 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > On Sat, 2008-03-01 at 08:41 -0600, Josh Boyer wrote: > > Convert ibm_newemac to use the of_device_is_available function when checking > > for unused/unwired EMACs. We leave the current check for an "unused"