Re: [PATCH] Fix ucc_geth MII master selection

2008-02-15 Thread Joakim Tjernlund
On Thu, 2008-02-14 at 18:11 +0100, Joakim Tjernlund wrote: > Remove bogus UCC regs range test and correct > off by one error in call to ucc_set_qe_mux_mii_mng() > > Signed-off-by: Joakim Tjernlund <[EMAIL PROTECTED]> > --- > > I am not 100% sure this is the correct fix, please ACK or NACK > > d

[PATCH] powerpc: kill sparse warnings in kprobes

2008-02-15 Thread Ananth N Mavinakayanahalli
From: Ananth N Mavinakayanahalli <[EMAIL PROTECTED]> Fix sparse warnings in powerpc kprobes: CHECK arch/powerpc/kernel/kprobes.c arch/powerpc/kernel/kprobes.c:277:6: warning: symbol 'kretprobe_trampoline_holder' was not declared. Should it be static? arch/powerpc/kernel/kprobes.c:287:15: war

Re: [PATCH 04/11] [RFC][GPIOLIB] add gpio_set_dedicated() routine

2008-02-15 Thread Anton Vorontsov
On Thu, Feb 14, 2008 at 08:36:40PM -0800, David Brownell wrote: [...] > > The point was: GPIOs could be "input only" but you still have > > "output" callback, and that doesn't troubles anybody. Not sure > > why set_dedicated() such a big issue then, it could fail too! :-) > > See above: you're eq

Re: [PATCH 6/9] fs_enet: Be an of_platform device when CONFIG_PPC_CPM_NEW_BINDING is set.

2008-02-15 Thread Laurent Pinchart
Hi Scott, I apologize for bringing this after so much time. Hope the "better late than never" motto applies. On Friday 21 September 2007 00:01, Scott Wood wrote: > The existing OF glue code was crufty and broken. Rather than fix it, it > will be removed, and the ethernet driver now talks to the

[PATCH v2] [POWERPC] Enable correct operation of serial ports with nonzero regshift.

2008-02-15 Thread Pavel Kiryukhin
Add regshift reading to serial drivers. This enables correct operation of serial ports with nonzero regshift such as Xilinx opb 16550 uart. Signed-off-by: Pavel Kiryukhin <[EMAIL PROTECTED]> arch/powerpc/kernel/legacy_serial.c |6 +- drivers/serial/of_serial.c |6 -- 2

[PATCH] fs_enet: Remove unused fields in the fs_mii_bb_platform_info structure.

2008-02-15 Thread Laurent Pinchart
The mdio_port, mdio_bit, mdc_port and mdc_bit fields in the fs_mii_bb_platform_info structure are left-overs from the move to the Phy Abstraction Layer subsystem. They can be safely removed. Signed-off-by: Laurent Pinchart <[EMAIL PROTECTED]> --- arch/powerpc/sysdev/fsl_soc.c |4 includ

[PATCH] booting-without-of: add Xilinx uart 16550.

2008-02-15 Thread Pavel Kiryukhin
Add uart 16550 properties description to Xilinx portion of booting-without-of.txt Signed-off-by: Pavel Kiryukhin <[EMAIL PROTECTED]> --- Documentation/powerpc/booting-without-of.txt | 16 ++-- 1 files changed, 14 insertions(+), 2 deletions(-) diff --git a/Documentation/powerpc/boo

Re: dtc: Fold comment handling test into testsuite

2008-02-15 Thread Jon Loeliger
So, like, the other day David Gibson mumbled: > For ages dtc has included a sample dts, comment-test.dts, for checking > various lexical corner cases in comment processing. In fact, it > predates the automated testsuite, and has never been integrated into > it. This patch addresses this oversight

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-15 Thread Christoph Raisch
Dave Hansen <[EMAIL PROTECTED]> wrote on 14.02.2008 18:12:43: > On Thu, 2008-02-14 at 09:46 +0100, Christoph Raisch wrote: > > Dave Hansen <[EMAIL PROTECTED]> wrote on 13.02.2008 18:05:00: > > > On Wed, 2008-02-13 at 16:17 +0100, Jan-Bernd Themann wrote: > > > > Constraints imposed by HW / FW: >

Re: [PATCH] PPC440EP Interrupt Triggering and Level Settings

2008-02-15 Thread Josh Boyer
On Sun, 10 Feb 2008 20:24:02 +0100 Wolfgang Ocker <[EMAIL PROTECTED]> wrote: > From: Wolfgang Ocker <[EMAIL PROTECTED]> > > Corrected IRQ triggering and level settings according to latest revision > of the 440EP User Manual (rev 1.24 nov 16, 2007). > > The incorrect settings might cause a failur

Re: [PATCH 6/9] fs_enet: Be an of_platform device when CONFIG_PPC_CPM_NEW_BINDING is set.

2008-02-15 Thread Sergej Stepanov
Am Freitag, den 15.02.2008, 13:50 +0100 schrieb Laurent Pinchart: > We're loosing the possibility of having MDC and MDIO on different ports. This > is quite easy to fix for the non-CONFIG_PPC_CPM_NEW_BINDING case but I'm not > familiar with OF bindings (yet) to fix the CONFIG_PPC_CPM_NEW_BINDIN

RE: [PATCH] booting-without-of: add Xilinx uart 16550.

2008-02-15 Thread Stephen Neuendorffer
> + - reg-shift : registers offset shift (standard uart_port field). > + Property is optional if regshift is zero. I was hoping to get an idea of what is required here, or when I might use it? It looks like the ARCH=ppc code instantiates this with a reg-shift of 2... Is this the e

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-15 Thread Dave Hansen
On Fri, 2008-02-15 at 14:22 +0100, Christoph Raisch wrote: > A translation from kernel to ehea_bmap space should be fast and > predictable > (ruling out hashes). > If a driver doesn't know anything else about the mapping structure, > the normal solution in kernel for this type of problem is a multi

Re: [PATCH] booting-without-of: add Xilinx uart 16550.

2008-02-15 Thread Pavel Kiryukhin
Stephen Neuendorffer wrote: >> + - reg-shift : registers offset shift (standard uart_port > field). >> + Property is optional if regshift is zero. > > I was hoping to get an idea of what is required here, or when I might > use it? > > It looks like the ARCH=ppc code instantiates thi

RE: [PATCH] booting-without-of: add Xilinx uart 16550.

2008-02-15 Thread Stephen Neuendorffer
> -Original Message- > From: Pavel Kiryukhin [mailto:[EMAIL PROTECTED] > Sent: Friday, February 15, 2008 9:41 AM > To: Stephen Neuendorffer > Cc: linuxppc-dev@ozlabs.org > Subject: Re: [PATCH] booting-without-of: add Xilinx uart 16550. > > Stephen Neuendorffer wrote: > >> + - reg-s

Re: [PATCH 1/2] fb: add support for foreign endianness

2008-02-15 Thread Anton Vorontsov
On Thu, Feb 14, 2008 at 10:49:42PM -0800, Andrew Morton wrote: > On Tue, 5 Feb 2008 18:44:32 +0300 Anton Vorontsov <[EMAIL PROTECTED]> wrote: > > > This patch adds support for the framebuffers with non-native > > endianness. This is done via FBINFO_FOREIGN_ENDIAN flag that will > > be used by the

Re: [PATCH 3/8] pseries: phyp dump: use sysfs to release reserved mem

2008-02-15 Thread Linas Vepstas
On 14/02/2008, Tony Breeds <[EMAIL PROTECTED]> wrote: > On Tue, Feb 12, 2008 at 01:11:58AM -0600, Manish Ahuja wrote: > > +static ssize_t > > +show_release_region(struct kset * kset, char *buf) > > +{ > > + return sprintf(buf, "ola\n"); > > +} > > + > > +static struct subsys_attribute r

[BUID_FAILURE] next-20080215 Build failure caused by ide: rework PowerMac media-bay support

2008-02-15 Thread Kamalesh Babulal
The linux-next-20080215 kernel build fails on the powerpc with following error CC arch/powerpc/platforms/powermac/setup.o In file included from arch/powerpc/platforms/powermac/setup.c:66: include/asm/mediabay.h:29: error: syntax error before 'ide_hwif_t' include/asm/mediabay.h:2

Re: [PATCH] booting-without-of: add Xilinx uart 16550.

2008-02-15 Thread Milton Miller
On Sat Feb 16 00:40:01 EST 2008, Pavel Kiryukhin pkiryukhin wrote: > Add uart 16550 properties description to Xilinx portion of > booting-without-of.txt This patch description is a bit weak. How about adding what properties are being added. Also, as described below, it's going to become more

Re: NOR flash partitions gone

2008-02-15 Thread Sean MacLennan
Anton Vorontsov wrote: > Probably CONFIG_MTD_OF_PARTS is not set? > > Good luck, > That was it! Thanks! Cheers, Sean ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH v2] [POWERPC] Enable correct operation of serial ports with

2008-02-15 Thread Milton Miller
On Sat Feb 16 00:30:09 EST 2008, Pavel Kiryukhin wrote: > Add regshift reading to serial drivers. > This enables correct operation of serial ports with > nonzero regshift such as Xilinx opb 16550 uart. > > Signed-off-by: Pavel Kiryukhin This patch is incomplete in that it does not add support to

Re: [PATCH] booting-without-of: add Xilinx uart 16550.

2008-02-15 Thread Sergei Shtylyov
Grant Likely wrote: >>Add uart 16550 properties description to Xilinx portion of >>booting-without-of.txt >> Signed-off-by: Pavel Kiryukhin <[EMAIL PROTECTED]> >> --- >> Documentation/powerpc/booting-without-of.txt | 16 ++-- >> 1 files changed, 14 insertions(+), 2 deletions(-) >>

Re: [PATCH] booting-without-of: add Xilinx uart 16550.

2008-02-15 Thread Grant Likely
On Fri, Feb 15, 2008 at 11:56 AM, Sergei Shtylyov <[EMAIL PROTECTED]> wrote: > Grant Likely wrote: > > >> + Xilinx uart 16550 device registers are compatible with all > standard 16540 > >> + and 16550 UARTs. > > > > Not strictly true; the xilinx uart is *almost* compatible with the >

Re: NOR flash partitions gone

2008-02-15 Thread Scott Wood
Sean MacLennan wrote: > I did a git pull of Josh's for-2.6.25 tree. Now the NOR partitions are > no longer setup. > > [EMAIL PROTECTED],0 { > compatible = "amd,s29gl032a", > "cfi-flash"; > b

[PATCH] prom.c: Fix dt_mem_next_cell() to read the full mem cells

2008-02-15 Thread Becky Bruce
dt_mem_next_cell() currently does of_read_ulong(). This does not allow for the case where #size-cells and/or #address-cells = 2 on a 32-bit system, as it will end up reading 32 bits instead of the expected 64. Change it to use of_read_number instead and always return a u64. Signed-off-by: Becky B

Re: [PATCH] booting-without-of: add Xilinx uart 16550.

2008-02-15 Thread Grant Likely
On Fri, Feb 15, 2008 at 6:40 AM, Pavel Kiryukhin <[EMAIL PROTECTED]> wrote: > Add uart 16550 properties description to Xilinx portion of > booting-without-of.txt > > Signed-off-by: Pavel Kiryukhin <[EMAIL PROTECTED]> > --- > Documentation/powerpc/booting-without-of.txt | 16 ++--

Re: [PATCH] booting-without-of: add Xilinx uart 16550.

2008-02-15 Thread Sergei Shtylyov
Grant Likely wrote: >> >> + Xilinx uart 16550 device registers are compatible with all >> >> standard 16540 >> >> + and 16550 UARTs. >> > Not strictly true; the xilinx uart is *almost* compatible with the >> > ns16550. The same driver can be made to work, but it is not register >> > l

Re: NOR flash partitions gone

2008-02-15 Thread Anton Vorontsov
On Fri, Feb 15, 2008 at 02:11:06PM -0500, Sean MacLennan wrote: > I did a git pull of Josh's for-2.6.25 tree. Now the NOR partitions are > no longer setup. > > [EMAIL PROTECTED],0 { > compatible = "amd,s29gl032a", > "cfi-flash";

Re: [PATCH] booting-without-of: add Xilinx uart 16550.

2008-02-15 Thread Grant Likely
On Fri, Feb 15, 2008 at 12:14 PM, Sergei Shtylyov <[EMAIL PROTECTED]> wrote: > Grant Likely wrote: > > The registers are not at the same location, therefore it is not compatible. > > > However, the *driver* can be easily made compatible with the devices. > > We just teach the driver to bind agai

[PATCH] fs_enet: Don't call phy_mii_ioctl() in atomic context.

2008-02-15 Thread Scott Wood
The lock acquisition in fs_ioctl() does not appear to actually be necessary, and thus is simply removed. Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- This fixes the following bug: http://ozlabs.org/pipermail/linuxppc-dev/2008-February/051564.html drivers/net/fs_enet/fs_enet-main.c |7 +-

Re: [PATCH 0/4]: Respun LMB patches.

2008-02-15 Thread Michael Ellerman
On Wed, 2008-02-13 at 17:09 -0800, David Miller wrote: > I've taken into consideration the various feedback, and > ported the bug fix and other LMB patches posted recently > in an effort to keep the patch churn by others down wrt. > my moving of these files. > > 1) Use HAVE_LMB as suggested by Sam

RE: [PATCH] booting-without-of: add Xilinx uart 16550.

2008-02-15 Thread Stephen Neuendorffer
> > Instead of attempting to come up with a generic description > > of this, I recommend just naming it after the actual device instance; > > something like compatible="xlnx,opb-uart16550"; > > Well, that means that we'll need a to add a code which "glues" the chip to > 8250.c driver... well,

NOR flash partitions gone

2008-02-15 Thread Sean MacLennan
I did a git pull of Josh's for-2.6.25 tree. Now the NOR partitions are no longer setup. [EMAIL PROTECTED],0 { compatible = "amd,s29gl032a", "cfi-flash"; bank-width = <2>;

Re: [PATCH 0/4]: Respun LMB patches.

2008-02-15 Thread Josh Boyer
On Thu, 14 Feb 2008 14:15:31 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote: > From: Josh Boyer <[EMAIL PROTECTED]> > Date: Thu, 14 Feb 2008 15:24:48 -0600 > > > I plan on actually testing this on Ebony, Walnut, and Bamboo either > > later tonight or tomorrow. I don't expect many issues. > >

RE: [PATCH] fs_enet: Don't call phy_mii_ioctl() in atomic context.

2008-02-15 Thread Rune Torgersen
Scott Wood wrote: > The lock acquisition in fs_ioctl() does not appear to actually be > necessary, and thus is simply removed. > > Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- > This fixes the following bug: > http://ozlabs.org/pipermail/linuxppc-dev/2008-February/051564.html > > drivers/ne

Re: [PATCH 3/8] pseries: phyp dump: use sysfs to release reserved mem

2008-02-15 Thread Tony Breeds
On Fri, Feb 15, 2008 at 01:17:16AM -0600, Manish Ahuja wrote: > Tony Breeds wrote: > > Any reason this sysfs attribute can't be write only? The show method > > doesn't seem needed. > > yes, its used later in the code. I see that now, thanks. From my point of view it would make reviewing these p

Re: Please pull powerpc.git merge branch

2008-02-15 Thread Josh Boyer
On Fri, 15 Feb 2008 09:00:28 +1100 Paul Mackerras <[EMAIL PROTECTED]> wrote: > Linus, > > Please do > > git pull \ > git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc.git merge > > to get a collection of bug-fixes and very minor cleanups for powerpc > (plus one commit wiring up the t

Re: [PATCH 0/4]: Respun LMB patches.

2008-02-15 Thread David Miller
From: Michael Ellerman <[EMAIL PROTECTED]> Date: Sat, 16 Feb 2008 06:05:37 +1100 > That fixes the build failures I was seeing, ack. Thanks for testing. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-de

Re: [PATCH 1/2] i2c-ibm_iic driver

2008-02-15 Thread Sean MacLennan
Jean Delvare wrote: > Please split your patch into logical parts: > * Whitespace and coding-style cleanups > * Other cleanups (e.g. changing the log levels) > * Add OF support > Here is the first patch with everything except the OF support. Really all I did was change the log levels based on fe

Re: [PATCH 2/2] i2c-ibm_iic driver

2008-02-15 Thread Sean MacLennan
Here is the of platform patch. I removed the retries and removed the spaces used for spacing. Cheers, Sean Signed-off-by: Sean MacLennan <[EMAIL PROTECTED]> --- --- old-i2c-ibm_iic.c 2008-02-15 23:01:58.0 -0500 +++ i2c-ibm_iic.c 2008-02-15 23:00:44.0 -0500 @@ -6,6 +6,9

[BUG] Linux 2.6.25-rc2 - Regression from 2.6.24-rc1-git1 softlockup while bootup on powerpc

2008-02-15 Thread Kamalesh Babulal
Hi, The softlockup is seen from 2.6.25-rc1-git{1,3} and is visible in the 2.6.24-rc2 kernel, While booting up with the 2.6.25-rc1-git{1,3} and 2.6.25-rc2 kernel(s) on the powerbox Loading st.ko module BUG: soft lockup - CPU#1 stuck for 61s! [insmod:379] NIP: c01b0620 LR: c01a5dc