Re: Device Tree & PCI

2008-01-12 Thread Benjamin Herrenschmidt
> [EMAIL PROTECTED] { > interrupt-map-mask = <0f800 0 0 7>; > interrupt-map = < > /* IDSEL 0x10 */ > 8000 0 0 1 &PCI_INT 1 > > /* IDSEL 0x11 */ >

Re: [i2c] [PATCH 1/5] Implement module aliasing for i2c to translate from device tree names

2008-01-12 Thread Jean Delvare
Hi Jon, On Fri, 11 Jan 2008 20:20:15 +0100, Jean Delvare wrote: > > +{ > > + /* only powerpc drivers implement the id_table, > > +* it is empty on other platforms */ > > + if (id) { > > + while (id->name[0]) { > > + if (strcmp(client->driver_name, id->name) == 0

Re: [PATCH] ibm_newemac: Increase number of default rx-/tx-buffers

2008-01-12 Thread Eugene Surovegin
On Sat, Jan 12, 2008 at 06:57:24PM +1100, Benjamin Herrenschmidt wrote: > > On Sat, 2008-01-12 at 08:26 +0100, Stefan Roese wrote: > > > > We shouldn't make it too complicated. We can always select different > > settings > > in the defconfig file. My thinking here is to better wast a little > >

Re: [i2c] [PATCH 0/5] Version 17, series to add device tree naming to i2c

2008-01-12 Thread Jean Delvare
On Fri, 11 Jan 2008 15:16:57 -0500, Jon Smirl wrote: > On 1/11/08, Jean Delvare <[EMAIL PROTECTED]> wrote: > > Secondly, it promotes OF device names as acceptable aliases. This I > > don't think I agree with. While I see some value in moving the OF name > > -> Linux name translation to the drivers

Re: [i2c] [PATCH 0/5] Version 17, series to add device tree naming to i2c

2008-01-12 Thread Jon Smirl
On 1/12/08, Jean Delvare <[EMAIL PROTECTED]> wrote: > On Fri, 11 Jan 2008 15:16:57 -0500, Jon Smirl wrote: > > On 1/11/08, Jean Delvare <[EMAIL PROTECTED]> wrote: > > > Secondly, it promotes OF device names as acceptable aliases. This I > > > don't think I agree with. While I see some value in movi

Re: [i2c] [PATCH 1/5] Implement module aliasing for i2c to translate from device tree names

2008-01-12 Thread Jon Smirl
On 1/12/08, Jean Delvare <[EMAIL PROTECTED]> wrote: > Hi Jon, > > On Fri, 11 Jan 2008 20:20:15 +0100, Jean Delvare wrote: > > > +{ > > > + /* only powerpc drivers implement the id_table, > > > +* it is empty on other platforms */ > > > + if (id) { > > > + while (id->name[0]) { > >

Re: [PATCH 2/5] Warp Base Platform - dts

2008-01-12 Thread Sean MacLennan
Stefan Roese wrote: > You define here one gpio node that covers both gpio controllers of the 440EP. > I suggest to use two nodes here, like: > > GPIO0: [EMAIL PROTECTED] { > compatible = "ibm,gpio-440ep"; > reg = ; >

Re: [PATCH 1/5] Warp Base Platform

2008-01-12 Thread Sean MacLennan
Please ignore the last patch. I left in a debug to check that the non-ad7414 case works. Cheers, Sean Signed-off-by: Sean MacLennan <[EMAIL PROTECTED]> --- diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 66a3d8c..b3e4c35 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kcon

Re: [PATCH 1/5] Warp Base Platform

2008-01-12 Thread Sean MacLennan
Stefan Roese wrote: > > You are accessing the 440EP GPIO controller here right? Then you really > should > use big endian access routines. From you code I assume that you have > connected the LED signals to GPIO00 and GPIO01. I suggest to use code that > looks like this: > > #define LED_GREEN

Re: [PATCH for 2.6.24][NET] fs_enet: check for phydev existence in the ethtool handlers

2008-01-12 Thread Jeff Garzik
Anton Vorontsov wrote: > Otherwise oops will happen if ethernet device has not been opened: > > Unable to handle kernel paging request for data at address 0x014c > Faulting instruction address: 0xc016f7f0 > Oops: Kernel access of bad area, sig: 11 [#1] > MPC85xx > NIP: c016f7f0 LR: c01722a0 CT

Re: RFC: Only deal with apple fix if res is memory

2008-01-12 Thread Kumar Gala
On Jan 11, 2008, at 4:03 PM, Benjamin Herrenschmidt wrote: > > On Fri, 2008-01-11 at 10:38 -0600, Kumar Gala wrote: >> Ben, >> >> Will this impact the apple fix? I'm getting some _IO cases hitting >> this. > > No, your fix is right, it's a bug to compare against pci_mem_offset > and > not ch

Re: PCI Failed to allocate mem for PCI ROM

2008-01-12 Thread Ivan Kokshaysky
On Sat, Jan 12, 2008 at 12:27:05AM -0700, Grant Grundler wrote: > Looking at setup-bus.c:pci_bridge_check_ranges(), I'm concluding that: > [7] is IO Range. > [8] is MMIO > [9] is Prefetchable MMIO > [10] no clue...maybe used by host PCI bus controllers. #10 is for cardbus bridges, IIRC. > 0x1

Re: [PATCH 1/5] Warp Base Platform

2008-01-12 Thread Stephen Rothwell
Hi Sean, On Sat, 12 Jan 2008 15:42:45 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote: > > +++ b/arch/powerpc/platforms/44x/warp.c > +static int __init warp_probe(void) > +{ > + unsigned long root = of_get_flat_dt_root(); > + > + if (!of_flat_dt_is_compatible(root, "pika,warp")) > +