question about hvc_opal.c

2014-05-16 Thread Himangi Saraogi
Hi, In function hvc_opal_probe I find : hp = hvc_alloc(termno, 0, ops, MAX_VIO_PUT_CHARS); if (IS_ERR(hp)) return PTR_ERR(hp); Earlier, hpc_opal_privs[termno] is assigned pv which is allocated using kzalloc. Shouldn't there be a kfree(pv) and the array element (wh

Re: question about hvc_opal.c

2014-05-16 Thread Greg KH
On Fri, May 16, 2014 at 11:34:13PM +0530, Himangi Saraogi wrote: > Hi, >   > In function hvc_opal_probe I find : > >         hp = hvc_alloc(termno, 0, ops, MAX_VIO_PUT_CHARS); >         if (IS_ERR(hp)) >                 return PTR_ERR(hp); > > Earlier, hpc_opal_privs[termno] is assigned pv which