On Tue, 8 Jan 2008, Timur Tabi wrote:
> Define the layout of a binary blob that contains a QE firmware and
> instructions
> on how to upload it. Add function qe_upload_firmware() to parse the blob
> and perform the actual upload. Fully define 'struct rsp' in immap_qe.h to
> include the actual R
Define the layout of a binary blob that contains a QE firmware and instructions
on how to upload it. Add function qe_upload_firmware() to parse the blob
and perform the actual upload. Fully define 'struct rsp' in immap_qe.h to
include the actual RISC Special Registers. Added description of a new
On Tue, 08 Jan 2008 09:26:27 -0600
Timur Tabi <[EMAIL PROTECTED]> wrote:
> Stephen Rothwell wrote:
>
> > If you use:
> > for_each_child_of_node(qe, fw)
> > You don't need to initialise 'fw' in its declararion.
>
> I can't find for_each_child_of_node. It's not in Kumar's for-2.6.25 branch.
Stephen Rothwell wrote:
> Why not:
> const u64 *iprop;
> int len;
>
> iprop = of_get_property(fs, "extended-modes", &len);
> if (iprop && (len == sizeof(u64))
> qe_firmware_info.extended_modes = *iprop;
Actually, I like my way better, because then I don't ha
Stephen Rothwell wrote:
> If you use:
> for_each_child_of_node(qe, fw)
> You don't need to initialise 'fw' in its declararion.
I can't find for_each_child_of_node. It's not in Kumar's for-2.6.25 branch.
> Why not:
> const u64 *iprop;
> int len;
>
> iprop = of_get_proper
On Mon, 7 Jan 2008 16:15:44 -0600 Timur Tabi <[EMAIL PROTECTED]> wrote:
>
> +struct qe_firmware_info *qe_get_firmware_info(void)
> +{
> + /* Find the 'firmware' child node */
> + while ((fw = of_get_next_child(qe, fw)))
If you use:
for_each_child_of_node(qe, fw)
You don't need to
Define the layout of a binary blob that contains a QE firmware and instructions
on how to upload it. Add function qe_upload_firmware() to parse the blob
and perform the actual upload. Fully define 'struct rsp' in immap_qe.h to
include the actual RISC Special Registers. Added description of a new
Anton Vorontsov wrote:
> Please, add compatible "fsl,qe" matching, so this code could
> work with new device trees.
Can you give me an example of this? I cannot find a single device tree
anywhere
that has this compatible property in it.
--
Timur Tabi
Linux kernel developer at Freescale
On Sat, Dec 29, 2007 at 04:07:20PM -0600, Timur Tabi wrote:
> Anton Vorontsov wrote:
>
> >> + firmware {
> >> + id = "Soft-UART";
> >> + extended_modes = <0 0>;
> >> + virtual_traps = <0 0 0 0 0 0 0 0>;
> >
> > I believe using underscore
Anton Vorontsov wrote:
>> +firmware {
>> +id = "Soft-UART";
>> +extended_modes = <0 0>;
>> +virtual_traps = <0 0 0 0 0 0 0 0>;
>
> I believe using underscores for the property name is discouraged.
Ugh, this one change would
On Fri, Dec 07, 2007 at 09:43:53AM -0600, Timur Tabi wrote:
> Define the layout of a binary blob that contains a QE firmware and
> instructions
> on how to upload it. Add function qe_upload_firmware() to parse the blob
> and perform the actual upload. Fully define 'struct rsp' in immap_qe.h to
>
On Friday 07 December 2007, Timur Tabi wrote:
> Define the layout of a binary blob that contains a QE firmware and
> instructions
> on how to upload it. Add function qe_upload_firmware() to parse the blob
> and perform the actual upload. Fully define 'struct rsp' in immap_qe.h to
> include the a
On Dec 12, 2007, at 9:17 AM, Timur Tabi wrote:
> Timur Tabi wrote:
>> Define the layout of a binary blob that contains a QE firmware and
>> instructions
>> on how to upload it. Add function qe_upload_firmware() to parse
>> the blob
>> and perform the actual upload. Fully define 'struct rsp'
Timur Tabi wrote:
> Define the layout of a binary blob that contains a QE firmware and
> instructions
> on how to upload it. Add function qe_upload_firmware() to parse the blob
> and perform the actual upload. Fully define 'struct rsp' in immap_qe.h to
> include the actual RISC Special Registers
Define the layout of a binary blob that contains a QE firmware and instructions
on how to upload it. Add function qe_upload_firmware() to parse the blob
and perform the actual upload. Fully define 'struct rsp' in immap_qe.h to
include the actual RISC Special Registers. Added description of a new
lock-name and tx-clock-name device tree
properties
(dated 12/3)
[PATCH v2] qe: add ability to upload QE firmware
--
Timur Tabi
Linux kernel developer at Freescale
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Arnd Bergmann wrote:
> Ok, looks you were right from the start (again), thanks for your patience
> explaining this to me.
No problem. No all I need is for Kumar to apply the patches!
--
Timur Tabi
Linux kernel developer at Freescale
___
Linuxppc-dev
Define the layout of a binary blob that contains a QE firmware and instructions
on how to upload it. Add function qe_upload_firmware() to parse the blob
and perform the actual upload. Fully define 'struct rsp' in immap_qe.h to
include the actual RISC Special Registers. Added description of a new
Timur Tabi wrote:
> I think these patches are final:
>
> [PATCH 1/2] qe: add function qe_clock_source (dated 12/3)
> [PATCH 2/2] ucc_geth: use rx-clock-name and tx-clock-name device tree
> properties (dated 12/3)
> [PATCH v2] qe: add ability to upload QE firmware
I lied.
On Dec 6, 2007, at 9:59 AM, Timur Tabi wrote:
> Arnd Bergmann wrote:
>
>> Ok, looks you were right from the start (again), thanks for your
>> patience
>> explaining this to me.
>
> No problem. No all I need is for Kumar to apply the patches!
When I wait you come up with a new version.. so I'm
On Thursday 06 December 2007, Timur Tabi wrote:
> In reality, having the boot loader load the firmware will usually be the
> preferred approach, because that's simpler. Having it in both U-Boot and the
> kernel covers all situations, though. There would be no need for the
> bootloader
> to pa
Arnd Bergmann wrote:
> My point is that you could have some extra code that calls your
> qe_upload_firmware() when the device tree contains the blob but the boot
> loader did not already load it.
The current design of the 'firmware' node is such that if present, that means
that the firmware has
On Thursday 06 December 2007, Timur Tabi wrote:
> > I'm not trying to convince you of this if it's completely pointless for
> > all your systems, just want to make sure you're aware of this option,
> > because spending a few extra code lines on it now may save you some trouble
> > if you need this
Arnd Bergmann wrote:
> On Thursday 06 December 2007, Timur Tabi wrote:
>>> In that case, I think it
>>> would really be better to just put the blob into the tree and only
>>> have the fw loading code in the kernel instead of duplicating it in the boot
>>> loader.
>> That would require the firmware
On Thursday 06 December 2007, Timur Tabi wrote:
> > In that case, I think it
> > would really be better to just put the blob into the tree and only
> > have the fw loading code in the kernel instead of duplicating it in the boot
> > loader.
>
> That would require the firmware to present in RAM for
Arnd Bergmann wrote:
> What does the firmware node contain then? The way I read it, you only put
> metadata about the uploaded firmware in there, but not the blob itself, right?
That's correct. The meta-data is only the information that a device driver
would need to identify and interact with t
On Thursday 06 December 2007, Timur Tabi wrote:
> Arnd Bergmann wrote:
>
> > Of course, that approach does not help you if the blob is not GPL compatible
> > and you are relying on the dts file to be linked into the kernel,
>
> Well, the blobs will never be GPL compatible, which is why I created
Arnd Bergmann wrote:
> Of course, that approach does not help you if the blob is not GPL compatible
> and you are relying on the dts file to be linked into the kernel,
Well, the blobs will never be GPL compatible, which is why I created the
firmware binary format. Previously, the firmware was
On Wednesday 05 December 2007, Timur Tabi wrote:
> Define the layout of a binary blob that contains a QE firmware and
> instructions
> on how to upload it. Add function qe_upload_firmware() to parse the blob
> and perform the actual upload. Fully define 'struct rsp' in immap_qe.h to
> include th
Define the layout of a binary blob that contains a QE firmware and instructions
on how to upload it. Add function qe_upload_firmware() to parse the blob
and perform the actual upload. Fully define 'struct rsp' in immap_qe.h to
include the actual RISC Special Registers.
Signed-off-by: Timur Tabi
Define the layout of a binary blob that contains a QE firmware and instructions
on how to upload it. Add function qe_upload_firmware() to parse the blob
and perform the actual upload. Fully define 'struct rsp' in immap_qe.h to
include the actual RISC Special Registers.
Signed-off-by: Timur Tabi
Jerry Van Baren wrote:
>> +/*
>> + * Download a microcode to the I-RAM at a specific address.
>
>> + *
>> + * @firmware: pointer to qe_firmware structure
>> + */
>> +int qe_upload_microcode(const struct qe_firmware *firmware)
> ^^
> We seem to be a little conflicted ov
Jerry Van Baren wrote:
> We seem to be a little conflicted over whether it is an upload or a
> download. ;-)
Not me.
To the host == download
From the host == upload
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/l
Timur Tabi wrote:
> Define the layout of a binary blob that contains a QE firmware and
> instructions
> on how to upload it. Add function qe_upload_microcode() to parse the blob
> and perform the actual upload. Fully define 'struct rsp' in immap_qe.h to
> include the actual RISC Special Register
On Thu, Oct 18, 2007 at 02:02:38PM -0500, Timur Tabi wrote:
> Anton Vorontsov wrote:
>>> + if (firmware->length == (length + sizeof(u32))) {
>>> + /* Length is valid, and there's a CRC */
>>> + crc = be32_to_cpu(*((__be32 *) ((void *) firmware + length)));
>> Spaces are not ne
Anton Vorontsov wrote:
>> +if (firmware->length == (length + sizeof(u32))) {
>> +/* Length is valid, and there's a CRC */
>> +crc = be32_to_cpu(*((__be32 *) ((void *) firmware + length)));
>
> Spaces are not needed after "(__be32 *)" and "(void *)". The whole
> construc
On Thu, Oct 18, 2007 at 10:08:25AM -0500, Timur Tabi wrote:
> Define the layout of a binary blob that contains a QE firmware and
> instructions
> on how to upload it. Add function qe_upload_microcode() to parse the blob
> and perform the actual upload. Fully define 'struct rsp' in immap_qe.h to
Timur Tabi wrote:
> Define the layout of a binary blob that contains a QE firmware and
> instructions
> on how to upload it. Add function qe_upload_microcode() to parse the blob
> and perform the actual upload. Fully define 'struct rsp' in immap_qe.h to
> include the actual RISC Special Register
Define the layout of a binary blob that contains a QE firmware and instructions
on how to upload it. Add function qe_upload_microcode() to parse the blob
and perform the actual upload. Fully define 'struct rsp' in immap_qe.h to
include the actual RISC Special Registers.
Signed-off-by: Timur Tabi
39 matches
Mail list logo
