Re: powerpc64/hw_breakpoints: Handle data breakpoints in radix mode

2017-06-19 Thread Michael Ellerman
On Tue, 2017-06-13 at 18:42:00 UTC, "Naveen N. Rao" wrote: > On P9, trying to use data breakpoints throws the splat shown below (*). > This is because the check for a data breakpoint in DSISR is in > do_hash_page(). Move this check to handle_page_fault() so as to catch > data breakpoints in both ha

Re: [PATCH] powerpc64/hw_breakpoints: Handle data breakpoints in radix mode

2017-06-19 Thread Naveen N. Rao
On 2017/06/19 03:21PM, Aneesh Kumar K.V wrote: > "Naveen N. Rao" writes: > > > On 2017/06/16 03:16PM, Michael Ellerman wrote: > >> "Naveen N. Rao" writes: > >> > >> > diff --git a/arch/powerpc/kernel/exceptions-64s.S > >> > b/arch/powerpc/kernel/exceptions-64s.S > >> > index ae418b85c17c..17ee

Re: [PATCH] powerpc64/hw_breakpoints: Handle data breakpoints in radix mode

2017-06-19 Thread Aneesh Kumar K.V
"Naveen N. Rao" writes: > On 2017/06/16 03:16PM, Michael Ellerman wrote: >> "Naveen N. Rao" writes: >> >> > diff --git a/arch/powerpc/kernel/exceptions-64s.S >> > b/arch/powerpc/kernel/exceptions-64s.S >> > index ae418b85c17c..17ee701b8336 100644 >> > --- a/arch/powerpc/kernel/exceptions-64s.S

Re: [PATCH] powerpc64/hw_breakpoints: Handle data breakpoints in radix mode

2017-06-18 Thread Naveen N. Rao
On 2017/06/16 03:16PM, Michael Ellerman wrote: > "Naveen N. Rao" writes: > > > diff --git a/arch/powerpc/kernel/exceptions-64s.S > > b/arch/powerpc/kernel/exceptions-64s.S > > index ae418b85c17c..17ee701b8336 100644 > > --- a/arch/powerpc/kernel/exceptions-64s.S > > +++ b/arch/powerpc/kernel/exc

Re: [PATCH] powerpc64/hw_breakpoints: Handle data breakpoints in radix mode

2017-06-15 Thread Michael Ellerman
"Naveen N. Rao" writes: > diff --git a/arch/powerpc/kernel/exceptions-64s.S > b/arch/powerpc/kernel/exceptions-64s.S > index ae418b85c17c..17ee701b8336 100644 > --- a/arch/powerpc/kernel/exceptions-64s.S > +++ b/arch/powerpc/kernel/exceptions-64s.S > @@ -1442,7 +1440,9 @@ do_hash_page: > > /*

Re: [PATCH] powerpc64/hw_breakpoints: Handle data breakpoints in radix mode

2017-06-14 Thread Naveen N. Rao
On 2017/06/14 04:41PM, Michael Ellerman wrote: > "Aneesh Kumar K.V" writes: > > On Wednesday 14 June 2017 10:41 AM, Naveen N. Rao wrote: > >> On 2017/06/14 08:38AM, Aneesh Kumar K.V wrote: > >>> "Naveen N. Rao" writes: > diff --git a/arch/powerpc/kernel/exceptions-64s.S > b/arch/powerp

Re: [PATCH] powerpc64/hw_breakpoints: Handle data breakpoints in radix mode

2017-06-14 Thread Michael Ellerman
Anshuman Khandual writes: > On 06/14/2017 12:12 AM, Naveen N. Rao wrote: >> On P9, trying to use data breakpoints throws the splat shown below (*). >> This is because the check for a data breakpoint in DSISR is in >> do_hash_page(). Move this check to handle_page_fault() so as to catch >> data br

Re: [PATCH] powerpc64/hw_breakpoints: Handle data breakpoints in radix mode

2017-06-13 Thread Ram Pai
On Wed, Jun 14, 2017 at 10:43:30AM +0530, Aneesh Kumar K.V wrote: > > > On Wednesday 14 June 2017 10:41 AM, Naveen N. Rao wrote: > >Hi Aneesh, > > > >On 2017/06/14 08:38AM, Aneesh Kumar K.V wrote: > >>"Naveen N. Rao" writes: > >> > >>>On P9, trying to use data breakpoints throws the splat shown

Re: [PATCH] powerpc64/hw_breakpoints: Handle data breakpoints in radix mode

2017-06-13 Thread Michael Ellerman
"Aneesh Kumar K.V" writes: > On Wednesday 14 June 2017 10:41 AM, Naveen N. Rao wrote: >> On 2017/06/14 08:38AM, Aneesh Kumar K.V wrote: >>> "Naveen N. Rao" writes: diff --git a/arch/powerpc/kernel/exceptions-64s.S b/arch/powerpc/kernel/exceptions-64s.S index ae418b85c17c..17ee701b

Re: [PATCH] powerpc64/hw_breakpoints: Handle data breakpoints in radix mode

2017-06-13 Thread Anshuman Khandual
On 06/14/2017 12:12 AM, Naveen N. Rao wrote: > On P9, trying to use data breakpoints throws the splat shown below (*). > This is because the check for a data breakpoint in DSISR is in > do_hash_page(). Move this check to handle_page_fault() so as to catch > data breakpoints in both hash and radix M

Re: [PATCH] powerpc64/hw_breakpoints: Handle data breakpoints in radix mode

2017-06-13 Thread Aneesh Kumar K.V
On Wednesday 14 June 2017 10:41 AM, Naveen N. Rao wrote: Hi Aneesh, On 2017/06/14 08:38AM, Aneesh Kumar K.V wrote: "Naveen N. Rao" writes: On P9, trying to use data breakpoints throws the splat shown below (*). This is because the check for a data breakpoint in DSISR is in do_hash_page().

Re: [PATCH] powerpc64/hw_breakpoints: Handle data breakpoints in radix mode

2017-06-13 Thread Naveen N. Rao
Hi Aneesh, On 2017/06/14 08:38AM, Aneesh Kumar K.V wrote: > "Naveen N. Rao" writes: > > > On P9, trying to use data breakpoints throws the splat shown below (*). > > This is because the check for a data breakpoint in DSISR is in > > do_hash_page(). Move this check to handle_page_fault() so as to

Re: [PATCH] powerpc64/hw_breakpoints: Handle data breakpoints in radix mode

2017-06-13 Thread Aneesh Kumar K.V
"Naveen N. Rao" writes: > On P9, trying to use data breakpoints throws the splat shown below (*). > This is because the check for a data breakpoint in DSISR is in > do_hash_page(). Move this check to handle_page_fault() so as to catch > data breakpoints in both hash and radix MMU modes. > > While

[PATCH] powerpc64/hw_breakpoints: Handle data breakpoints in radix mode

2017-06-13 Thread Naveen N. Rao
On P9, trying to use data breakpoints throws the splat shown below (*). This is because the check for a data breakpoint in DSISR is in do_hash_page(). Move this check to handle_page_fault() so as to catch data breakpoints in both hash and radix MMU modes. While at it, also remove the label '11' th