Sergei, Thanks for your review!
> I suggest to also remove these 3 lines from the heading comment in this
> file -- they're not true anyway:
>
> * This file gets included from lowlevel asm headers too, to provide
> * wrapped versions of the local_irq_*() APIs, based on the
> * raw_loca
*sigh* I really shouldn't have mailed this out in the first place. Every
time I look at it I find new bugs despite the fact that it actually
works on my machine.
> ld r3,SOFTE(r1)
> - bl .local_irq_restore
> +#ifdef CONFIG_TRACE_IRQFLAGS
> + cmpdi r3,0
> + beq 14f
On Thu, 2007-07-05 at 00:40 +0200, Johannes Berg wrote:
> On Sat, 2007-06-30 at 10:58 +0200, Christoph Hellwig wrote:
> > On Thu, Jun 28, 2007 at 06:20:42PM +0200, Johannes Berg wrote:
> > > This one doesn't break 32-bit build by simply disabling irqtrace for
> > > 32-bit.
> >
> > This looks reall
Johannes Berg wrote:
> This one doesn't break 32-bit build by simply disabling irqtrace for
> 32-bit.
> --- linux-2.6-git32.orig/include/asm-powerpc/hw_irq.h 2007-06-28
> 14:53:58.730430447 +0200
> +++ linux-2.6-git32/include/asm-powerpc/hw_irq.h 2007-06-28
> 14:58:41.508430447 +0200
> @@ -
On Sat, 2007-06-30 at 10:58 +0200, Christoph Hellwig wrote:
> On Thu, Jun 28, 2007 at 06:20:42PM +0200, Johannes Berg wrote:
> > This one doesn't break 32-bit build by simply disabling irqtrace for
> > 32-bit.
>
> This looks really cool to me. I'd love to see this in 2.6.23.
Hmm. Looks like I ju
On Thu, Jun 28, 2007 at 06:20:42PM +0200, Johannes Berg wrote:
> This one doesn't break 32-bit build by simply disabling irqtrace for
> 32-bit.
This looks really cool to me. I'd love to see this in 2.6.23.
___
Linuxppc-dev mailing list
Linuxppc-dev@ozl
This one doesn't break 32-bit build by simply disabling irqtrace for
32-bit.
---
arch/powerpc/Kconfig|9 ++
arch/powerpc/kernel/Makefile|1
arch/powerpc/kernel/entry_64.S | 24 +
arch/powerpc/kernel/head_64.S | 54 +++
Here's a somewhat cleaned-up version that also works with preempt, still
64-bit only, still breaks 32-bit compile (I think, untested).
Works fine on my quad G5 and I've actually made a patch to lockdep to
support flagging my workqueue deadlock, that works too. And the XFS
report I had previously w
