Re: powerpc/xive: Fix offset for store EOI MMIOs

2017-06-15 Thread Michael Ellerman
On Wed, 2017-06-14 at 00:19:25 UTC, Benjamin Herrenschmidt wrote: > Architecturally we should apply a 0x400 offset for these. Not doing > it will break future HW implementations. > > Signed-off-by: Benjamin Herrenschmidt Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/2564270

Re: [PATCH] powerpc/xive: Fix offset for store EOI MMIOs

2017-06-14 Thread Benjamin Herrenschmidt
On Wed, 2017-06-14 at 14:44 +1000, Michael Ellerman wrote: > Benjamin Herrenschmidt writes: > > > Architecturally we should apply a 0x400 offset for these. Not doing > > it will break future HW implementations. > > Can you elaborate a bit? > > You're changing a write to 0x0 to be a write to 0x4

Re: [PATCH] powerpc/xive: Fix offset for store EOI MMIOs

2017-06-13 Thread Michael Ellerman
Benjamin Herrenschmidt writes: > Architecturally we should apply a 0x400 offset for these. Not doing > it will break future HW implementations. Can you elaborate a bit? You're changing a write to 0x0 to be a write to 0x400, which at face value appears like it breaks something, or is already bro

[PATCH] powerpc/xive: Fix offset for store EOI MMIOs

2017-06-13 Thread Benjamin Herrenschmidt
Architecturally we should apply a 0x400 offset for these. Not doing it will break future HW implementations. Signed-off-by: Benjamin Herrenschmidt --- arch/powerpc/include/asm/xive.h | 12 +++- arch/powerpc/kvm/book3s_xive_template.c | 4 ++-- arch/powerpc/sysdev/xive/common.c