On Thu, 2015-10-12 at 07:30:02 UTC, xinhui wrote:
> From: Pan Xinhui
>
> When we merge two contiguous partitions whose signatures are marked
> NVRAM_SIG_FREE, We need update prev's length and checksum, then write it
> to nvram, not cur's. So lets fix this mistake now.
>
> Also use memset instead
On 2016年06月07日 19:39, Michael Ellerman wrote:
On Mon, 2016-06-06 at 13:31 +0800, xinhui wrote:
On 2016年06月03日 19:47, Michael Ellerman wrote:
On Thu, 2015-10-12 at 07:30:02 UTC, xinhui wrote:
From: Pan Xinhui
When we merge two contiguous partitions whose signatures are marked
NVRAM_SIG_FREE
On Mon, 2016-06-06 at 13:31 +0800, xinhui wrote:
> On 2016年06月03日 19:47, Michael Ellerman wrote:
> > On Thu, 2015-10-12 at 07:30:02 UTC, xinhui wrote:
> > > From: Pan Xinhui
> > >
> > > When we merge two contiguous partitions whose signatures are marked
> > > NVRAM_SIG_FREE, We need update prev's
xinhui writes:
>> Has it always been broken?
>>
>
> no. after nvram partition corruption hit, all nvram partitions will be
> erased and re-alloc after the second machine reboot.
> I don't know who does it but i guess it is the firmware. :)
It is. PAPR says we format NVRAM when it's corrupted. Thi
On 2016年06月03日 19:47, Michael Ellerman wrote:
On Thu, 2015-10-12 at 07:30:02 UTC, xinhui wrote:
From: Pan Xinhui
When we merge two contiguous partitions whose signatures are marked
NVRAM_SIG_FREE, We need update prev's length and checksum, then write it
to nvram, not cur's. So lets fix this
On Thu, 2015-10-12 at 07:30:02 UTC, xinhui wrote:
> From: Pan Xinhui
>
> When we merge two contiguous partitions whose signatures are marked
> NVRAM_SIG_FREE, We need update prev's length and checksum, then write it
> to nvram, not cur's. So lets fix this mistake now.
>
> Also use memset instead
Hi, all
I do some tests *without* my fix patch. after reboot, I saw logs below.
[0.271236] WARNING: nvram partition checksum was 58, should be 24!
[0.271239] Terminating nvram partition scan
If I do tests *with* my fix patch, logs are:
[0.291419] NVRAM Partitions-
From: Pan Xinhui
When we merge two contiguous partitions whose signatures are marked
NVRAM_SIG_FREE, We need update prev's length and checksum, then write it
to nvram, not cur's. So lets fix this mistake now.
Also use memset instead of strncpy to set the partition's name. It's
more readable if w
