Re: powerpc/nvram: Fix a memory leak in err path

2016-09-20 Thread Michael Ellerman
On Wed, 2015-09-12 at 10:00:53 UTC, xinhui wrote: > If kmemdup fails, We need kfree *buff* first then return -ENOMEM. > Otherwise there is a memory leak. > > Signed-off-by: Pan Xinhui > Reviewed-by: Nathan Fontenot Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/0d0fecc5b5bfd

Re: [PATCH] powerpc/nvram: Fix a memory leak in err path

2015-12-09 Thread xinhui
On 2015/12/9 23:21, Nathan Fontenot wrote: On 12/09/2015 04:00 AM, xinhui wrote: If kmemdup fails, We need kfree *buff* first then return -ENOMEM. Otherwise there is a memory leak. Signed-off-by: Pan Xinhui Reviewed-by: Nathan Fontenot Hi Nathan, thank you for doing that :) th

Re: [PATCH] powerpc/nvram: Fix a memory leak in err path

2015-12-09 Thread Nathan Fontenot
On 12/09/2015 04:00 AM, xinhui wrote: > > If kmemdup fails, We need kfree *buff* first then return -ENOMEM. > Otherwise there is a memory leak. > > Signed-off-by: Pan Xinhui Reviewed-by: Nathan Fontenot > --- > arch/powerpc/kernel/nvram_64.c | 2 +- > 1 file changed, 1 insertion(+), 1 deleti

[PATCH] powerpc/nvram: Fix a memory leak in err path

2015-12-09 Thread xinhui
If kmemdup fails, We need kfree *buff* first then return -ENOMEM. Otherwise there is a memory leak. Signed-off-by: Pan Xinhui --- arch/powerpc/kernel/nvram_64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/nvram_64.c b/arch/powerpc/kernel/nvram_64.c in