Re: powerpc/kernel: Change retrieval of pci_dn

2017-08-31 Thread Michael Ellerman
On Tue, 2017-08-29 at 13:11:51 UTC, "Bryant G. Ly" wrote: > For a PCI device it's pci_dn can be retrieved from > pdev->dev.archdata.firmware_data, PCI_DN(devnode), or parent's list. > Thus, we should just use the existing function pci_get_pdn_by_devfn > to get the pci_dn. > > Signed-off-by: Bryant

Re: [PATCH] powerpc/kernel: Change retrieval of pci_dn

2017-08-29 Thread Bryant G. Ly
On 8/29/17 1:20 AM, Sam Bobroff wrote: On Mon, Aug 28, 2017 at 11:05:03AM -0500, Bryant G. Ly wrote: For a PCI device it's pci_dn can be retrieved from pdev->dev.archdata.firmware_data, PCI_DN(devnode), or parent's list. Thus, we should just use the generic function pci_get_pdn_by_devfn to get

Re: [PATCH] powerpc/kernel: Change retrieval of pci_dn

2017-08-29 Thread Bryant G. Ly
On 8/29/17 1:33 AM, Michael Ellerman wrote: "Bryant G. Ly" writes: For a PCI device it's pci_dn can be retrieved from pdev->dev.archdata.firmware_data, PCI_DN(devnode), or parent's list. Thus, we should just use the generic function pci_get_pdn_by_devfn to get the pci_dn. Signed-off-by: Brya

[PATCH] powerpc/kernel: Change retrieval of pci_dn

2017-08-29 Thread Bryant G. Ly
For a PCI device it's pci_dn can be retrieved from pdev->dev.archdata.firmware_data, PCI_DN(devnode), or parent's list. Thus, we should just use the existing function pci_get_pdn_by_devfn to get the pci_dn. Signed-off-by: Bryant G. Ly Reviewed-by: Sam Bobroff --- arch/powerpc/kernel/rtas_pci.c

Re: [PATCH] powerpc/kernel: Change retrieval of pci_dn

2017-08-28 Thread Michael Ellerman
"Bryant G. Ly" writes: > For a PCI device it's pci_dn can be retrieved from > pdev->dev.archdata.firmware_data, PCI_DN(devnode), or parent's list. > Thus, we should just use the generic function pci_get_pdn_by_devfn > to get the pci_dn. > > Signed-off-by: Bryant G. Ly Minor issue, it's preferab

Re: [PATCH] powerpc/kernel: Change retrieval of pci_dn

2017-08-28 Thread Michael Ellerman
Hi Bryant, Thanks for the patch, a few comments/questions. How have you tested this? "Bryant G. Ly" writes: > For a PCI device it's pci_dn can be retrieved from > pdev->dev.archdata.firmware_data, PCI_DN(devnode), or parent's list. > Thus, we should just use the generic function pci_get_pdn_by_

Re: [PATCH] powerpc/kernel: Change retrieval of pci_dn

2017-08-28 Thread Sam Bobroff
On Mon, Aug 28, 2017 at 11:05:03AM -0500, Bryant G. Ly wrote: > For a PCI device it's pci_dn can be retrieved from > pdev->dev.archdata.firmware_data, PCI_DN(devnode), or parent's list. > Thus, we should just use the generic function pci_get_pdn_by_devfn > to get the pci_dn. > > Signed-off-by: Bry

[PATCH] powerpc/kernel: Change retrieval of pci_dn

2017-08-28 Thread Bryant G. Ly
For a PCI device it's pci_dn can be retrieved from pdev->dev.archdata.firmware_data, PCI_DN(devnode), or parent's list. Thus, we should just use the generic function pci_get_pdn_by_devfn to get the pci_dn. Signed-off-by: Bryant G. Ly --- arch/powerpc/kernel/rtas_pci.c | 30 ++