Re: ocxl: Fix endiannes bug in ocxl_link_update_pe()

2018-12-22 Thread Michael Ellerman
On Sun, 2018-12-16 at 21:28:50 UTC, Greg Kurz wrote: > All fields in the PE are big-endian. Use cpu_to_be32() like everywhere > else something is written to the PE. Otherwise a wrong TID will be used > by the NPU. If this TID happens to point to an existing thread sharing > the same mm, it could be

Re: [PATCH] ocxl: Fix endiannes bug in ocxl_link_update_pe()

2018-12-20 Thread Greg Kurz
On Mon, 17 Dec 2018 11:38:51 +1100 "Alastair D'Silva" wrote: > On Sun, 2018-12-16 at 22:28 +0100, Greg Kurz wrote: > > All fields in the PE are big-endian. Use cpu_to_be32() like > > everywhere > > else something is written to the PE. Otherwise a wrong TID will be > > used > > by the NPU. If this

Re: [PATCH] ocxl: Fix endiannes bug in ocxl_link_update_pe()

2018-12-16 Thread Alastair D'Silva
On Sun, 2018-12-16 at 22:28 +0100, Greg Kurz wrote: > All fields in the PE are big-endian. Use cpu_to_be32() like > everywhere > else something is written to the PE. Otherwise a wrong TID will be > used > by the NPU. If this TID happens to point to an existing thread > sharing > the same mm, it cou

Re: [PATCH] ocxl: Fix endiannes bug in ocxl_link_update_pe()

2018-12-16 Thread Andrew Donnellan
On 17/12/18 8:28 am, Greg Kurz wrote: All fields in the PE are big-endian. Use cpu_to_be32() like everywhere else something is written to the PE. Otherwise a wrong TID will be used by the NPU. If this TID happens to point to an existing thread sharing the same mm, it could be woken up by error. T

[PATCH] ocxl: Fix endiannes bug in ocxl_link_update_pe()

2018-12-16 Thread Greg Kurz
All fields in the PE are big-endian. Use cpu_to_be32() like everywhere else something is written to the PE. Otherwise a wrong TID will be used by the NPU. If this TID happens to point to an existing thread sharing the same mm, it could be woken up by error. This is highly improbable though. The lik