Re: ocxl: Clarify error path in setup_xsl_irq()

2018-12-22 Thread Michael Ellerman
On Mon, 2018-12-10 at 15:18:13 UTC, Greg Kurz wrote: > Implementing rollback with goto and labels is a common practice that > leads to prettier and more maintainable code. FWIW, this design pattern > is already being used in alloc_link() a few lines below in this file. > > Do the same in setup_xsl

Re: [PATCH] ocxl: Clarify error path in setup_xsl_irq()

2018-12-20 Thread Greg Kurz
On Tue, 11 Dec 2018 11:19:55 +1100 Andrew Donnellan wrote: > On 11/12/18 2:18 am, Greg Kurz wrote: > > Implementing rollback with goto and labels is a common practice that > > leads to prettier and more maintainable code. FWIW, this design pattern > > is already being used in alloc_link() a few l

Re: [PATCH] ocxl: Clarify error path in setup_xsl_irq()

2018-12-10 Thread Andrew Donnellan
On 11/12/18 2:18 am, Greg Kurz wrote: Implementing rollback with goto and labels is a common practice that leads to prettier and more maintainable code. FWIW, this design pattern is already being used in alloc_link() a few lines below in this file. Do the same in setup_xsl_irq(). Signed-off-by:

Re: [PATCH] ocxl: Clarify error path in setup_xsl_irq()

2018-12-10 Thread Frederic Barrat
Le 10/12/2018 à 16:18, Greg Kurz a écrit : Implementing rollback with goto and labels is a common practice that leads to prettier and more maintainable code. FWIW, this design pattern is already being used in alloc_link() a few lines below in this file. Do the same in setup_xsl_irq(). Signed

[PATCH] ocxl: Clarify error path in setup_xsl_irq()

2018-12-10 Thread Greg Kurz
Implementing rollback with goto and labels is a common practice that leads to prettier and more maintainable code. FWIW, this design pattern is already being used in alloc_link() a few lines below in this file. Do the same in setup_xsl_irq(). Signed-off-by: Greg Kurz --- drivers/misc/ocxl/link.