Re: net_device_ops support in bridging and fec_mpc52xx.c

2009-03-21 Thread Grant Likely
Henk, At the very least, I still need a signed-off-by: line from you on this one. g. On Tue, Mar 10, 2009 at 11:13 AM, Grant Likely wrote: > Hi Henk, > > Acked-by: Grant Likely > > Can you please repost with a blurb for the commit description and your > signed-off-by line?  The blub below make

Re: net_device_ops support in bridging and fec_mpc52xx.c

2009-03-10 Thread Grant Likely
On Tue, Mar 10, 2009 at 11:19 AM, David Miller wrote: > Send it to netdev, CC:'d to me, Jeff hasn't been handling networking > driver changes for a while now. Ah, okay. I didn't know. I looked in MAINTAINERS today, and Jeff is listed there for NETWORK DEVICE DRIVERS. g. -- Grant Likely, B.Sc

Re: net_device_ops support in bridging and fec_mpc52xx.c

2009-03-10 Thread David Miller
From: Grant Likely Date: Tue, 10 Mar 2009 11:13:02 -0600 > Hi Henk, > > Acked-by: Grant Likely ... > Jeff, after Henk provides his s-o-b line, do you want to pick it up, > or should I merge it through my mpc52xx powerpc tree (via benh). Send it to netdev, CC:'d to me, Jeff hasn't been handlin

Re: net_device_ops support in bridging and fec_mpc52xx.c

2009-03-10 Thread Grant Likely
Hi Henk, Acked-by: Grant Likely Can you please repost with a blurb for the commit description and your signed-off-by line? The blub below makes sense in the context of this mailing list thread, but it won't be very useful for someone looking at the commit message in git. Also, your patch is li

Re: net_device_ops support in bridging and fec_mpc52xx.c

2009-02-19 Thread Henk Stegeman
I must have made a mistake when I tested the previous patch, I discovered later it still had errors: - I had accidentally removed the base address in the fec_mpc52xx driver. - The priv->phydev pointer was sometimes not initialized (NULL) but still passed by the fec_mpc52xx driver, this pointer is t

Re: net_device_ops support in bridging and fec_mpc52xx.c

2009-02-18 Thread Stephen Hemminger
On Wed, 18 Feb 2009 13:48:52 -0800 (PST) David Miller wrote: > From: Henk Stegeman > Date: Wed, 18 Feb 2009 11:41:14 +0100 > > Please CC: netdev, now added, on all networking reports and patches. > > Thank you. > > > I discovered the hard way that because linux bridging uses > > net_device_op

Re: net_device_ops support in bridging and fec_mpc52xx.c

2009-02-18 Thread David Miller
From: Henk Stegeman Date: Wed, 18 Feb 2009 11:41:14 +0100 Please CC: netdev, now added, on all networking reports and patches. Thank you. > I discovered the hard way that because linux bridging uses > net_device_ops, bridging only works with network drivers that publish > their device operation

net_device_ops support in bridging and fec_mpc52xx.c

2009-02-18 Thread Henk Stegeman
Hello, I discovered the hard way that because linux bridging uses net_device_ops, bridging only works with network drivers that publish their device operations trough net_device_ops. In my case running: brctl addif br0 eth0 (where eth0 fec_mpc52xx.c did not yet support net_device_ops) gave me a: