RE: memcpy regression

2015-09-08 Thread David Laight
> > What about run-time patching memcpy() after the caches are initialised? > > Yeah, that's the solution we use on 64-bit. > > It also means you can have cpu specific optimisations, which can be patched in > or out using the cpu feature patching. I've noticed x86 doing that. For newer Intel par

Re: memcpy regression

2015-09-07 Thread Michael Ellerman
On Mon, 2015-09-07 at 10:59 +, David Laight wrote: > From: Michal Sojka > > >> I think GCC uses memcpy() in well known situations like initialising > > >> structures or copying structures. > > >> Shouldn't we just avoid this kind of actions in the very few early init > > >> functions ? > > > Wh

Re: memcpy regression

2015-09-07 Thread Michal Sojka
On 4.9.2015 21:49, Michal Sojka wrote: On 4.9.2015 20:10, christophe leroy wrote: Le 04/09/2015 16:35, Michal Sojka a écrit : On Fri, Sep 04 2015, Christophe LEROY wrote: Le 04/09/2015 15:33, Michal Sojka a écrit : Dear Christophe, my MPC5200-based system stopped booting recently. I bisect

Re: memcpy regression

2015-09-07 Thread Michal Sojka
On 4.9.2015 20:10, christophe leroy wrote: Le 04/09/2015 16:35, Michal Sojka a écrit : On Fri, Sep 04 2015, Christophe LEROY wrote: Le 04/09/2015 15:33, Michal Sojka a écrit : Dear Christophe, my MPC5200-based system stopped booting recently. I bisected the problem to your commit below. I

Re: memcpy regression

2015-09-07 Thread Michal Sojka
On Fri, Sep 04 2015, Christophe LEROY wrote: > Le 04/09/2015 15:33, Michal Sojka a écrit : >> Dear Christophe, >> >> my MPC5200-based system stopped booting recently. I bisected the problem >> to your commit below. If I revert that commit (on top of >> 807249d3ada1ff28a47c4054ca4edd479421b671 = v4.

memcpy regression

2015-09-07 Thread Michal Sojka
Dear Christophe, my MPC5200-based system stopped booting recently. I bisected the problem to your commit below. If I revert that commit (on top of 807249d3ada1ff28a47c4054ca4edd479421b671 = v4.2-6663-g807249d), my system boots again. commit 0b05e2d671c40cfb57e66e4e402320d6e056b2f8 Author: LEROY C

RE: memcpy regression

2015-09-07 Thread David Laight
From: Michal Sojka > >> I think GCC uses memcpy() in well known situations like initialising > >> structures or copying structures. > >> Shouldn't we just avoid this kind of actions in the very few early init > >> functions ? > > Which are the "very few" early init functions? Can you make a list, f

Re: memcpy regression

2015-09-07 Thread Michal Sojka
On 7.9.2015 10:40, Michael Ellerman wrote: On Mon, 2015-09-07 at 09:08 +0200, Christophe LEROY wrote: Hi Michael Le 07/09/2015 03:14, Michael Ellerman a écrit : On Sun, 2015-09-06 at 23:01 +0200, Michal Sojka wrote: I found the problem. The compiler replaces an assignment with a call to memcp

Re: memcpy regression

2015-09-07 Thread Michael Ellerman
On Mon, 2015-09-07 at 09:08 +0200, Christophe LEROY wrote: > Hi Michael > > Le 07/09/2015 03:14, Michael Ellerman a écrit : > > On Sun, 2015-09-06 at 23:01 +0200, Michal Sojka wrote: > >> I found the problem. The compiler replaces an assignment with a call to > >> memcpy. The following patch fixes

Re: memcpy regression

2015-09-07 Thread Christophe LEROY
Hi Michael Le 07/09/2015 03:14, Michael Ellerman a écrit : Hi Michal, Thanks for finding the problem. On Sun, 2015-09-06 at 23:01 +0200, Michal Sojka wrote: I found the problem. The compiler replaces an assignment with a call to memcpy. The following patch fixes the problem for me. However, I

Re: memcpy regression

2015-09-06 Thread Michael Ellerman
Hi Michal, Thanks for finding the problem. On Sun, 2015-09-06 at 23:01 +0200, Michal Sojka wrote: > > I found the problem. The compiler replaces an assignment with a call to > memcpy. The following patch fixes the problem for me. However, I'm not > sure whether this is the real solution. I guess

Re: memcpy regression

2015-09-06 Thread Michal Sojka
On Sun, Sep 06 2015, Michal Sojka wrote: > On Sun, Sep 06 2015, christophe leroy wrote: >> Le 05/09/2015 02:08, Michal Sojka a écrit : >>> On 4.9.2015 21:49, Michal Sojka wrote: On 4.9.2015 20:10, christophe leroy wrote: > > > Le 04/09/2015 16:35, Michal Sojka a écrit : >> On F

Re: memcpy regression

2015-09-06 Thread Michal Sojka
On Sun, Sep 06 2015, christophe leroy wrote: > Le 05/09/2015 02:08, Michal Sojka a écrit : >> On 4.9.2015 21:49, Michal Sojka wrote: >>> On 4.9.2015 20:10, christophe leroy wrote: Le 04/09/2015 16:35, Michal Sojka a écrit : > On Fri, Sep 04 2015, Christophe LEROY wrote: >> Le

Re: memcpy regression

2015-09-06 Thread christophe leroy
Le 05/09/2015 02:08, Michal Sojka a écrit : On 4.9.2015 21:49, Michal Sojka wrote: On 4.9.2015 20:10, christophe leroy wrote: Le 04/09/2015 16:35, Michal Sojka a écrit : On Fri, Sep 04 2015, Christophe LEROY wrote: Le 04/09/2015 15:33, Michal Sojka a écrit : Dear Christophe, my MPC5200-

Re: memcpy regression

2015-09-04 Thread christophe leroy
Le 04/09/2015 16:35, Michal Sojka a écrit : On Fri, Sep 04 2015, Christophe LEROY wrote: Le 04/09/2015 15:33, Michal Sojka a écrit : Dear Christophe, my MPC5200-based system stopped booting recently. I bisected the problem to your commit below. If I revert that commit (on top of 807249d3ada1

Re: memcpy regression

2015-09-04 Thread Christophe LEROY
Le 04/09/2015 15:33, Michal Sojka a écrit : Dear Christophe, my MPC5200-based system stopped booting recently. I bisected the problem to your commit below. If I revert that commit (on top of 807249d3ada1ff28a47c4054ca4edd479421b671 = v4.2-6663-g807249d), my system boots again. Do you use ma

[PATCH] powerpc: Fix 64bit memcpy() regression

2009-02-25 Thread Mark Nelson
This fixes a regression introduced by commit 25d6e2d7c58ddc4a3b614fc5381591c0cfe66556 ("powerpc: Update 64bit memcpy() using CPU_FTR_UNALIGNED_LD_STD"). This commit allowed CPUs that have the CPU_FTR_UNALIGNED_LD_STD CPU feature bit present to do the memcpy() with unaligned load doubles. But, alon