Re: issues w/init

2009-04-17 Thread Benjamin Herrenschmidt
On Fri, 2009-04-17 at 12:40 -0500, Kumar Gala wrote: > > 1- In binfmt_elf.c, what happens with this statement ? > > > >if (elf_read_implies_exec(loc->elf_ex, executable_stack)) > >current->personality |= READ_IMPLIES_EXEC; > > on ppc32 noting as its elf_read_implies_exec is

Re: issues w/init

2009-04-17 Thread Kumar Gala
On Apr 17, 2009, at 12:03 PM, Benjamin Herrenschmidt wrote: On Fri, 2009-04-17 at 08:23 -0500, Kumar Gala wrote: I can and might have already done this, need to double check. But what I was seeing from elf_map is that we don't get PROT_EXEC set for this PHDR, but get VM_MAY_EXEC. I'm not cle

Re: issues w/init

2009-04-17 Thread Benjamin Herrenschmidt
> On ppc32 personality is clearly set to 0. On ppc64 the > elf_read_implies_exec does work around the issue (ie I implemented > elf_read_implies_exec as (exec_stk != EXSTACK_DISABLE_X) on ppc32). > However I think its just masking it. How so ? IE, it checks for PT_GNU_STACK, if not presen

Re: issues w/init

2009-04-17 Thread Benjamin Herrenschmidt
On Fri, 2009-04-17 at 08:23 -0500, Kumar Gala wrote: > I can and might have already done this, need to double check. But > what I was seeing from elf_map is that we don't get PROT_EXEC set for > this PHDR, but get VM_MAY_EXEC. I'm not clear on what VM_MAY_EXEC is > intended for. Looking at

Re: issues w/init

2009-04-17 Thread Kumar Gala
On Apr 17, 2009, at 5:41 AM, Benjamin Herrenschmidt wrote: On Fri, 2009-04-17 at 20:05 +1000, Paul Mackerras wrote: Benjamin Herrenschmidt writes: I'm pretty sure they are broken already when running off a 64-bit kernel, Maybe not... for 64-bit kernels we have our definition of elf_read_im

Re: issues w/init

2009-04-17 Thread Kumar Gala
On Apr 17, 2009, at 5:41 AM, Benjamin Herrenschmidt wrote: On Fri, 2009-04-17 at 20:05 +1000, Paul Mackerras wrote: Benjamin Herrenschmidt writes: I'm pretty sure they are broken already when running off a 64-bit kernel, Maybe not... for 64-bit kernels we have our definition of elf_read_im

Re: issues w/init

2009-04-17 Thread Benjamin Herrenschmidt
On Fri, 2009-04-17 at 20:05 +1000, Paul Mackerras wrote: > Benjamin Herrenschmidt writes: > > > I'm pretty sure they are broken already when running off a 64-bit > > kernel, > > Maybe not... for 64-bit kernels we have our definition of > elf_read_implies_exec in arch/powerpc/include/asm/elf.h, wh

Re: issues w/init

2009-04-17 Thread Benjamin Herrenschmidt
On Fri, 2009-04-17 at 20:05 +1000, Paul Mackerras wrote: > Benjamin Herrenschmidt writes: > > > I'm pretty sure they are broken already when running off a 64-bit > > kernel, > > Maybe not... for 64-bit kernels we have our definition of > elf_read_implies_exec in arch/powerpc/include/asm/elf.h, wh

Re: issues w/init

2009-04-17 Thread Paul Mackerras
Benjamin Herrenschmidt writes: > I'm pretty sure they are broken already when running off a 64-bit > kernel, Maybe not... for 64-bit kernels we have our definition of elf_read_implies_exec in arch/powerpc/include/asm/elf.h, which IIRC sets the read-implies-exec personality thing on old 32-bit bin

Re: issues w/init

2009-04-17 Thread Benjamin Herrenschmidt
On Thu, 2009-04-16 at 14:27 -0500, Kumar Gala wrote: > On Apr 16, 2009, at 2:25 PM, Scott Wood wrote: > > > Kumar Gala wrote: > >> [root:~] cat /proc/1/maps > >> 0010-00103000 r-xp 0010 00:00 0 [vdso] > >> 0feab000-0ffbe000 r-xp 00:0d 7127086/lib/libc-2.2.5.so > >> 0f

Re: issues w/init

2009-04-17 Thread Benjamin Herrenschmidt
On Thu, 2009-04-16 at 13:53 -0500, Kumar Gala wrote: > A bit more debug info that might be helpful, I'm hitting this bad_area > fault : > > if (!(vma->vm_flags & VM_EXEC) && > (cpu_has_feature(CPU_FTR_NOEXECUTE) || > !(vma->vm_flags &

Re: issues w/init

2009-04-17 Thread Benjamin Herrenschmidt
On Thu, 2009-04-16 at 13:21 -0500, Kumar Gala wrote: > Ben, > > The following patch is causing me issues w/init SEGV on boot. This is > a pretty old version of init and I'm wondering what the commit you had > related to old ABI breakage: Can you test if the binary

Re: issues w/init

2009-04-16 Thread Kumar Gala
On Apr 16, 2009, at 2:25 PM, Scott Wood wrote: Kumar Gala wrote: [root:~] cat /proc/1/maps 0010-00103000 r-xp 0010 00:00 0 [vdso] 0feab000-0ffbe000 r-xp 00:0d 7127086/lib/libc-2.2.5.so 0ffbe000-0ffcb000 ---p 00113000 00:0d 7127086/lib/libc-2.2.5.so 0ffcb000-0f

Re: issues w/init

2009-04-16 Thread Scott Wood
Kumar Gala wrote: [root:~] cat /proc/1/maps 0010-00103000 r-xp 0010 00:00 0 [vdso] 0feab000-0ffbe000 r-xp 00:0d 7127086/lib/libc-2.2.5.so 0ffbe000-0ffcb000 ---p 00113000 00:0d 7127086/lib/libc-2.2.5.so 0ffcb000-0ffeb000 rw-p 0011 00:0d 7127086/lib/libc-2.

Re: issues w/init

2009-04-16 Thread Kumar Gala
On Apr 16, 2009, at 1:21 PM, Kumar Gala wrote: Ben, The following patch is causing me issues w/init SEGV on boot. This is a pretty old version of init and I'm wondering what the commit you had related to old ABI breakage: commit 8d30c14cab30d405a05f2aaceda1e9ad57800f36 Author: Ben

issues w/init

2009-04-16 Thread Kumar Gala
Ben, The following patch is causing me issues w/init SEGV on boot. This is a pretty old version of init and I'm wondering what the commit you had related to old ABI breakage: commit 8d30c14cab30d405a05f2aaceda1e9ad57800f36 Author: Benjamin Herrenschmidt Date: Tue Feb 10 16:02:37