Re: issues calling of_platform_bus_probe() twice

2012-03-18 Thread Grant Likely
On Sun, 18 Mar 2012 16:14:23 +, Tabi Timur-B04825 wrote: > Grant Likely wrote: > > That's because you're using it wrong. of_platform_bus_probe() creates > > platform devices at the starting level and every level below it as > > described by the bus ids. It is illegal to call of_platform_bus

Re: issues calling of_platform_bus_probe() twice

2012-03-18 Thread Tabi Timur-B04825
Grant Likely wrote: > That's because you're using it wrong. of_platform_bus_probe() creates > platform devices at the starting level and every level below it as > described by the bus ids. It is illegal to call of_platform_bus_probe() > twice at the same level in the DT. Well, *I* am not using i

Re: issues calling of_platform_bus_probe() twice

2012-03-18 Thread Grant Likely
On Sat, 17 Mar 2012 13:35:02 +, Tabi Timur-B04825 wrote: > Grant Likely wrote: > >>> > > Are you aware of any reason that we can't call > >>> > of_platform_bus_probe() > >>> > > or multiple times. Timur's run into an issue in which all devices > >>> > > don't get registered properly i

Re: issues calling of_platform_bus_probe() twice

2012-03-17 Thread Tabi Timur-B04825
Benjamin Herrenschmidt wrote: > Why don't you track down the actual bug instead ? I was hoping that someone who is very familiar with the code would take a look. I don't know the OF layer that well. -- Timur Tabi Linux kernel developer at Freescale _

Re: issues calling of_platform_bus_probe() twice

2012-03-17 Thread Benjamin Herrenschmidt
On Sat, 2012-03-17 at 13:35 +, Tabi Timur-B04825 wrote: > >>> > > Are you aware of any reason that we can't call > of_platform_bus_probe() > >>> > > or multiple times. Timur's run into an issue in which all > devices > >>> > > don't get registered properly if we call > of_platform_bus_pr

Re: issues calling of_platform_bus_probe() twice

2012-03-17 Thread Tabi Timur-B04825
Grant Likely wrote: >>> > > Are you aware of any reason that we can't call of_platform_bus_probe() >>> > > or multiple times. Timur's run into an issue in which all devices >>> > > don't get registered properly if we call of_platform_bus_probe() times >>> > > with different of_device_id st

Re: issues calling of_platform_bus_probe() twice

2012-03-17 Thread Grant Likely
On Sat, 17 Mar 2012 08:23:54 +1100, Benjamin Herrenschmidt wrote: > On Fri, 2012-03-16 at 16:21 -0500, Kumar Gala wrote: > > Guys, > > > > Are you aware of any reason that we can't call of_platform_bus_probe() > > or multiple times. Timur's run into an issue in which all devices > > don't get r

Re: issues calling of_platform_bus_probe() twice

2012-03-16 Thread Benjamin Herrenschmidt
On Fri, 2012-03-16 at 16:21 -0500, Kumar Gala wrote: > Guys, > > Are you aware of any reason that we can't call of_platform_bus_probe() > or multiple times. Timur's run into an issue in which all devices > don't get registered properly if we call of_platform_bus_probe() times > with different of_

issues calling of_platform_bus_probe() twice

2012-03-16 Thread Kumar Gala
Guys, Are you aware of any reason that we can't call of_platform_bus_probe() or multiple times. Timur's run into an issue in which all devices don't get registered properly if we call of_platform_bus_probe() times with different of_device_id struct's. - k _