Re: in_be32() etc

2012-02-23 Thread Grant Likely
turn (in_be32(mm_gc->regs + XGPIO_DATA_OFFSET) >> gpio) & 1; >> > } >> > >> > include/linux/of_gpio.h: >> > struct of_mm_gpio_chip { >> >         struct gpio_chip gc; >> >         void (*save_regs)(struct of_mm_gpio_chip *mm_

Re: in_be32() etc

2012-02-23 Thread Russell King - ARM Linux
> struct of_mm_gpio_chip { > > struct gpio_chip gc; > > void (*save_regs)(struct of_mm_gpio_chip *mm_gc); > > void __iomem *regs; > > }; > > > > Why am I being asked to add in_be32() etc to ARMs io.h ? Why do we need > > yet an

Re: in_be32() etc

2012-02-23 Thread Benjamin Herrenschmidt
; > void (*save_regs)(struct of_mm_gpio_chip *mm_gc); > void __iomem *regs; > }; > > Why am I being asked to add in_be32() etc to ARMs io.h ? Why do we need > yet another set of IO accessors? Is there something wrong with > ioread*()/ioread*be() etc? Nope, nothing wrong wi

in_be32() etc

2012-02-23 Thread Russell King - ARM Linux
; } include/linux/of_gpio.h: struct of_mm_gpio_chip { struct gpio_chip gc; void (*save_regs)(struct of_mm_gpio_chip *mm_gc); void __iomem *regs; }; Why am I being asked to add in_be32() etc to ARMs io.h ? Why do we need yet another set of IO accessors? Is there something