Re: eeh-powernv.c: Unbalanced IRQ warning

2015-07-27 Thread Alistair Popple
On Tue, 28 Jul 2015 11:56:31 Daniel Axtens wrote: > Hi Alistair and Gavin, > > The patch from Alistair fixes my issue. Thanks heaps! > > Alistair, are you right to post that formally? Yep. I'll post it tomorrow morning. > Regards, > Daniel > > On Tue, 2015-07-28 at 11:28 +1000, Gavin Shan wrot

Re: eeh-powernv.c: Unbalanced IRQ warning

2015-07-27 Thread Daniel Axtens
Hi Alistair and Gavin, The patch from Alistair fixes my issue. Thanks heaps! Alistair, are you right to post that formally? Regards, Daniel On Tue, 2015-07-28 at 11:28 +1000, Gavin Shan wrote: > On Tue, Jul 28, 2015 at 11:14:51AM +1000, Alistair Popple wrote: > >Hi Daniel, > > > >I see the prob

Re: eeh-powernv.c: Unbalanced IRQ warning

2015-07-27 Thread Gavin Shan
On Tue, Jul 28, 2015 at 11:14:51AM +1000, Alistair Popple wrote: >Hi Daniel, > >I see the problem - pnv_eeh_next_error() re-enables the interrupt but it gets >called from a loop if there are more outstanding events to process. The most >obvious solution would be to do this check before enabling i

Re: eeh-powernv.c: Unbalanced IRQ warning

2015-07-27 Thread Alistair Popple
Hi Daniel, I see the problem - pnv_eeh_next_error() re-enables the interrupt but it gets called from a loop if there are more outstanding events to process. The most obvious solution would be to do this check before enabling interrupts: if (ret == EEH_NEXT_ERR_NONE && eeh_enabled()) in

Re: eeh-powernv.c: Unbalanced IRQ warning

2015-07-27 Thread Gavin Shan
On Mon, Jul 27, 2015 at 05:37:03PM +1000, Daniel Axtens wrote: >Hi Alistair, > >I've just rebased some CAPI patches on top of 4.2-rc4 and I'm getting a >new WARN relating to IRQs in EEH, which I believe is related to your >patch 79231448c929 ("powernv/eeh: Update the EEH code to use the opal >irq d

eeh-powernv.c: Unbalanced IRQ warning

2015-07-27 Thread Daniel Axtens
Hi Alistair, I've just rebased some CAPI patches on top of 4.2-rc4 and I'm getting a new WARN relating to IRQs in EEH, which I believe is related to your patch 79231448c929 ("powernv/eeh: Update the EEH code to use the opal irq domain"). This is what I see after injecting a PHB fence on a CAPI ca