Re: drivers/tty: ehv_bytechan fails to build as a module

2014-01-07 Thread Greg KH
On Tue, Jan 07, 2014 at 07:21:03PM -0600, Scott Wood wrote: > On Sat, 2014-01-04 at 11:15 -0800, Guenter Roeck wrote: > > On Mon, Dec 09, 2013 at 04:03:10PM +1100, Anton Blanchard wrote: > > > ehv_bytechan is marked tristate but fails to build as a module: > > > > > > drivers/tty/ehv_bytechan.c:36

Re: drivers/tty: ehv_bytechan fails to build as a module

2014-01-07 Thread Scott Wood
On Sat, 2014-01-04 at 11:15 -0800, Guenter Roeck wrote: > On Mon, Dec 09, 2013 at 04:03:10PM +1100, Anton Blanchard wrote: > > ehv_bytechan is marked tristate but fails to build as a module: > > > > drivers/tty/ehv_bytechan.c:363:1: error: type defaults to ‘int’ in > > declaration of ‘console_ini

Re: drivers/tty: ehv_bytechan fails to build as a module

2014-01-04 Thread Guenter Roeck
On Mon, Dec 09, 2013 at 04:03:10PM +1100, Anton Blanchard wrote: > ehv_bytechan is marked tristate but fails to build as a module: > > drivers/tty/ehv_bytechan.c:363:1: error: type defaults to ‘int’ in > declaration of ‘console_initcall’ [-Werror=implicit-int] > > It doesn't make much sense for

[PATCH] drivers/tty: ehv_bytechan fails to build as a module

2013-12-08 Thread Anton Blanchard
ehv_bytechan is marked tristate but fails to build as a module: drivers/tty/ehv_bytechan.c:363:1: error: type defaults to ‘int’ in declaration of ‘console_initcall’ [-Werror=implicit-int] It doesn't make much sense for a console driver to be built as a module, so change it to a bool. Signed-of