Re: crash in init_ipic_sysfs on efika

2008-03-24 Thread Kumar Gala
On Mar 24, 2008, at 3:02 AM, Paul Mackerras wrote: Kumar Gala writes: since you are going to send something to linus let me update the fsl defconfigs and send you a pull request. OK -- I'm about to send Linus a pull request now in case he feels like releasing 2.6.25 this weekend. I'll send

Re: crash in init_ipic_sysfs on efika

2008-03-24 Thread Matt Sealey
My assessment of the situation is: not at all. -- Matt Sealey <[EMAIL PROTECTED]> Genesi, Manager, Developer Relations Grant Likely wrote: On Fri, Mar 21, 2008 at 7:14 AM, Matt Sealey <[EMAIL PROTECTED]> wrote: Is the MPC5200B PSC-AC97 driver in there? Audio drivers need to go in via one of

Re: crash in init_ipic_sysfs on efika

2008-03-24 Thread Paul Mackerras
Kumar Gala writes: > since you are going to send something to linus let me update the fsl > defconfigs and send you a pull request. OK -- I'm about to send Linus a pull request now in case he feels like releasing 2.6.25 this weekend. I'll send him another pull request with your defconfig update

Re: crash in init_ipic_sysfs on efika

2008-03-23 Thread Sven Luther
On Sun, Mar 23, 2008 at 10:13:12AM +, David Woodhouse wrote: > On Sun, 2008-03-23 at 11:12 +0100, Sven Luther wrote: > > On Sun, Mar 23, 2008 at 09:00:41AM +, David Woodhouse wrote: > > > On Sat, 2008-03-22 at 16:25 +0100, Sven Luther wrote: > > > > BTW, it was reported to me that the ether

Re: crash in init_ipic_sysfs on efika

2008-03-23 Thread David Woodhouse
On Sun, 2008-03-23 at 11:12 +0100, Sven Luther wrote: > On Sun, Mar 23, 2008 at 09:00:41AM +, David Woodhouse wrote: > > On Sat, 2008-03-22 at 16:25 +0100, Sven Luther wrote: > > > BTW, it was reported to me that the ethernet drivers don't get > > > autoloaded by udev. Is this a failure of udev

Re: crash in init_ipic_sysfs on efika

2008-03-23 Thread Sven Luther
On Sun, Mar 23, 2008 at 09:00:41AM +, David Woodhouse wrote: > On Sat, 2008-03-22 at 16:25 +0100, Sven Luther wrote: > > BTW, it was reported to me that the ethernet drivers don't get > > autoloaded by udev. Is this a failure of udev missing the of_plateform > > support, or a deficiency of the

Re: crash in init_ipic_sysfs on efika

2008-03-23 Thread David Woodhouse
On Sat, 2008-03-22 at 16:25 +0100, Sven Luther wrote: > BTW, it was reported to me that the ethernet drivers don't get > autoloaded by udev. Is this a failure of udev missing the of_plateform > support, or a deficiency of the ethernet drivers ? As far as I know, they _are_ being loaded properly.

Re: crash in init_ipic_sysfs on efika

2008-03-22 Thread Sven Luther
On Fri, Mar 21, 2008 at 12:51:46PM -0600, Grant Likely wrote: > On Fri, Mar 21, 2008 at 7:14 AM, Matt Sealey <[EMAIL PROTECTED]> wrote: > > Is the MPC5200B PSC-AC97 driver in there? > > Audio drivers need to go in via one of the ALSA developers and I > haven't been paying close enough attention to

Re: crash in init_ipic_sysfs on efika

2008-03-21 Thread Grant Likely
On Fri, Mar 21, 2008 at 7:14 AM, Matt Sealey <[EMAIL PROTECTED]> wrote: > Is the MPC5200B PSC-AC97 driver in there? Audio drivers need to go in via one of the ALSA developers and I haven't been paying close enough attention to know if it has not in yet. g. -- Grant Likely, B.Sc., P.Eng. Secret

Re: crash in init_ipic_sysfs on efika

2008-03-21 Thread Matt Sealey
Is the MPC5200B PSC-AC97 driver in there? -- Matt Sealey <[EMAIL PROTECTED]> Genesi, Manager, Developer Relations Paul Mackerras wrote: Grant Likely writes: Confirmed, this patch fixes the problem. Paulus or Kumar, can you please pick it up for .25? Sure, will do. I thought about putting

Re: crash in init_ipic_sysfs on efika

2008-03-21 Thread Benjamin Herrenschmidt
On Thu, 2008-03-20 at 11:32 +, Matt Sealey wrote: > subsys_initcall(init_ipic_sysfs); <-- this, in my eyes, is the culprit. If > init_ipic() runs, init_ipic_sysfs should be called from that, not left for > some further subsystem to blindly try and register sysfs nodes for devices > which may n

Re: crash in init_ipic_sysfs on efika

2008-03-21 Thread Kumar Gala
On Fri, 21 Mar 2008, Paul Mackerras wrote: > Grant Likely writes: > > > Confirmed, this patch fixes the problem. Paulus or Kumar, can you > > please pick it up for .25? > > Sure, will do. I thought about putting it in the last batch but I > wanted an ack from you. > > Anyone else got any last-mi

Re: crash in init_ipic_sysfs on efika

2008-03-21 Thread Paul Mackerras
Grant Likely writes: > Confirmed, this patch fixes the problem. Paulus or Kumar, can you > please pick it up for .25? Sure, will do. I thought about putting it in the last batch but I wanted an ack from you. Anyone else got any last-minute things for 2.6.25? Paul.

Re: crash in init_ipic_sysfs on efika

2008-03-20 Thread Grant Likely
On Mon, Mar 17, 2008 at 1:53 PM, Olaf Hering <[EMAIL PROTECTED]> wrote: > > I cant reproduce this bug on my board, but: > > The global primary_ipic in arch/powerpc/sysdev/ipic.c can remain NULL if > ipic_init() fails. init_ipic_sysfs() will crash in that case. > > Something like this may fix it

Re: crash in init_ipic_sysfs on efika

2008-03-20 Thread Paul Mackerras
Kumar Gala writes: > We should look and see if we can change init_ipic_sysfs() from a > subsys_initcall() to just getting called at the end of ipic_init(). If init_ipic is called from init_IRQ then I would expect that's way too early to be calling sysfs stuff. Paul. ___

Re: crash in init_ipic_sysfs on efika

2008-03-20 Thread Kumar Gala
On Mar 17, 2008, at 2:53 PM, Olaf Hering wrote: I cant reproduce this bug on my board, but: The global primary_ipic in arch/powerpc/sysdev/ipic.c can remain NULL if ipic_init() fails. init_ipic_sysfs() will crash in that case. Something like this may fix it: Index: linux-2.6.25-rc6/arch/p

Re: crash in init_ipic_sysfs on efika

2008-03-20 Thread Matt Sealey
This was a good catch. IPIC is the controller on the MPC83xx type boards (and MPC5121E) so building a kernel with this controller code in there, but without the controller present, should gladly fail. However removing the boards from the config does not fix this obvious error. I like your patch b

Re: crash in init_ipic_sysfs on efika

2008-03-19 Thread Olaf Hering
On Wed, Mar 19, Paul Mackerras wrote: > Olaf Hering writes: > > > I cant reproduce this bug on my board, but: > > > > The global primary_ipic in arch/powerpc/sysdev/ipic.c can remain NULL if > > ipic_init() fails. init_ipic_sysfs() will crash in that case. > > > > Something like this may fix it

Re: crash in init_ipic_sysfs on efika

2008-03-19 Thread Paul Mackerras
Olaf Hering writes: > I cant reproduce this bug on my board, but: > > The global primary_ipic in arch/powerpc/sysdev/ipic.c can remain NULL if > ipic_init() fails. init_ipic_sysfs() will crash in that case. > > Something like this may fix it: Is this needed for 2.6.25? Is the system at all usa

Re: crash in init_ipic_sysfs on efika

2008-03-19 Thread Olaf Hering
On Mon, Mar 17, Olaf Hering wrote: > The global primary_ipic in arch/powerpc/sysdev/ipic.c can remain NULL if > ipic_init() fails. init_ipic_sysfs() will crash in that case. > > Something like this may fix it: > > Index: linux-2.6.25-rc6/arch/powerpc/sysdev/ipic.c > =

crash in init_ipic_sysfs on efika

2008-03-17 Thread Olaf Hering
I cant reproduce this bug on my board, but: The global primary_ipic in arch/powerpc/sysdev/ipic.c can remain NULL if ipic_init() fails. init_ipic_sysfs() will crash in that case. Something like this may fix it: Index: linux-2.6.25-rc6/arch/powerpc/sysdev/ipic.c =