Re: checking status semantics with compatible functions

2011-04-05 Thread Benjamin Herrenschmidt
On Wed, 2011-03-30 at 08:31 -0600, Grant Likely wrote: > Yes, of_device_is_available() should be checked, but it should not be > added directly to of_device_is_compatible(). I'm okay with adding > a helper variant that does the of_device_is_compatible() check. > > In that particular case, I'd als

Re: checking status semantics with compatible functions

2011-03-30 Thread Grant Likely
On Wed, Mar 30, 2011 at 03:26:29AM -0500, Kumar Gala wrote: > [Adding proper lists on CC] > > - k > > On Mar 30, 2011, at 3:07 AM, Kumar Gala wrote: > > > Grant, > > > > We have a few helper functions like: > > > > drivers/of/base.c:EXPORT_SYMBOL(of_device_is_compatible); > > drivers/of/base.c

Re: checking status semantics with compatible functions

2011-03-30 Thread Kumar Gala
[Adding proper lists on CC] - k On Mar 30, 2011, at 3:07 AM, Kumar Gala wrote: > Grant, > > We have a few helper functions like: > > drivers/of/base.c:EXPORT_SYMBOL(of_device_is_compatible); > drivers/of/base.c:EXPORT_SYMBOL(of_find_compatible_node); > > That we use in places like arch/powerp