On Wed, 2017-10-18 at 14:18 +1100, Michael Ellerman wrote:
> Mimi Zohar writes:
> > On Tue, 2017-10-17 at 12:11 +0200, Julia Lawall wrote:
> >> On Tue, 17 Oct 2017, Dan Carpenter wrote:
> >> > On Tue, Oct 17, 2017 at 10:56:42AM +0200, Julia Lawall wrote:
> >> > > On Tue, 17 Oct 2017, Dan Carpenter
On Wed, 18 Oct 2017 02:18:46 -0700
Joe Perches wrote:
> On Wed, 2017-10-18 at 11:00 +0200, SF Markus Elfring wrote:
> > > The printk removals do change the objects.
> > >
> > > The value of that type of change is only for resource limited
> > > systems.
> >
> > I imagine that such small code
On Wed, Oct 18, 2017 at 09:09:48AM -0700, James Bottomley wrote:
> On Wed, 2017-10-18 at 18:10 +0300, Jarkko Sakkinen wrote:
> > On Tue, Oct 17, 2017 at 08:57:13AM -0700, James Bottomley wrote:
> > >
> > > On Tue, 2017-10-17 at 11:25 +0200, SF Markus Elfring wrote:
> > > >
> > > > >
> > > > >
>
On Wed, 2017-10-18 at 18:10 +0300, Jarkko Sakkinen wrote:
> On Tue, Oct 17, 2017 at 08:57:13AM -0700, James Bottomley wrote:
> >
> > On Tue, 2017-10-17 at 11:25 +0200, SF Markus Elfring wrote:
> > >
> > > >
> > > >
> > > > Fixes is only for bug fixes. These don't fix any bugs.
> > >
> > > How
>>> A minor complaint: all commits are missing "Fixes:" tag.
>>
>> * Do you require it to be added to the commit messages?
>
> I don't require it. It's part of the development process:
>
> https://www.kernel.org/doc/html/v4.12/process/submitting-patches.html
Yes. - But other contributors pointed
On Tue, Oct 17, 2017 at 08:57:13AM -0700, James Bottomley wrote:
> On Tue, 2017-10-17 at 11:25 +0200, SF Markus Elfring wrote:
> > >
> > > Fixes is only for bug fixes. These don't fix any bugs.
> >
> > How do you distinguish these in questionable source code
> > from other error categories or so
On Tue, Oct 17, 2017 at 12:44:34PM +0300, Dan Carpenter wrote:
> On Tue, Oct 17, 2017 at 10:56:42AM +0200, Julia Lawall wrote:
> >
> >
> > On Tue, 17 Oct 2017, Dan Carpenter wrote:
> >
> > > On Mon, Oct 16, 2017 at 09:35:12PM +0300, Jarkko Sakkinen wrote:
> > > >
> > > > A minor complaint: all c
On Mon, Oct 16, 2017 at 10:44:18PM +0200, SF Markus Elfring wrote:
> > A minor complaint: all commits are missing "Fixes:" tag.
>
> * Do you require it to be added to the commit messages?
I don't require it. It's part of the development process:
https://www.kernel.org/doc/html/v4.12/process/subm
> On Wed, 2017-10-18 at 10:44 +, alexander.stef...@infineon.com wrote:
> > > For instance, nothing about
> > > > > sizeof(type)
> > > > > vs
> > > > > sizeof(*ptr)
> > > > > makes it easier for a human to read the code.
> > > >
> > > > If it does not make it easier to read the code
On Wed, 2017-10-18 at 10:44 +, alexander.stef...@infineon.com wrote:
> > For instance, nothing about
> > > > sizeof(type)
> > > > vs
> > > > sizeof(*ptr)
> > > > makes it easier for a human to read the code.
> > >
> > > If it does not make it easier to read the code for you, th
> On Wed, 18 Oct 2017, alexander.stef...@infineon.com wrote:
>
> > > On Wed, 2017-10-18 at 11:00 +0200, SF Markus Elfring wrote:
> > > > > The printk removals do change the objects.
> > > > >
> > > > > The value of that type of change is only for resource limited systems.
> > > >
> > > > I imagine
On Wed, 2017-10-18 at 12:00 +0200, Julia Lawall wrote:
>
> On Wed, 18 Oct 2017, alexander.stef...@infineon.com wrote:
>
> > > On Wed, 2017-10-18 at 11:00 +0200, SF Markus Elfring wrote:
> > > > > The printk removals do change the objects.
> > > > >
> > > > > The value of that type of change is o
On Wed, 18 Oct 2017, alexander.stef...@infineon.com wrote:
> > On Wed, 2017-10-18 at 11:00 +0200, SF Markus Elfring wrote:
> > > > The printk removals do change the objects.
> > > >
> > > > The value of that type of change is only for resource limited systems.
> > >
> > > I imagine that such sma
>> I imagine that such small code adjustments are also useful for other systems.
>
> Your imagination and mine differ.
This can generally be.
> Where do you _think_ it matters?
It seems that this discussion branch referred still to my cover letter
for possible changes in the TPM software area.
> On Wed, 2017-10-18 at 11:00 +0200, SF Markus Elfring wrote:
> > > The printk removals do change the objects.
> > >
> > > The value of that type of change is only for resource limited systems.
> >
> > I imagine that such small code adjustments are also useful for other
> systems.
>
> Your imagina
On Wed, 2017-10-18 at 11:00 +0200, SF Markus Elfring wrote:
> > The printk removals do change the objects.
> >
> > The value of that type of change is only for resource limited systems.
>
> I imagine that such small code adjustments are also useful for other systems.
Your imagination and mine di
> The printk removals do change the objects.
>
> The value of that type of change is only for resource limited systems.
I imagine that such small code adjustments are also useful for other systems.
> Markus' changelogs leave much to be desired.
Would you like to help more to improve the provid
Mimi Zohar writes:
> On Tue, 2017-10-17 at 12:11 +0200, Julia Lawall wrote:
>> On Tue, 17 Oct 2017, Dan Carpenter wrote:
>> > On Tue, Oct 17, 2017 at 10:56:42AM +0200, Julia Lawall wrote:
>> > > On Tue, 17 Oct 2017, Dan Carpenter wrote:
>> > > > On Mon, Oct 16, 2017 at 09:35:12PM +0300, Jarkko Sak
On Tue, 2017-10-17 at 08:57 -0700, James Bottomley wrote:
> On Tue, 2017-10-17 at 11:25 +0200, SF Markus Elfring wrote:
> > >
> > > Fixes is only for bug fixes. These don't fix any bugs.
> >
> > How do you distinguish these in questionable source code
> > from other error categories or software
>>> Fixes is only for bug fixes. These don't fix any bugs.
>>
>> How do you distinguish these in questionable source code
>> from other error categories or software weaknesses?
>
> A style change is one that doesn't change the effect of the execution.
This can occasionally be fine, can't it?
>
On Tue, 2017-10-17 at 11:25 +0200, SF Markus Elfring wrote:
> >
> > Fixes is only for bug fixes. These don't fix any bugs.
>
> How do you distinguish these in questionable source code
> from other error categories or software weaknesses?
A style change is one that doesn't change the effect of t
Dan Carpenter writes:
> On Tue, Oct 17, 2017 at 10:56:42AM +0200, Julia Lawall wrote:
>>
>>
>> On Tue, 17 Oct 2017, Dan Carpenter wrote:
>>
>> > On Mon, Oct 16, 2017 at 09:35:12PM +0300, Jarkko Sakkinen wrote:
>> > >
>> > > A minor complaint: all commits are missing "Fixes:" tag.
>> > >
>> >
>
Hi Julia,
On Tue, 2017-10-17 at 12:11 +0200, Julia Lawall wrote:
>
> On Tue, 17 Oct 2017, Dan Carpenter wrote:
>
> > On Tue, Oct 17, 2017 at 10:56:42AM +0200, Julia Lawall wrote:
> > >
> > >
> > > On Tue, 17 Oct 2017, Dan Carpenter wrote:
> > >
> > > > On Mon, Oct 16, 2017 at 09:35:12PM +0300, J
On Tue, 17 Oct 2017, Dan Carpenter wrote:
> On Tue, Oct 17, 2017 at 10:56:42AM +0200, Julia Lawall wrote:
> >
> >
> > On Tue, 17 Oct 2017, Dan Carpenter wrote:
> >
> > > On Mon, Oct 16, 2017 at 09:35:12PM +0300, Jarkko Sakkinen wrote:
> > > >
> > > > A minor complaint: all commits are missing "F
On Tue, Oct 17, 2017 at 10:56:42AM +0200, Julia Lawall wrote:
>
>
> On Tue, 17 Oct 2017, Dan Carpenter wrote:
>
> > On Mon, Oct 16, 2017 at 09:35:12PM +0300, Jarkko Sakkinen wrote:
> > >
> > > A minor complaint: all commits are missing "Fixes:" tag.
> > >
> >
> > Fixes is only for bug fixes. Th
> Fixes is only for bug fixes. These don't fix any bugs.
How do you distinguish these in questionable source code
from other error categories or software weaknesses?
Regards,
Markus
On Tue, 17 Oct 2017, Dan Carpenter wrote:
> On Mon, Oct 16, 2017 at 09:35:12PM +0300, Jarkko Sakkinen wrote:
> >
> > A minor complaint: all commits are missing "Fixes:" tag.
> >
>
> Fixes is only for bug fixes. These don't fix any bugs.
0-day seems to put Fixes for everything. Should they be
On Mon, Oct 16, 2017 at 09:35:12PM +0300, Jarkko Sakkinen wrote:
>
> A minor complaint: all commits are missing "Fixes:" tag.
>
Fixes is only for bug fixes. These don't fix any bugs.
regards,
dan carpenter
>> A minor complaint: all commits are missing "Fixes:" tag.
>
> None of these patches fix anything.
It depends on the view which you prefer.
> All are trivial changes without much of any impact.
I find that they improve the affected software another bit.
Other adjustments can be more noticeabl
On Mon, 2017-10-16 at 21:35 +0300, Jarkko Sakkinen wrote:
> A minor complaint: all commits are missing "Fixes:" tag.
None of these patches fix anything.
All are trivial changes without much of any impact.
> A minor complaint: all commits are missing "Fixes:" tag.
* Do you require it to be added to the commit messages?
* Would you like to get a finer patch granularity then?
* Do you find any more information missing?
Regards,
Markus
On Mon, Oct 16, 2017 at 09:31:39PM +0300, Jarkko Sakkinen wrote:
> On Mon, Oct 16, 2017 at 07:30:13PM +0200, SF Markus Elfring wrote:
> > From: Markus Elfring
> > Date: Mon, 16 Oct 2017 19:12:34 +0200
> >
> > A few update suggestions were taken into account
> > from static source code analysis.
>
On Mon, Oct 16, 2017 at 07:30:13PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Mon, 16 Oct 2017 19:12:34 +0200
>
> A few update suggestions were taken into account
> from static source code analysis.
>
> Markus Elfring (4):
> Delete an error message for a failed memory alloc
From: Markus Elfring
Date: Mon, 16 Oct 2017 19:12:34 +0200
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (4):
Delete an error message for a failed memory allocation
in tpm_ascii_bios_measurements_show()
Delete an error message for a fai
34 matches
Mail list logo
