Re: WARN_ON() is buggy for 32 bit systems

2022-01-27 Thread Dan Carpenter
On Thu, Jan 27, 2022 at 10:10:32PM +1100, Michael Ellerman wrote: > Dan Carpenter writes: > > On Wed, Jan 26, 2022 at 12:21:49PM +, Christophe Leroy wrote: > >> The code is enclosed in a #ifdef CONFIG_PPC64, it is not used for PPC32: > >> > >> /arch/powerpc/include/asm/bug.h > >>99 #ifde

Re: WARN_ON() is buggy for 32 bit systems

2022-01-27 Thread Michael Ellerman
Dan Carpenter writes: > On Wed, Jan 26, 2022 at 12:21:49PM +, Christophe Leroy wrote: >> The code is enclosed in a #ifdef CONFIG_PPC64, it is not used for PPC32: >> >> /arch/powerpc/include/asm/bug.h >>99 #ifdef CONFIG_PPC64 > > Ah... > > You know, life would be a lot easier for me perso

Re: WARN_ON() is buggy for 32 bit systems

2022-01-26 Thread Dan Carpenter
On Wed, Jan 26, 2022 at 12:21:49PM +, Christophe Leroy wrote: > The code is enclosed in a #ifdef CONFIG_PPC64, it is not used for PPC32: > > /arch/powerpc/include/asm/bug.h >99 #ifdef CONFIG_PPC64 Ah... You know, life would be a lot easier for me personally if we added an #ifndef __CHEC

WARN_ON() is buggy for 32 bit systems

2022-01-26 Thread Dan Carpenter
Hi Michael, Commit e432fe97f3e5 ("powerpc/bug: Cast to unsigned long before passing to inline asm") breaks WARN_ON() for 32 bit systems. arch/powerpc/include/asm/bug.h 109 #define WARN_ON(x) ({ \ 110 bool __ret_warn_on = false;

Re: WARN_ON() is buggy for 32 bit systems

2022-01-26 Thread Christophe Leroy
Hi Dan, Le 26/01/2022 à 12:56, Dan Carpenter a écrit : > > Hi Michael, > > Commit e432fe97f3e5 ("powerpc/bug: Cast to unsigned long before passing > to inline asm") breaks WARN_ON() for 32 bit systems. I think you missed commit db87a7199229 ("powerpc/bug: Remove specific powerpc BUG_ON() and W