Re: Virtio_console usage of early printk

2010-03-23 Thread François Diakhate
On Tue, Mar 23, 2010 at 9:55 AM, Amit Shah wrote: > On (Mon) Mar 22 2010 [18:45:47], François Diakhate wrote: >> Hi all, >> >> As far as I can see, early_put_chars is not used by virtio_console >> because it checks whether there is a port available before using it. >> If I understand correctly, th

Re: Virtio_console usage of early printk

2010-03-23 Thread Amit Shah
On (Mon) Mar 22 2010 [18:45:47], François Diakhate wrote: > Hi all, > > As far as I can see, early_put_chars is not used by virtio_console > because it checks whether there is a port available before using it. > If I understand correctly, this makes it useless because once we have > a port, we can

Re: Virtio_console usage of early printk

2010-03-23 Thread Christian Borntraeger
Am Dienstag 23 März 2010 03:16:20 schrieb Amit Shah: > On (Mon) Mar 22 2010 [18:45:47], François Diakhate wrote: > > the console. Does the attached patch seem valid ? Feedback from s390 > > and powerpc users who use this functionality would be appreciated. > > Looks OK to me, Christian, others, co

Re: Virtio_console usage of early printk

2010-03-23 Thread Alexander Graf
On 22.03.2010, at 18:45, François Diakhate wrote: > Hi all, > > As far as I can see, early_put_chars is not used by virtio_console > because it checks whether there is a port available before using it. > If I understand correctly, this makes it useless because once we have > a port, we can use t

Re: Virtio_console usage of early printk

2010-03-22 Thread Amit Shah
On (Mon) Mar 22 2010 [18:45:47], François Diakhate wrote: > Hi all, > > As far as I can see, early_put_chars is not used by virtio_console > because it checks whether there is a port available before using it. > If I understand correctly, this makes it useless because once we have > a port, we can

Virtio_console usage of early printk

2010-03-22 Thread François Diakhate
Hi all, As far as I can see, early_put_chars is not used by virtio_console because it checks whether there is a port available before using it. If I understand correctly, this makes it useless because once we have a port, we can use the regular virtio transport to output things to the console. Doe