Re: selftests/powerpc: Remove -flto from common CFLAGS

2016-03-03 Thread Michael Ellerman
On Mon, 2016-29-02 at 06:29:55 UTC, Suraj Jitindar Singh wrote: > LTO can cause GCC to inline some functions which have attributes set. The > act of inlining the functions can lead to GCC forgetting about the > attributes which leads to incorrect tests. > Notable example being: __attribute__((__tar

Re: selftests/powerpc: Remove -flto from common CFLAGS

2016-02-29 Thread Suraj Jitindar Singh
On 01/03/16 14:11, Cyril Bur wrote: > On Mon, 29 Feb 2016 22:10:13 +1100 (AEDT) > Michael Ellerman wrote: > >> Hi Suraj, >> >> On Mon, 2016-29-02 at 06:29:55 UTC, Suraj Jitindar Singh wrote: >>> LTO can cause GCC to inline some functions which have attributes set. The >> You should define what L

Re: selftests/powerpc: Remove -flto from common CFLAGS

2016-02-29 Thread Cyril Bur
On Mon, 29 Feb 2016 22:10:13 +1100 (AEDT) Michael Ellerman wrote: > Hi Suraj, > > On Mon, 2016-29-02 at 06:29:55 UTC, Suraj Jitindar Singh wrote: > > LTO can cause GCC to inline some functions which have attributes set. The > > You should define what LTO is the first time you use it. > > > a

Re: selftests/powerpc: Remove -flto from common CFLAGS

2016-02-29 Thread Michael Ellerman
On Tue, 2016-03-01 at 10:08 +1100, Cyril Bur wrote: > On Mon, 29 Feb 2016 22:10:13 +1100 (AEDT) > Michael Ellerman wrote: > > On Mon, 2016-29-02 at 06:29:55 UTC, Suraj Jitindar Singh wrote: > > > Both these cases are hard to detect and require manual inspection of > > > binaries which is unlikely

Re: selftests/powerpc: Remove -flto from common CFLAGS

2016-02-29 Thread Cyril Bur
On Mon, 29 Feb 2016 22:10:13 +1100 (AEDT) Michael Ellerman wrote: > Hi Suraj, > > On Mon, 2016-29-02 at 06:29:55 UTC, Suraj Jitindar Singh wrote: > > LTO can cause GCC to inline some functions which have attributes set. The > > You should define what LTO is the first time you use it. > > > a

Re: selftests/powerpc: Remove -flto from common CFLAGS

2016-02-29 Thread Michael Ellerman
Hi Suraj, On Mon, 2016-29-02 at 06:29:55 UTC, Suraj Jitindar Singh wrote: > LTO can cause GCC to inline some functions which have attributes set. The You should define what LTO is the first time you use it. > act of inlining the functions can lead to GCC forgetting about the > attributes which l