Re: oprofile callgraph support missing for common cpus

2011-12-05 Thread Benjamin Herrenschmidt
On Mon, 2011-12-05 at 09:50 +0100, Joakim Tjernlund wrote: > Benjamin Herrenschmidt wrote on 2011/11/25 > 06:24:32: > > > > On Fri, 2011-11-18 at 09:22 +0100, Joakim Tjernlund wrote: > > > > > I forgot to ask, oprofile mentions setting -no-omit-framepointer to get > > > correct backtrace but I ca

Re: oprofile callgraph support missing for common cpus

2011-12-05 Thread Joakim Tjernlund
Benjamin Herrenschmidt wrote on 2011/11/25 06:24:32: > > On Fri, 2011-11-18 at 09:22 +0100, Joakim Tjernlund wrote: > > > I forgot to ask, oprofile mentions setting -no-omit-framepointer to get > > correct backtrace but I cannot turn on frame pointers for the ppc kernel. > > Isn't frame pointers n

Re: oprofile callgraph support missing for common cpus

2011-11-25 Thread Juntang Fu(David)
On 11/25/2011 01:24 PM, Benjamin Herrenschmidt wrote: > On Fri, 2011-11-18 at 09:22 +0100, Joakim Tjernlund wrote: > >> I forgot to ask, oprofile mentions setting -no-omit-framepointer to get >> correct backtrace but I cannot turn on frame pointers for the ppc kernel. >> Isn't frame pointers need

Re: oprofile callgraph support missing for common cpus

2011-11-24 Thread Benjamin Herrenschmidt
On Fri, 2011-11-18 at 09:22 +0100, Joakim Tjernlund wrote: > I forgot to ask, oprofile mentions setting -no-omit-framepointer to get > correct backtrace but I cannot turn on frame pointers for the ppc kernel. > Isn't frame pointers needed for pcc? what about user space? PowerPC always has frame p

Re: oprofile callgraph support missing for common cpus

2011-11-18 Thread Joakim Tjernlund
Robert Richter wrote on 2011/11/18 00:20:27: > > On 17.11.11 22:27:46, Joakim Tjernlund wrote: > > > >> For my e300c2 cpu both if's are false and I don't get support for > > > >> callgraph/backtrace > > > >> support. Moving the ops->backtrace = op_powerpc_backtrace; to the top > > > >> enables ba

Re: oprofile callgraph support missing for common cpus

2011-11-18 Thread Joakim Tjernlund
Robert Richter wrote on 2011/11/18 00:20:27: > > On 17.11.11 22:27:46, Joakim Tjernlund wrote: > > > >> For my e300c2 cpu both if's are false and I don't get support for > > > >> callgraph/backtrace > > > >> support. Moving the ops->backtrace = op_powerpc_backtrace; to the top > > > >> enables ba

Re: oprofile callgraph support missing for common cpus

2011-11-17 Thread Robert Richter
On 17.11.11 22:27:46, Joakim Tjernlund wrote: > > >> For my e300c2 cpu both if's are false and I don't get support for > > >> callgraph/backtrace > > >> support. Moving the ops->backtrace = op_powerpc_backtrace; to the top > > >> enables backtrace for me. > It sure seems to work :) Backtrace sup

Re: oprofile callgraph support missing for common cpus

2011-11-17 Thread Joakim Tjernlund
Andy Fleming wrote on 2011/11/17 18:51:52: > > > On Nov 17, 2011, at 11:30 AM, Maynard Johnson wrote: > > >> > >> Notice the first > >>if (!cur_cpu_spec->oprofile_cpu_type) > >> return -ENODEV; > >> > >>if (firmware_has_feature(FW_FEATURE_ISERIES)) > >>

Re: oprofile callgraph support missing for common cpus

2011-11-17 Thread Maynard Johnson
On 11/17/2011 2:38 AM, Joakim Tjernlund wrote: arch/powerpc/oprofile/common.c has this init code: int __init oprofile_arch_init(struct oprofile_operations *ops) { if (!cur_cpu_spec->oprofile_cpu_type) return -ENODEV; if (firmwa

Re: oprofile callgraph support missing for common cpus

2011-11-17 Thread Andy Fleming
On Nov 17, 2011, at 11:30 AM, Maynard Johnson wrote: >> >> Notice the first >> if (!cur_cpu_spec->oprofile_cpu_type) >> return -ENODEV; >> >> if (firmware_has_feature(FW_FEATURE_ISERIES)) >> return -ENODEV;