Re: bug in drivers/edac/mpc85xx_edac.c:mpc85xx_mc_check()

2009-04-29 Thread Kumar Gala
On Apr 29, 2009, at 2:37 AM, Andrew Morton wrote: Let's cc the suitable people. On Tue, 28 Apr 2009 18:23:42 -0700 "Jeff Haran" wrote: Hi, Recent versions of this function contain the following snippets: if (err_detect & DDR_EDE_SBE) edac_mc_handle_ce(mci, pfn, err_addr & PAG

Re: bug in drivers/edac/mpc85xx_edac.c:mpc85xx_mc_check()

2009-04-29 Thread Andrew Morton
Let's cc the suitable people. On Tue, 28 Apr 2009 18:23:42 -0700 "Jeff Haran" wrote: > Hi, > > Recent versions of this function contain the following snippets: > > if (err_detect & DDR_EDE_SBE) > edac_mc_handle_ce(mci, pfn, err_addr & PAGE_MASK, > syndrome, row_in

Re: bug in drivers/edac/mpc85xx_edac.c:mpc85xx_mc_check() ?

2009-04-13 Thread Dave Jiang
Jeff, you are correct. I will submit a patch to correct that. Andrew Morton wrote: (cc's added) On Wed, 8 Apr 2009 14:57:42 -0700 "Jeff Haran" wrote: Hi, Recent versions of this function start off with: static void mpc85xx_mc_check(struct mem_ctl_info *mci) { struct mpc85xx_mc_pdata *p

Re: bug in drivers/edac/mpc85xx_edac.c:mpc85xx_mc_check() ?

2009-04-10 Thread Andrew Morton
(cc's added) On Wed, 8 Apr 2009 14:57:42 -0700 "Jeff Haran" wrote: > Hi, > > Recent versions of this function start off with: > > static void mpc85xx_mc_check(struct mem_ctl_info *mci) > { > struct mpc85xx_mc_pdata *pdata = mci->pvt_info; > ... > > err_detect = in_be32(pdata->mc_v