Re: asm-ppc header issues when building ARCH=powerpc

2007-08-24 Thread Geert Uytterhoeven
On Fri, 24 Aug 2007, Kumar Gala wrote: > On Aug 24, 2007, at 2:10 AM, Geert Uytterhoeven wrote: > > On Thu, 23 Aug 2007, Brad Boyer wrote: > > > Just as an extra note, the file drivers/macintosh/adb-iop.c is m68k only, > > > so you should probably leave that alone as well. It probably doesn't need

Re: asm-ppc header issues when building ARCH=powerpc

2007-08-24 Thread Kumar Gala
On Aug 24, 2007, at 2:10 AM, Geert Uytterhoeven wrote: > On Thu, 23 Aug 2007, Brad Boyer wrote: >> Just as an extra note, the file drivers/macintosh/adb-iop.c is >> m68k only, >> so you should probably leave that alone as well. It probably >> doesn't need >> that header, but the change should

Re: asm-ppc header issues when building ARCH=powerpc

2007-08-24 Thread Geert Uytterhoeven
On Thu, 23 Aug 2007, Brad Boyer wrote: > Just as an extra note, the file drivers/macintosh/adb-iop.c is m68k only, > so you should probably leave that alone as well. It probably doesn't need > that header, but the change should really come from the 68k side of things. Thanks, it's indeed not neede

Re: asm-ppc header issues when building ARCH=powerpc

2007-08-23 Thread Brad Boyer
On Wed, Aug 22, 2007 at 11:16:03PM -0500, Kumar Gala wrote: > On Aug 22, 2007, at 10:33 PM, David Gibson wrote: > >> My analysis of usage: > >> > >> ./drivers/macintosh/adb-iop.c:#include remove > >> ./drivers/char/vme_scc.c:#include 68k only > >> ./drivers/char/serial167.c:#include

Re: asm-ppc header issues when building ARCH=powerpc

2007-08-23 Thread Kumar Gala
On Aug 23, 2007, at 12:33 PM, Scott Wood wrote: > On Thu, Aug 23, 2007 at 12:47:57PM +1000, David Gibson wrote: >>> ./drivers/mtd/maps/tqm834x.c:#include >>> ./drivers/mtd/maps/pq2fads.c:#include >> >> Although these both have an extern of type bd_t (defined in >> ppcboot.h), afaict they don't

Re: asm-ppc header issues when building ARCH=powerpc

2007-08-23 Thread Scott Wood
On Thu, Aug 23, 2007 at 12:47:57PM +1000, David Gibson wrote: > > ./drivers/mtd/maps/tqm834x.c:#include > > ./drivers/mtd/maps/pq2fads.c:#include > > Although these both have an extern of type bd_t (defined in > ppcboot.h), afaict they don't actually use it, so these should be > removable. They

Re: asm-ppc header issues when building ARCH=powerpc

2007-08-23 Thread Geert Uytterhoeven
On Wed, 22 Aug 2007, Kumar Gala wrote: > On Aug 22, 2007, at 10:33 PM, David Gibson wrote: > > On Wed, Aug 22, 2007 at 10:33:55PM -0500, Kumar Gala wrote: > >> On Aug 22, 2007, at 10:19 AM, Kumar Gala wrote: > >>> I was wondering if I could get your help with looking at the > >>> following lists an

Re: asm-ppc header issues when building ARCH=powerpc

2007-08-22 Thread Kumar Gala
On Aug 22, 2007, at 10:33 PM, David Gibson wrote: > On Wed, Aug 22, 2007 at 10:33:55PM -0500, Kumar Gala wrote: >> >> On Aug 22, 2007, at 10:19 AM, Kumar Gala wrote: >> >>> Guys, >>> >>> I was wondering if I could get your help with looking at the >>> following lists and determining if we have an

Re: asm-ppc header issues when building ARCH=powerpc

2007-08-22 Thread David Gibson
On Wed, Aug 22, 2007 at 10:33:55PM -0500, Kumar Gala wrote: > > On Aug 22, 2007, at 10:19 AM, Kumar Gala wrote: > > >Guys, > > > >I was wondering if I could get your help with looking at the > >following lists and determining if we have an issue or not related > >the following files: > > > >Getti

Re: asm-ppc header issues when building ARCH=powerpc

2007-08-22 Thread Kumar Gala
On Aug 22, 2007, at 10:19 AM, Kumar Gala wrote: > Guys, > > I was wondering if I could get your help with looking at the > following lists and determining if we have an issue or not related > the following files: > > Getting some classification on these would be good. Possibly > classifications,

Re: asm-ppc header issues when building ARCH=powerpc

2007-08-22 Thread Kumar Gala
On Aug 22, 2007, at 9:47 PM, David Gibson wrote: > On Wed, Aug 22, 2007 at 10:19:21AM -0500, Kumar Gala wrote: >> Guys, >> >> I was wondering if I could get your help with looking at the >> following lists and determining if we have an issue or not related >> the following files: >> >> Getting so

Re: asm-ppc header issues when building ARCH=powerpc

2007-08-22 Thread Kumar Gala
On Aug 22, 2007, at 9:49 PM, David Gibson wrote: > On Wed, Aug 22, 2007 at 02:30:47PM -0500, Josh Boyer wrote: >> On Wed, 22 Aug 2007 10:19:21 -0500 >> Kumar Gala <[EMAIL PROTECTED]> wrote: >> >>> Guys, >>> >>> I was wondering if I could get your help with looking at the >>> following lists and d

Re: asm-ppc header issues when building ARCH=powerpc

2007-08-22 Thread David Gibson
On Wed, Aug 22, 2007 at 02:30:47PM -0500, Josh Boyer wrote: > On Wed, 22 Aug 2007 10:19:21 -0500 > Kumar Gala <[EMAIL PROTECTED]> wrote: > > > Guys, > > > > I was wondering if I could get your help with looking at the > > following lists and determining if we have an issue or not related > >

Re: asm-ppc header issues when building ARCH=powerpc

2007-08-22 Thread David Gibson
On Wed, Aug 22, 2007 at 10:19:21AM -0500, Kumar Gala wrote: > Guys, > > I was wondering if I could get your help with looking at the > following lists and determining if we have an issue or not related > the following files: > > Getting some classification on these would be good. Possibly

Re: asm-ppc header issues when building ARCH=powerpc

2007-08-22 Thread Josh Boyer
On Wed, 22 Aug 2007 10:19:21 -0500 Kumar Gala <[EMAIL PROTECTED]> wrote: > Guys, > > I was wondering if I could get your help with looking at the > following lists and determining if we have an issue or not related > the following files: > > Getting some classification on these would be good

Re: asm-ppc header issues when building ARCH=powerpc

2007-08-22 Thread Scott Wood
On Wed, Aug 22, 2007 at 10:19:21AM -0500, Kumar Gala wrote: > ./drivers/mtd/maps/tqm834x.c:#include > ./drivers/mtd/maps/pq2fads.c:#include These use the bd_t, and thus will only work on arch/ppc. On arch/powerpc, we can use the device tree to specify the mapping. -Scott __