Re: add phy-handle property for fec_mpc52xx

2008-01-10 Thread Olaf Hering
On Thu, Jan 10, Paul Mackerras wrote: > Olaf Hering writes: > > > --- a/arch/powerpc/kernel/prom_init.c > > +++ b/arch/powerpc/kernel/prom_init.c > > @@ -1487,6 +1487,34 @@ static void __init prom_find_mmu(void) > > else if (strncmp(version, "FirmWorks,3.", 12) == 0) { > > of_work

Re: add phy-handle property for fec_mpc52xx

2008-01-10 Thread David Woodhouse
On Thu, 2008-01-10 at 13:21 +1100, Paul Mackerras wrote: > David Woodhouse writes: > > > It would be much better if the kernel would 'just work'. The ideal way > > of achieving that is for the firmware to be fixed -- but that's been > > promised for a long time now, and we just don't believe you

Re: add phy-handle property for fec_mpc52xx

2008-01-09 Thread Benjamin Herrenschmidt
On Thu, 2008-01-10 at 13:21 +1100, Paul Mackerras wrote: > David Woodhouse writes: > > > It would be much better if the kernel would 'just work'. The ideal way > > of achieving that is for the firmware to be fixed -- but that's been > > promised for a long time now, and we just don't believe you

Re: add phy-handle property for fec_mpc52xx

2008-01-09 Thread Paul Mackerras
David Woodhouse writes: > It would be much better if the kernel would 'just work'. The ideal way > of achieving that is for the firmware to be fixed -- but that's been > promised for a long time now, and we just don't believe you any more. So > working round it in the kernel seems to be the next b

Re: add phy-handle property for fec_mpc52xx

2008-01-09 Thread Paul Mackerras
Olaf Hering writes: > --- a/arch/powerpc/kernel/prom_init.c > +++ b/arch/powerpc/kernel/prom_init.c > @@ -1487,6 +1487,34 @@ static void __init prom_find_mmu(void) > else if (strncmp(version, "FirmWorks,3.", 12) == 0) { > of_workarounds = OF_WA_CLAIM | OF_WA_LONGTRAIL; >

Re: add phy-handle property for fec_mpc52xx

2008-01-09 Thread Sven Luther
On Wed, Jan 09, 2008 at 05:17:52PM +, Matt Sealey wrote: > > Sven Luther wrote: > >On Wed, Jan 09, 2008 at 04:36:19PM +, Matt Sealey wrote: > >>The link that Olaf presented, www.powerdeveloper.org/asset/by-id/46 *is* > >>the upstream support for now. What his patch does is say, the upstrea

Re: add phy-handle property for fec_mpc52xx

2008-01-09 Thread Matt Sealey
Sven Luther wrote: > On Wed, Jan 09, 2008 at 04:36:19PM +, Matt Sealey wrote: >> The link that Olaf presented, www.powerdeveloper.org/asset/by-id/46 *is* >> the upstream support for now. What his patch does is say, the upstream >> support exists, but we don't like it, so we will supplement the

Re: add phy-handle property for fec_mpc52xx

2008-01-09 Thread Sven Luther
On Wed, Jan 09, 2008 at 04:36:19PM +, Matt Sealey wrote: > > Sven Luther wrote: > >On Wed, Jan 09, 2008 at 04:30:13PM +, Matt Sealey wrote: > >>Sven Luther wrote: > >>>Let's just fix this in the kernel, until we get a fixed efika firmware, > >>>then we can drop it easily enough. But until

Re: add phy-handle property for fec_mpc52xx

2008-01-09 Thread Matt Sealey
David Woodhouse wrote: > On Wed, 2008-01-09 at 15:26 +, Matt Sealey wrote: >> If anyone wants to help/assist/suggest any updates to efika.forth, >> create binary tools which assist the installation of the script for >> users and for placement on Linux distro CDs etc. I would be very >> grateful

Re: add phy-handle property for fec_mpc52xx

2008-01-09 Thread Grant Likely
On 1/9/08, Matt Sealey <[EMAIL PROTECTED]> wrote: > > However, I'm still inclined to pick up Olaf's patch with the > > appropriate protections around it so it is only done if the nodes are > > missing. > > Eh.. yeah. Maybe. Seems like a cop-out to me. I would rather you removed > the patch and call

Re: add phy-handle property for fec_mpc52xx

2008-01-09 Thread Matt Sealey
Sven Luther wrote: > On Wed, Jan 09, 2008 at 04:30:13PM +, Matt Sealey wrote: >> Sven Luther wrote: >>> Let's just fix this in the kernel, until we get a fixed efika firmware, >>> then we can drop it easily enough. But until this happens, we need to be >>> able to boot the kernel without any e

Re: add phy-handle property for fec_mpc52xx

2008-01-09 Thread Matt Sealey
Grant Likely wrote: > On 1/9/08, Matt Sealey <[EMAIL PROTECTED]> wrote: >> Please let's keep the nature of our firmware and the Linux codebase >> independant, and move the burden of support to Genesi, and not the >> Linux PowerPC team. After all, what is next, after phy-handle do >> you want to ad

Re: add phy-handle property for fec_mpc52xx

2008-01-09 Thread Sven Luther
On Wed, Jan 09, 2008 at 04:30:13PM +, Matt Sealey wrote: > > Sven Luther wrote: > > > >Let's just fix this in the kernel, until we get a fixed efika firmware, > >then we can drop it easily enough. But until this happens, we need to be > >able to boot the kernel without any extra work on the us

Re: add phy-handle property for fec_mpc52xx

2008-01-09 Thread Matt Sealey
Sven Luther wrote: > > Let's just fix this in the kernel, until we get a fixed efika firmware, > then we can drop it easily enough. But until this happens, we need to be > able to boot the kernel without any extra work on the users part. That is exactly why I don't like the idea. Yes, it makes i

Re: add phy-handle property for fec_mpc52xx

2008-01-09 Thread Grant Likely
On 1/9/08, Olaf Hering <[EMAIL PROTECTED]> wrote: > > The new network driver fec_mpc52xx will not work on efika because the > firmware does not provide all required properties. > http://www.powerdeveloper.org/asset/by-id/46 has a Forth script to > create more properties. But only the phy stuff is r

Re: add phy-handle property for fec_mpc52xx

2008-01-09 Thread Olof Johansson
On Wed, Jan 09, 2008 at 03:26:04PM +, Matt Sealey wrote: > Clarification: I really have to disagree with this patch, and Sven. > > The whole point of removing the stuff from the Linux kernel (as the > efika.forth script and the associated patch performs) is that it means > the Linux kernel is

Re: add phy-handle property for fec_mpc52xx

2008-01-09 Thread David Woodhouse
On Wed, 2008-01-09 at 15:26 +, Matt Sealey wrote: > If anyone wants to help/assist/suggest any updates to efika.forth, > create binary tools which assist the installation of the script for > users and for placement on Linux distro CDs etc. I would be very > grateful, but it seems we have hit t

Re: add phy-handle property for fec_mpc52xx

2008-01-09 Thread Grant Likely
On 1/9/08, Matt Sealey <[EMAIL PROTECTED]> wrote: > Please let's keep the nature of our firmware and the Linux codebase > independant, and move the burden of support to Genesi, and not the > Linux PowerPC team. After all, what is next, after phy-handle do > you want to add i2c, irda, missing xlb/cd

Re: add phy-handle property for fec_mpc52xx

2008-01-09 Thread Sven Luther
On Wed, Jan 09, 2008 at 03:26:04PM +, Matt Sealey wrote: > Clarification: I really have to disagree with this patch, and Sven. > > The whole point of removing the stuff from the Linux kernel (as the > efika.forth script and the associated patch performs) is that it means > the Linux kernel is

Re: add phy-handle property for fec_mpc52xx

2008-01-09 Thread Matt Sealey
I'd also say that the sound driver isn't ready for production use and it misuses the BestComm task for generic bidirectional buffer copies by forcing it to 32-bit transfers (this obviously involves some software upsampling at some point as nearly all common sound data is 16-bit, also twice the band

Re: add phy-handle property for fec_mpc52xx

2008-01-09 Thread Matt Sealey
Clarification: I really have to disagree with this patch, and Sven. The whole point of removing the stuff from the Linux kernel (as the efika.forth script and the associated patch performs) is that it means the Linux kernel is no longer a "moving target" for our firmware development. If users req

Re: add phy-handle property for fec_mpc52xx

2008-01-09 Thread Sven Luther
On Wed, Jan 09, 2008 at 03:21:35PM +, Matt Sealey wrote: > NO. YES :) Friendly, Sven Luther ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: add phy-handle property for fec_mpc52xx

2008-01-09 Thread Grant Likely
On 1/9/08, Matt Sealey <[EMAIL PROTECTED]> wrote: > NO. please elaborate > > -- > Matt Sealey <[EMAIL PROTECTED]> > Genesi, Manager, Developer Relations > > Sven Luther wrote: > > On Wed, Jan 09, 2008 at 07:44:58AM -0700, Grant Likely wrote: > >> Woo! Thanks Olaf. I was just about to sit down a

Re: add phy-handle property for fec_mpc52xx

2008-01-09 Thread Matt Sealey
NO. -- Matt Sealey <[EMAIL PROTECTED]> Genesi, Manager, Developer Relations Sven Luther wrote: > On Wed, Jan 09, 2008 at 07:44:58AM -0700, Grant Likely wrote: >> Woo! Thanks Olaf. I was just about to sit down and write something >> like this myself. Looks good to me. I'll pick this up (but I

Re: add phy-handle property for fec_mpc52xx

2008-01-09 Thread Sven Luther
On Wed, Jan 09, 2008 at 07:44:58AM -0700, Grant Likely wrote: > Woo! Thanks Olaf. I was just about to sit down and write something > like this myself. Looks good to me. I'll pick this up (but I'm going > to move it to the fixup_device_tree_efika() function) Indeed, thanks, this makes the efika

Re: add phy-handle property for fec_mpc52xx

2008-01-09 Thread Grant Likely
On 1/9/08, Olaf Hering <[EMAIL PROTECTED]> wrote: > > The new network driver fec_mpc52xx will not work on efika because the > firmware does not provide all required properties. > http://www.powerdeveloper.org/asset/by-id/46 has a Forth script to > create more properties. But only the phy stuff is r

Re: add phy-handle property for fec_mpc52xx

2008-01-09 Thread Sven Luther
On Wed, Jan 09, 2008 at 07:50:14AM -0700, Grant Likely wrote: > On 1/9/08, Sven Luther <[EMAIL PROTECTED]> wrote: > > On Wed, Jan 09, 2008 at 07:44:58AM -0700, Grant Likely wrote: > > > Woo! Thanks Olaf. I was just about to sit down and write something > > > like this myself. Looks good to me.

Re: add phy-handle property for fec_mpc52xx

2008-01-09 Thread Grant Likely
On 1/9/08, Sven Luther <[EMAIL PROTECTED]> wrote: > On Wed, Jan 09, 2008 at 07:44:58AM -0700, Grant Likely wrote: > > Woo! Thanks Olaf. I was just about to sit down and write something > > like this myself. Looks good to me. I'll pick this up (but I'm going > > to move it to the fixup_device_tr

Re: add phy-handle property for fec_mpc52xx

2008-01-09 Thread Grant Likely
Woo! Thanks Olaf. I was just about to sit down and write something like this myself. Looks good to me. I'll pick this up (but I'm going to move it to the fixup_device_tree_efika() function) Cheers, g. On 1/9/08, Olaf Hering <[EMAIL PROTECTED]> wrote: > > The new network driver fec_mpc52xx wi