Re: Wrong looking statement in cpm_common.c

2009-05-26 Thread Scott Wood
Benjamin Herrenschmidt wrote: On Tue, 2009-05-26 at 17:15 -0500, Scott Wood wrote: Benjamin Herrenschmidt wrote: On Tue, 2009-05-26 at 12:56 -0500, Scott Wood wrote: Any suggestions for how to do it properly? ioremap ? :-) Does ioremap work that early? It works very early on ppc32 but mayb

Re: Wrong looking statement in cpm_common.c

2009-05-26 Thread Benjamin Herrenschmidt
On Tue, 2009-05-26 at 17:15 -0500, Scott Wood wrote: > Benjamin Herrenschmidt wrote: > > On Tue, 2009-05-26 at 12:56 -0500, Scott Wood wrote: > >> Any suggestions for how to do it properly? > > > > ioremap ? :-) > > Does ioremap work that early? It works very early on ppc32 but maybe not -that-

Re: Wrong looking statement in cpm_common.c

2009-05-26 Thread Scott Wood
Benjamin Herrenschmidt wrote: On Tue, 2009-05-26 at 12:56 -0500, Scott Wood wrote: Any suggestions for how to do it properly? ioremap ? :-) Does ioremap work that early? -Scott ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.o

Re: Wrong looking statement in cpm_common.c

2009-05-26 Thread Benjamin Herrenschmidt
On Tue, 2009-05-26 at 12:56 -0500, Scott Wood wrote: > > Any suggestions for how to do it properly? ioremap ? :-) Ben. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: Wrong looking statement in cpm_common.c

2009-05-26 Thread Scott Wood
On Mon, May 25, 2009 at 02:00:33PM +1000, Benjamin Herrenschmidt wrote: > Hi Scott ! > > There's this pearl in cpm_common.c : > > void __init udbg_init_cpm(void) > { > if (cpm_udbg_txdesc) { > #ifdef CONFIG_CPM2 > setbat(1, 0xf000, 0xf000, 1024*1024, PAGE_KERNEL_NCG);