FYI: The onboard SD card works also with the RC6 of kernel 5.4 with the
patch below.
-- Christian
On 23 October 2019 at 4:20pm, Christian Zigotzky wrote:
Hello,
The patch below works. I compiled the RC4 of kernel 5.4 with this patch today
and the onboard SD card works without any problems.
On Fri, 2019-10-25 at 23:39 -0700, Christoph Hellwig wrote:
> On Fri, Oct 25, 2019 at 05:28:45PM -0500, Rob Herring wrote:
> > This doesn't work?:
> >
> > if (IS_ENABLED(CONFIG_PPC) || of_dma_is_coherent(dev-
> > >of_node))
> > value |= ESDHC_DMA_SNOOP;
> > else
> >
On Fri, 2019-10-25 at 17:28 -0500, Rob Herring wrote:
> This doesn't work?:
>
> if (IS_ENABLED(CONFIG_PPC) || of_dma_is_coherent(dev-
> >of_node))
> value |= ESDHC_DMA_SNOOP;
> else
> value &= ~ESDHC_DMA_SNOOP;
CONFIG_PPC is restrictive. What about
On Fri, Oct 25, 2019 at 05:28:45PM -0500, Rob Herring wrote:
> This doesn't work?:
>
> if (IS_ENABLED(CONFIG_PPC) || of_dma_is_coherent(dev->of_node))
> value |= ESDHC_DMA_SNOOP;
> else
> value &= ~ESDHC_DMA_SNOOP;
>
> While I said use the compatibl
On Wed, Oct 23, 2019 at 9:32 AM Russell King - ARM Linux admin
wrote:
>
> On Wed, Oct 23, 2019 at 08:52:33AM -0500, Rob Herring wrote:
> > > I think this should have been done the other way around and default to
> > > coherent since most traditional OF platforms are coherent, and you
> > > can't j
On Wed, Oct 23, 2019 at 08:52:33AM -0500, Rob Herring wrote:
> > I think this should have been done the other way around and default to
> > coherent since most traditional OF platforms are coherent, and you
> > can't just require those DTs to change.
>
> You can blame me. This was really only inte
On Wed, Oct 23, 2019 at 08:52:33AM -0500, Rob Herring wrote:
> On Wed, Oct 23, 2019 at 1:41 AM Benjamin Herrenschmidt
> wrote:
> >
> > On Wed, 2019-10-23 at 16:42 +1100, Michael Ellerman wrote:
> > >
> > > Right, it seems of_dma_is_coherent() has baked in the assumption that
> > > devices are non-
Hello,
The patch below works. I compiled the RC4 of kernel 5.4 with this patch today
and the onboard SD card works without any problems.
Thanks!
Christian
> On 23. Oct 2019, at 07:42, Michael Ellerman wrote:
>
> Russell King - ARM Linux admin writes:
>>> On Tue, Oct 15, 2019 at 03:12:49PM +
On Wed, Oct 23, 2019 at 1:41 AM Benjamin Herrenschmidt
wrote:
>
> On Wed, 2019-10-23 at 16:42 +1100, Michael Ellerman wrote:
> >
> > Right, it seems of_dma_is_coherent() has baked in the assumption that
> > devices are non-coherent unless explicitly marked as coherent.
> >
> > Which is wrong on al
On Wed, 2019-10-23 at 16:42 +1100, Michael Ellerman wrote:
>
> Right, it seems of_dma_is_coherent() has baked in the assumption that
> devices are non-coherent unless explicitly marked as coherent.
>
> Which is wrong on all or at least most existing powerpc systems
> according to Ben.
This is pr
Russell King - ARM Linux admin writes:
> On Tue, Oct 15, 2019 at 03:12:49PM +0200, Christian Zigotzky wrote:
>> Hello Russell,
>>
>> You asked me about "dma-coherent" in the Cyrus device tree. Unfortunately I
>> don't find the property "dma-coherent" in the dtb source files.
>>
>> Output of "fdt
11 matches
Mail list logo
