Re: Fix Firmware class name collision

2007-12-15 Thread Kay Sievers
On Fri, 2007-12-14 at 22:39 -0800, Greg KH wrote: > On Sat, Dec 15, 2007 at 05:14:29PM +1100, Benjamin Herrenschmidt wrote: > > > > On Fri, 2007-12-14 at 14:40 -0800, Greg KH wrote: > > > On Tue, Dec 04, 2007 at 07:28:00PM -0600, Timur Tabi wrote: > > > > Scott Wood wrote: > > > > > > > >> The phy

Re: Fix Firmware class name collision

2007-12-14 Thread Greg KH
On Sat, Dec 15, 2007 at 05:14:29PM +1100, Benjamin Herrenschmidt wrote: > > On Fri, 2007-12-14 at 14:40 -0800, Greg KH wrote: > > On Tue, Dec 04, 2007 at 07:28:00PM -0600, Timur Tabi wrote: > > > Scott Wood wrote: > > > > > >> The physical address certainly is useful when you have more than one >

Re: Fix Firmware class name collision

2007-12-14 Thread Benjamin Herrenschmidt
On Fri, 2007-12-14 at 14:40 -0800, Greg KH wrote: > On Tue, Dec 04, 2007 at 07:28:00PM -0600, Timur Tabi wrote: > > Scott Wood wrote: > > > >> The physical address certainly is useful when you have more than one > >> device of the same name. > > > > What I meant was that the physical address isn'

Re: Fix Firmware class name collision

2007-12-14 Thread Timur Tabi
Greg KH wrote: > In the near future (2.6.26) there will not be a limit on the size of the > file name, so we should not have this problem anymore. In that case, I won't worry about it. I would have preferred 2.6.25, since I have code going into 2.6.25 that is affected by the current limit. --

Re: Fix Firmware class name collision

2007-12-14 Thread Greg KH
On Tue, Dec 04, 2007 at 07:28:00PM -0600, Timur Tabi wrote: > Scott Wood wrote: > >> The physical address certainly is useful when you have more than one >> device of the same name. > > What I meant was that the physical address isn't helpful by itself. > >> So then you'd get "firmware-ucc.e01024"

Re: Fix Firmware class name collision

2007-12-04 Thread Timur Tabi
Scott Wood wrote: > The physical address certainly is useful when you have more than one > device of the same name. What I meant was that the physical address isn't helpful by itself. > So then you'd get "firmware-ucc.e01024". What if there's another ucc at > e0102480? For devices with long

Re: Fix Firmware class name collision

2007-12-04 Thread Scott Wood
Timur Tabi wrote: > > In other words, the only thing you get is the first letter of the device > name. > You used to get the whole name. The physical address obviously isn't very > helpful. The physical address certainly is useful when you have more than one device of the same name. > Now,