Re: Device tree aware EMAC driver

2007-09-14 Thread Josh Boyer
On Thu, 2007-08-23 at 09:30 +0200, Benjamin Herrenschmidt wrote: > On Thu, 2007-08-23 at 13:56 +1000, David Gibson wrote: > > > > > > Jeff, I've discussed this with BenH, and although there are some > > problems with the driver still, we think it's good enough to merge in > > 2.6.24, the warts ca

Re: Device tree aware EMAC driver

2007-08-23 Thread Benjamin Herrenschmidt
On Thu, 2007-08-23 at 13:56 +1000, David Gibson wrote: > > > Jeff, I've discussed this with BenH, and although there are some > problems with the driver still, we think it's good enough to merge in > 2.6.24, the warts can be fixed up later. Please apply... Or to be more precise: This driver wi

Re: Device tree aware EMAC driver

2007-08-12 Thread David Gibson
On Fri, Aug 10, 2007 at 10:39:31PM +0200, Segher Boessenkool wrote: > > * In drivers/net/ibm_newemac/Makefile, I think the preferred method is > >to use ibm_newemac-y rather than ibm_newemac-objs. > > I thought it was the other way around, so I checked with the > Kbuild maintainer, and indeed

Re: Device tree aware EMAC driver

2007-08-10 Thread Olof Johansson
On Tue, Aug 07, 2007 at 04:22:31PM +1000, David Gibson wrote: > This driver is designed to sit alongside the old driver (it lies in > drivers/net/ibm_emac and this one in drivers/net/ibm_newemac). The > old driver is left in place to support arch/ppc until arch/ppc itself > reaches its final demi

Re: Device tree aware EMAC driver

2007-08-10 Thread Segher Boessenkool
> * In drivers/net/ibm_newemac/Makefile, I think the preferred method is >to use ibm_newemac-y rather than ibm_newemac-objs. I thought it was the other way around, so I checked with the Kbuild maintainer, and indeed you are correct. Segher ___ Li

Re: Device tree aware EMAC driver

2007-08-08 Thread Benjamin Herrenschmidt
On Wed, 2007-08-08 at 15:09 +1000, David Gibson wrote: > > Eh, all the c++ comments are FIXMEs anyway. I'm inclined to leave > them. Ahah... maybe I -did- add some of those then :-) I do use C++ comments for FIXME's on purpose, because they are ugly, it improves the changes that I actually get t

Re: Device tree aware EMAC driver

2007-08-08 Thread Benjamin Herrenschmidt
> * c++ style comments Ouch... I haven't removed them all ? I promise I didn't -add- any :-) > * in emac_probe(): > + /* Wait for dependent devices */ > + err = -ENODEV; > + err = emac_wait_deps(dev); > The initialisation to -ENODEV is pointless right?

Re: Device tree aware EMAC driver

2007-08-07 Thread David Gibson
On Wed, Aug 08, 2007 at 01:16:43PM +1000, Tony Breeds wrote: > On Tue, Aug 07, 2007 at 04:22:31PM +1000, David Gibson wrote: > > Based on BenH's earlier work, this is a new version of the EMAC driver > > for the built-in ethernet found on PowerPC 4xx embedded CPUs. The > > same ASIC is also found

Re: Device tree aware EMAC driver

2007-08-07 Thread Tony Breeds
On Tue, Aug 07, 2007 at 04:22:31PM +1000, David Gibson wrote: > Based on BenH's earlier work, this is a new version of the EMAC driver > for the built-in ethernet found on PowerPC 4xx embedded CPUs. The > same ASIC is also found in the Axon bridge chip. This new version is > designed to work in t

Re: Device tree aware EMAC driver

2007-08-07 Thread David Gibson
On Tue, Aug 07, 2007 at 07:15:39AM -0500, Josh Boyer wrote: > On Tue, 7 Aug 2007 16:22:31 +1000 > David Gibson <[EMAIL PROTECTED]> wrote: > > > Based on BenH's earlier work, this is a new version of the EMAC driver > > for the built-in ethernet found on PowerPC 4xx embedded CPUs. The > > same ASI

Re: Device tree aware EMAC driver

2007-08-07 Thread Josh Boyer
On Tue, 7 Aug 2007 16:22:31 +1000 David Gibson <[EMAIL PROTECTED]> wrote: > Based on BenH's earlier work, this is a new version of the EMAC driver > for the built-in ethernet found on PowerPC 4xx embedded CPUs. The > same ASIC is also found in the Axon bridge chip. This new version is > designed