On Thursday 22 January 2009 05:59:39 Dave Hansen wrote:
> Let's take, for instance, a 1-byte reservation. With this code, you've
> suddenly turned that into a 0-byte reservation, and that *can't* be
> right. The same thing happens if you have a reservation that spans two
> pages. If you uncondit
On Mon, 2009-01-19 at 17:00 +0530, Chandru wrote:
> --- linux-2.6.29-rc2/arch/powerpc/mm/numa.c.orig 2009-01-19
> 16:14:49.0 +0530
> +++ linux-2.6.29-rc2/arch/powerpc/mm/numa.c 2009-01-19 16:36:38.0
> +0530
> @@ -901,7 +901,8 @@ static void mark_reserved_regions_for_ni
>
Chandru wrote:
In case either physbase or reserve_size are not page aligned and in addition
if the following condition is also true
node_ar.end_pfn = node->node_end_pfn = PFN_DOWN(physbase+reserve_size).
we may hit the BUG_ON(end > bdata->node_low_pfn) in mark_bootmem_node() in
mm/bootmem.c Hen
In case either physbase or reserve_size are not page aligned and in addition
if the following condition is also true
node_ar.end_pfn = node->node_end_pfn = PFN_DOWN(physbase+reserve_size).
we may hit the BUG_ON(end > bdata->node_low_pfn) in mark_bootmem_node() in
mm/bootmem.c Hence pass the pfn t
On Friday 16 January 2009 23:22:57 Dave Hansen wrote:
> Just looking at it, that calculation is OK. But, there was one in your
> dmesg that looked a page too long, like page 0x1001 instead of 0x1000.
> I'd find out how that happened.
That is a result of PFN_UP() in reserve_bootmem_node() for whic
On Fri, 2009-01-16 at 17:46 +0530, Chandru wrote:
> On Thursday 15 January 2009 13:35:27 Chandru wrote:
> > Hello Dave, From the debug console output, if there is anything you can add
> > here, pls let me know.
>
> As we can see from the console output here, physbase isn't page aligned when
> th
On Thursday 15 January 2009 13:35:27 Chandru wrote:
> Hello Dave, From the debug console output, if there is anything you can add
> here, pls let me know.
As we can see from the console output here, physbase isn't page aligned when
the panic occurs. So we could as well send (start_pfn << PAGE_S
On Friday 09 January 2009 16:37:24 Chandru wrote:
> On Friday 09 January 2009 01:33:12 Dave Hansen wrote:
> > Now I'm even more confused. Could you please send a fully changelogged
> > patch that describes the problem, and how this fixes it? This just
> > seems like an off-by-one error, which isn
On Friday 09 January 2009 01:33:12 Dave Hansen wrote:
> Now I'm even more confused. Could you please send a fully changelogged
> patch that describes the problem, and how this fixes it? This just
> seems like an off-by-one error, which isn't what I thought we had before
> at all.
>
> I'm also ho
On Thu, 2009-01-08 at 15:59 +0530, Chandru wrote:
> @@ -898,9 +899,17 @@ static void mark_reserved_regions_for_ni
> * if reserved region extends past active region
> * then trim size to active region
> */
> -
On Wednesday 07 January 2009 22:55:25 Dave Hansen wrote:
>
> I'm just suggesting making your fix in the ppc code instead of in
> mm/bootmem.c.
>
Here are the changes that helped to boot the kernel. Please review it.
Thanks,
Signed-off-by: Chandru S
Cc: Dave Hansen
---
arch/powerpc/mm/numa.c
On Wed, 2009-01-07 at 18:28 +0530, Chandru wrote:
> I don't know how you wanted NODE_DATA() to be consulted here. i.e before
> calling reserve_bootmem_node() should we have a condition
>
> if (PFN_UP(physbase+reserve_size) > node_end_pfn)
> then
> resize reserve_
On Monday 05 January 2009 22:00:33 Dave Hansen wrote:
> OK, I had to think about this for a good, long time. That's bad. :)
>
> There are two things that we're dealing with here: "active regions" and
> the NODE_DATA's. The if() you've pasted above resizes the reservation
> so that it fits into th
On Mon, 2009-01-05 at 19:19 +0530, Chandru wrote:
> On Tuesday 30 December 2008 03:06:07 Dave Hansen wrote:
> When booted with crashkernel=2...@32m or any memory size less than
> this, the system boots properly. The system comes up with two nodes
> (0-256M and 256M-4GB). The crashkernel memory rese
On Tuesday 30 December 2008 03:06:07 Dave Hansen wrote:
> On Fri, 2008-12-26 at 11:59 +1100, Paul Mackerras wrote:
> > > + }
> > > +
> > > + for_each_online_node(nid) {
> > > /*
> > > - * Be very careful about moving this around. Future
> > > - * cal
On Fri, 2008-12-26 at 11:59 +1100, Paul Mackerras wrote:
>
> > diff -puN
> > arch/powerpc/mm/numa.c~2628-rc9-panics-with-crashkernel=256m-while-booting
> > arch/powerpc/mm/numa.c
> > ---
> > a/arch/powerpc/mm/numa.c~2628-rc9-panics-with-crashkernel=256m-while-booting
> > +++ a/arch/powerpc/mm/n
Andrew Morton writes:
> On Wed, 24 Dec 2008 13:25:49 +0530 Chandru wrote:
>
> > On a ppc machine booting linux-2.6.28-rc9 with crashkernel=2...@32m boot
> > parameter causes the kernel to panic while booting. __Following are the
> > console
> > messages...
>
> - Please put [patch] in the Sub
On Wed, 24 Dec 2008 23:35:36 -0800 Andrew Morton
wrote:
> - Please put [patch] in the Subject: line of patches
>
> - Please choose a suitable title, as per
> Documentation/SubmittingPatches, section 15.
>
> - Please cc suitable mailing lists and maintainers on bug reports and
> on patches.
(cc's added)
On Wed, 24 Dec 2008 13:25:49 +0530 Chandru wrote:
> On a ppc machine booting linux-2.6.28-rc9 with crashkernel=2...@32m boot
> parameter causes the kernel to panic while booting. __Following are the
> console
> messages...
- Please put [patch] in the Subject: line of patches
-
19 matches
Mail list logo
