Re: [patch 2/3] PS3: Add logical performance monitor device support

2008-01-06 Thread Geoff Levand
On 01/05/2008 03:29 AM, Arnd Bergmann wrote: > On Saturday 05 January 2008, Geoff Levand wrote: >> + struct layout { >> + struct ps3_system_bus_device dev; >> + } *p; > > What's the point of this data structure? You don't use the > struct anywhere, and it only has one mem

Re: [patch 2/3] PS3: Add logical performance monitor device support

2008-01-05 Thread Arnd Bergmann
On Saturday 05 January 2008, Geoff Levand wrote: > + struct layout { > + struct ps3_system_bus_device dev; > + } *p; What's the point of this data structure? You don't use the struct anywhere, and it only has one member, so you could just declare that directly. > +