Re: [kvm-unit-tests PATCH 03/13] treewide: lib/stack: Fix backtrace

2024-02-29 Thread Andrew Jones
On Thu, Feb 29, 2024 at 01:31:52PM +1000, Nicholas Piggin wrote: > On Thu Feb 29, 2024 at 1:04 AM AEST, Andrew Jones wrote: ... > > diff --git a/lib/stack.h b/lib/stack.h > > index 10fc2f793354..6edc84344b51 100644 > > --- a/lib/stack.h > > +++ b/lib/stack.h > > @@ -11,17 +11,27 @@ > > #include >

Re: [kvm-unit-tests PATCH 03/13] treewide: lib/stack: Fix backtrace

2024-02-28 Thread Nicholas Piggin
On Thu Feb 29, 2024 at 1:04 AM AEST, Andrew Jones wrote: > We should never pass the result of __builtin_frame_address(0) to > another function since the compiler is within its rights to pop the > frame to which it points before making the function call, as may be > done for tail calls. Nobody has c

Re: [kvm-unit-tests PATCH 03/13] treewide: lib/stack: Fix backtrace

2024-02-28 Thread Claudio Imbrenda
On Wed, 28 Feb 2024 16:04:19 +0100 Andrew Jones wrote: > We should never pass the result of __builtin_frame_address(0) to > another function since the compiler is within its rights to pop the > frame to which it points before making the function call, as may be > done for tail calls. Nobody has c