Re: [RFC PATCH v2 06/18] x86: dump_trace() error handling

2016-04-29 Thread Minfei Huang
On 04/28/16 at 03:44P, Josh Poimboeuf wrote: > In preparation for being able to determine whether a given stack trace > is reliable, allow the stacktrace_ops functions to propagate errors to > dump_trace(). Hi, Josh. Have you considered to make walk_stack function as non-return function, since th

Re: [RFC PATCH v2 06/18] x86: dump_trace() error handling

2016-04-29 Thread Josh Poimboeuf
On Fri, Apr 29, 2016 at 09:45:58PM +0800, Minfei Huang wrote: > On 04/28/16 at 03:44P, Josh Poimboeuf wrote: > > In preparation for being able to determine whether a given stack trace > > is reliable, allow the stacktrace_ops functions to propagate errors to > > dump_trace(). > > Hi, Josh. > > Ha