Re: [RFC PATCH 6/7] serial: General support for multipoint addresses

2022-03-10 Thread Andy Shevchenko
On Wed, Mar 09, 2022 at 08:05:21PM +0100, Lukas Wunner wrote: > On Mon, Mar 07, 2022 at 11:48:01AM +0200, Ilpo Järvinen wrote: > > On Sun, 6 Mar 2022, Lukas Wunner wrote: > > > On Wed, Mar 02, 2022 at 11:56:05AM +0200, Ilpo Järvinen wrote: > > > > This change is necessary for supporting devices wit

Re: [RFC PATCH 6/7] serial: General support for multipoint addresses

2022-03-10 Thread Ilpo Järvinen
On Wed, 9 Mar 2022, Lukas Wunner wrote: > On Mon, Mar 07, 2022 at 11:48:01AM +0200, Ilpo Järvinen wrote: > > On Sun, 6 Mar 2022, Lukas Wunner wrote: > > > On Wed, Mar 02, 2022 at 11:56:05AM +0200, Ilpo Järvinen wrote: > > > > This change is necessary for supporting devices with RS485 > > > > multi

Re: [RFC PATCH 6/7] serial: General support for multipoint addresses

2022-03-09 Thread Lukas Wunner
On Mon, Mar 07, 2022 at 11:48:01AM +0200, Ilpo Järvinen wrote: > On Sun, 6 Mar 2022, Lukas Wunner wrote: > > On Wed, Mar 02, 2022 at 11:56:05AM +0200, Ilpo Järvinen wrote: > > > This change is necessary for supporting devices with RS485 > > > multipoint addressing [*]. > > > > If this is only used

Re: [RFC PATCH 6/7] serial: General support for multipoint addresses

2022-03-07 Thread Ilpo Järvinen
On Sun, 6 Mar 2022, Lukas Wunner wrote: > On Wed, Mar 02, 2022 at 11:56:05AM +0200, Ilpo Järvinen wrote: > > > This change is necessary for supporting devices with RS485 > > multipoint addressing [*]. > > If this is only used with RS485, why can't we just store the > addresses in struct serial_r

Re: [RFC PATCH 6/7] serial: General support for multipoint addresses

2022-03-06 Thread Lukas Wunner
On Wed, Mar 02, 2022 at 11:56:05AM +0200, Ilpo Järvinen wrote: > This patch adds generic support for serial multipoint > addressing. Two new ioctls are added. TIOCSADDR is used to Nit: "This patch adds..." is superfluous. Just write "Add ..." in imperative mood. > This change is necessary for