Re: [RFC] Hardware Breakpoint interfaces implementation for PPC64

2009-05-14 Thread K.Prasad
On Wed, May 13, 2009 at 12:57:17PM +1000, David Gibson wrote: > On Wed, May 13, 2009 at 01:55:45AM +0530, K.Prasad wrote: > > On Tue, May 12, 2009 at 07:51:49AM -0400, Josh Boyer wrote: > > > On Tue, May 12, 2009 at 01:33:55AM +0530, K.Prasad wrote: > [snip] > > It seems to me that a kind of minim

Re: [RFC] Hardware Breakpoint interfaces implementation for PPC64

2009-05-12 Thread David Gibson
On Wed, May 13, 2009 at 01:55:45AM +0530, K.Prasad wrote: > On Tue, May 12, 2009 at 07:51:49AM -0400, Josh Boyer wrote: > > On Tue, May 12, 2009 at 01:33:55AM +0530, K.Prasad wrote: [snip] > I do see that Book-E processors will have severe memory footprint > constraints (in embedded environment) an

Re: [RFC] Hardware Breakpoint interfaces implementation for PPC64

2009-05-12 Thread David Gibson
On Wed, May 13, 2009 at 12:57:17PM +1000, David Gibson wrote: > On Wed, May 13, 2009 at 01:55:45AM +0530, K.Prasad wrote: > > On Tue, May 12, 2009 at 07:51:49AM -0400, Josh Boyer wrote: > > > On Tue, May 12, 2009 at 01:33:55AM +0530, K.Prasad wrote: > [snip] > > I do see that Book-E processors will

Re: [RFC] Hardware Breakpoint interfaces implementation for PPC64

2009-05-12 Thread K.Prasad
On Tue, May 12, 2009 at 11:47:38AM -0500, Scott Wood wrote: > On Tue, May 12, 2009 at 07:51:49AM -0400, Josh Boyer wrote: > > On Tue, May 12, 2009 at 01:33:55AM +0530, K.Prasad wrote: > > >- The patch is currently implemented only for PPC64 architecture. Other > > > architectures (especially Book-

Re: [RFC] Hardware Breakpoint interfaces implementation for PPC64

2009-05-12 Thread K.Prasad
On Tue, May 12, 2009 at 07:51:49AM -0400, Josh Boyer wrote: > On Tue, May 12, 2009 at 01:33:55AM +0530, K.Prasad wrote: > >Hi PPC Dev folks, > > Please find a patch below that implements the proposed Hardware > >Breakpoint interfaces for PPC64 architecture. > > > >As a brief introduction, the p

Re: [RFC] Hardware Breakpoint interfaces implementation for PPC64

2009-05-12 Thread K.Prasad
On Tue, May 12, 2009 at 10:56:04AM +1000, Michael Neuling wrote: > > Hi PPC Dev folks, > > Please find a patch below that implements the proposed Hardware > > Breakpoint interfaces for PPC64 architecture. > > > > As a brief introduction, the proposed Hardware Breakpoint > > infrastructure prov

Re: [RFC] Hardware Breakpoint interfaces implementation for PPC64

2009-05-12 Thread Scott Wood
On Tue, May 12, 2009 at 07:51:49AM -0400, Josh Boyer wrote: > On Tue, May 12, 2009 at 01:33:55AM +0530, K.Prasad wrote: > >- The patch is currently implemented only for PPC64 architecture. Other > > architectures (especially Book-E implementations are expected to > > happen in due course). > > D

Re: [RFC] Hardware Breakpoint interfaces implementation for PPC64

2009-05-12 Thread Josh Boyer
On Tue, May 12, 2009 at 01:33:55AM +0530, K.Prasad wrote: >Hi PPC Dev folks, > Please find a patch below that implements the proposed Hardware >Breakpoint interfaces for PPC64 architecture. > >As a brief introduction, the proposed Hardware Breakpoint >infrastructure provides generic in-kernel

Re: [RFC] Hardware Breakpoint interfaces implementation for PPC64

2009-05-11 Thread Michael Neuling
> > +struct arch_hw_breakpoint { > > + char*name; /* Contains name of the symbol to set bkpt */ > > + unsigned long address; > > + u8 type; > > +}; > > Can you reorder this to pack the struct better (ie. put the unsigned > long first). Oops, this is a char * not j

Re: [RFC] Hardware Breakpoint interfaces implementation for PPC64

2009-05-11 Thread Michael Neuling
> Hi PPC Dev folks, > Please find a patch below that implements the proposed Hardware > Breakpoint interfaces for PPC64 architecture. > > As a brief introduction, the proposed Hardware Breakpoint > infrastructure provides generic in-kernel interfaces to which users > from kernel- and user-sp