Benjamin Herrenschmidt wrote:
> On Tue, 2008-02-26 at 09:02 -0600, Josh Boyer wrote:
>> Seems the code will do the right thing since everything is using
>> flags. I suppose my question can be withdrawn. It is slightly
>> confusing to do it that way though. Perhaps a function to do
>> read-modify
On Tue, 2008-02-26 at 09:02 -0600, Josh Boyer wrote:
> Seems the code will do the right thing since everything is using
> flags. I suppose my question can be withdrawn. It is slightly
> confusing to do it that way though. Perhaps a function to do
> read-modify-writes on DCRs would be welcome.
On Tue, 26 Feb 2008 09:10:06 -0500
"Steven A. Falco" <[EMAIL PROTECTED]> wrote:
> When I saw Josh's question, I thought the irq save/restore was there to
> make the read-modify-write atomic; i.e. read SDR0_MFR, "AND" out some
> bits, then write it back without the possibility of anything else
> to
>>> +static inline void emac_rx_clk_default(struct emac_instance *dev)
>>> +{
>>> + if (emac_has_feature(dev, EMAC_FTR_440EP_PHY_CLK_FIX)) {
>>> + unsigned long flags;
>>> +
>>> + local_irq_save(flags);
>>> + mtdcri(SDR0, SDR0_MFR, mfdcri(SDR0, SDR0_MFR) &
>>> +
Josh Boyer wrote:
> On Fri, 22 Feb 2008 22:28:17 +0300
> Valentine Barshak <[EMAIL PROTECTED]> wrote:
>
>> This patch adds ibm_newemac phy clock workaround for 440EP/440GR emacs.
>> The code is based on the previous ibm_emac driver stuff. The 440EP/440GR
>> allows controlling each EMAC clock spear
On Fri, 22 Feb 2008 22:28:17 +0300
Valentine Barshak <[EMAIL PROTECTED]> wrote:
> This patch adds ibm_newemac phy clock workaround for 440EP/440GR emacs.
> The code is based on the previous ibm_emac driver stuff. The 440EP/440GR
> allows controlling each EMAC clock spearately as opposed to global
