Re: [RFC][PATCH] fsl_soc: add support for fsl_spi

2007-07-27 Thread Anton Vorontsov
On Thu, Jul 26, 2007 at 11:45:08AM -0500, Scott Wood wrote: > On Thu, Jul 26, 2007 at 05:56:55PM +0400, Anton Vorontsov wrote: > > +void (*fsl_spi_activate_cs)(u8 cs, u8 polarity) = NULL; > > +EXPORT_SYMBOL(fsl_spi_activate_cs); > > +void (*fsl_spi_deactivate_cs)(u8 cs, u8 polarity) = NULL; > > +EX

Re: [RFC][PATCH] fsl_soc: add support for fsl_spi

2007-07-27 Thread Kumar Gala
On Jul 26, 2007, at 8:56 AM, Anton Vorontsov wrote: > Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> > --- > arch/powerpc/sysdev/fsl_soc.c | 76 ++ > +++ > arch/powerpc/sysdev/fsl_soc.h |3 ++ > 2 files changed, 79 insertions(+), 0 deletions(-) The

Re: [RFC][PATCH] fsl_soc: add support for fsl_spi

2007-07-27 Thread Kumar Gala
On Jul 26, 2007, at 12:05 PM, Vitaly Bordug wrote: > On Thu, 26 Jul 2007 11:45:08 -0500 > Scott Wood <[EMAIL PROTECTED]> wrote: > >> On Thu, Jul 26, 2007 at 05:56:55PM +0400, Anton Vorontsov wrote: >>> +void (*fsl_spi_activate_cs)(u8 cs, u8 polarity) = NULL; >>> +EXPORT_SYMBOL(fsl_spi_activate_cs

Re: [RFC][PATCH] fsl_soc: add support for fsl_spi

2007-07-26 Thread Scott Wood
Vitaly Bordug wrote: > On Thu, 26 Jul 2007 11:45:08 -0500 > Scott Wood <[EMAIL PROTECTED]> wrote: >>Why not make the fsl spi driver an of_platform device? > > Because this particular thing is not ppc-only from what I recall. spi_mpc83xx.c isn't ppc-only? Even if it weren't, the OF stuff has been

Re: [RFC][PATCH] fsl_soc: add support for fsl_spi

2007-07-26 Thread Vitaly Bordug
On Thu, 26 Jul 2007 11:45:08 -0500 Scott Wood <[EMAIL PROTECTED]> wrote: > On Thu, Jul 26, 2007 at 05:56:55PM +0400, Anton Vorontsov wrote: > > +void (*fsl_spi_activate_cs)(u8 cs, u8 polarity) = NULL; > > +EXPORT_SYMBOL(fsl_spi_activate_cs); > > +void (*fsl_spi_deactivate_cs)(u8 cs, u8 polarity) =

Re: [RFC][PATCH] fsl_soc: add support for fsl_spi

2007-07-26 Thread Scott Wood
On Thu, Jul 26, 2007 at 05:56:55PM +0400, Anton Vorontsov wrote: > +void (*fsl_spi_activate_cs)(u8 cs, u8 polarity) = NULL; > +EXPORT_SYMBOL(fsl_spi_activate_cs); > +void (*fsl_spi_deactivate_cs)(u8 cs, u8 polarity) = NULL; > +EXPORT_SYMBOL(fsl_spi_deactivate_cs); What are these for? It looks lik