On Tue, Dec 16, 2008 at 9:41 PM, Wolfram Sang wrote:
>
>> It is pretty poor form to not even bother to Cc the only author of the
>> code you are modifying, and have no Signed-off-by or Acked-by to even
>> suggest that it was ever even looked at. This isn't something that ought
>> to have to be poi
On Tue, Dec 16, 2008 at 01:27:32PM +0100, Wolfram Sang wrote:
> > > +/* -
> > > + * OF bus binding
> > > + */
> > > +
> > > +#if defined(CONFIG_OF)
> >
> > Same goes here, don't put #if in .c files please.
>
> So, generally speak
On Tue, Dec 16, 2008 at 01:41:56PM +0100, Wolfram Sang wrote:
> > In addition to the stuff pointed out by Greg, I don't see what you
> > actually gain by hacking the OF crap in to this driver. You would be
> > better off layering the OF driver on top of this, rather than trying to
> > make them liv
> It is pretty poor form to not even bother to Cc the only author of the
> code you are modifying, and have no Signed-off-by or Acked-by to even
> suggest that it was ever even looked at. This isn't something that ought
> to have to be pointed out, either.
Oops, yes, forgot this in the resend, I
> > +/* -
> > + * OF bus binding
> > + */
> > +
> > +#if defined(CONFIG_OF)
>
> Same goes here, don't put #if in .c files please.
So, generally speaking, this means that I should not put a
platform_driver and an of_platform_drive
On Thu, Dec 11, 2008 at 04:05:37PM +0100, Wolfram Sang wrote:
> Make the generic uio-driver also accessible for of devices. It utilizes the
> standard 'reg' and 'interrupt' properties. A typical usage would look like
> this:
>
> fpga...@3000 {
> compatible = "generic-uio";
On Thu, Dec 11, 2008 at 04:05:37PM +0100, Wolfram Sang wrote:
> Make the generic uio-driver also accessible for of devices. It utilizes the
> standard 'reg' and 'interrupt' properties. A typical usage would look like
> this:
>
> fpga...@3000 {
> compatible = "generic-uio";
