Appreciate your review.
> + static int int_no = 0; /* To remember last used interrupt */
>
> This is a worry. There is nothing AFAIK to stop two drivers (eg. network
> & scsi) calling into here at the same time, which could lead to
> corrupting int_no. If you just want a global counter you n
On Wed, Nov 03, 2010 at 11:11:33PM +1100, Michael Ellerman wrote:
>> +struct device_node *msi_dev = NULL;
>> +const u32 *count;
>> +
>> +msi_dev = of_find_node_by_name(NULL, "ppc4xx-msi");
>> +if (msi_dev)
>> +return -ENODEV;
>> +
You also leak a reference to the node h
On Thu, 2010-10-28 at 15:55 -0700, tma...@apm.com wrote:
> From: Tirumala Marri
>
> This patch adds MSI support for 440SPe, 460Ex, 460Sx and 405Ex.
Hi Marri,
I don't know anything about your hardware, but I'll try and review the
other parts of your patch.
..
> diff --git a/arch/powerpc/platfo
