Re: [PATCH v7 3/8] KVM: Make __kvm_follow_pfn not imply FOLL_GET

2023-09-06 Thread Sean Christopherson
On Wed, Sep 06, 2023, David Stevens wrote: > On Wed, Sep 6, 2023 at 9:45 AM Sean Christopherson wrote: > > > > On Tue, Sep 05, 2023, David Stevens wrote: > > > For property 2, FOLL_GET is also important. If guarded_by_mmu_notifier > > > is set, then we're all good here. If guarded_by_mmu_notifier

Re: [PATCH v7 3/8] KVM: Make __kvm_follow_pfn not imply FOLL_GET

2023-09-05 Thread David Stevens
On Wed, Sep 6, 2023 at 9:45 AM Sean Christopherson wrote: > > On Tue, Sep 05, 2023, David Stevens wrote: > > On Wed, Jul 12, 2023 at 7:00 AM Sean Christopherson > > wrote: > > > > > > On Tue, Jul 11, 2023, Zhi Wang wrote: > > > > On Thu, 6 Jul 2023 15:49:39 +0900 > > > > David Stevens wrote: >

Re: [PATCH v7 3/8] KVM: Make __kvm_follow_pfn not imply FOLL_GET

2023-09-05 Thread Sean Christopherson
On Tue, Sep 05, 2023, David Stevens wrote: > On Wed, Jul 12, 2023 at 7:00 AM Sean Christopherson wrote: > > > > On Tue, Jul 11, 2023, Zhi Wang wrote: > > > On Thu, 6 Jul 2023 15:49:39 +0900 > > > David Stevens wrote: > > > > > > > On Wed, Jul 5, 2023 at 10:19___PM Zhi Wang > > > > wrote: > > >

Re: [PATCH v7 3/8] KVM: Make __kvm_follow_pfn not imply FOLL_GET

2023-09-05 Thread David Stevens
On Wed, Jul 12, 2023 at 7:00 AM Sean Christopherson wrote: > > On Tue, Jul 11, 2023, Zhi Wang wrote: > > On Thu, 6 Jul 2023 15:49:39 +0900 > > David Stevens wrote: > > > > > On Wed, Jul 5, 2023 at 10:19___PM Zhi Wang > > > wrote: > > > > > > > > On Tue, 4 Jul 2023 16:50:48 +0900 > > > > David

Re: [PATCH v7 3/8] KVM: Make __kvm_follow_pfn not imply FOLL_GET

2023-07-11 Thread Sean Christopherson
On Tue, Jul 11, 2023, Zhi Wang wrote: > On Thu, 6 Jul 2023 15:49:39 +0900 > David Stevens wrote: > > > On Wed, Jul 5, 2023 at 10:19___PM Zhi Wang wrote: > > > > > > On Tue, 4 Jul 2023 16:50:48 +0900 > > > David Stevens wrote: > > > If yes, do we have to use FOLL_GET to resolve GFN associated w

Re: [PATCH v7 3/8] KVM: Make __kvm_follow_pfn not imply FOLL_GET

2023-07-11 Thread Zhi Wang
On Thu, 6 Jul 2023 15:49:39 +0900 David Stevens wrote: > On Wed, Jul 5, 2023 at 10:19___PM Zhi Wang wrote: > > > > On Tue, 4 Jul 2023 16:50:48 +0900 > > David Stevens wrote: > > > > > From: David Stevens > > > > > > Make it so that __kvm_follow_pfn does not imply FOLL_GET. This allows > > >

Re: [PATCH v7 3/8] KVM: Make __kvm_follow_pfn not imply FOLL_GET

2023-07-05 Thread David Stevens
On Wed, Jul 5, 2023 at 10:19 PM Zhi Wang wrote: > > On Tue, 4 Jul 2023 16:50:48 +0900 > David Stevens wrote: > > > From: David Stevens > > > > Make it so that __kvm_follow_pfn does not imply FOLL_GET. This allows > > callers to resolve a gfn when the associated pfn has a valid struct page > > t

Re: [PATCH v7 3/8] KVM: Make __kvm_follow_pfn not imply FOLL_GET

2023-07-05 Thread David Stevens
On Wed, Jul 5, 2023 at 8:56 PM Yu Zhang wrote: > > On Tue, Jul 04, 2023 at 04:50:48PM +0900, David Stevens wrote: > > From: David Stevens > > > > Make it so that __kvm_follow_pfn does not imply FOLL_GET. This allows > > callers to resolve a gfn when the associated pfn has a valid struct page > >

Re: [PATCH v7 3/8] KVM: Make __kvm_follow_pfn not imply FOLL_GET

2023-07-05 Thread Zhi Wang
On Tue, 4 Jul 2023 16:50:48 +0900 David Stevens wrote: > From: David Stevens > > Make it so that __kvm_follow_pfn does not imply FOLL_GET. This allows > callers to resolve a gfn when the associated pfn has a valid struct page > that isn't being actively refcounted (e.g. tail pages of non-compo

Re: [PATCH v7 3/8] KVM: Make __kvm_follow_pfn not imply FOLL_GET

2023-07-05 Thread Yu Zhang
On Tue, Jul 04, 2023 at 04:50:48PM +0900, David Stevens wrote: > From: David Stevens > > Make it so that __kvm_follow_pfn does not imply FOLL_GET. This allows > callers to resolve a gfn when the associated pfn has a valid struct page > that isn't being actively refcounted (e.g. tail pages of non-

Re: [PATCH v7 3/8] KVM: Make __kvm_follow_pfn not imply FOLL_GET

2023-07-05 Thread Yu Zhang
> > +void kvm_set_page_accessed(struct page *page); > +void kvm_set_page_dirty(struct page *page); > + No one calls these 2 routines in this patch. How about move this change to [PATCH v7 5/8] KVM: x86/mmu: Don't pass FOLL_GET to __kvm_follow_pfn ? ... > @@ -2930,17 +2933,19 @@ static bool kvm_