Re: [PATCH v6 6/7] mm/memory_hotplug: Embed vmem_altmap details in memory block

2023-07-27 Thread David Hildenbrand
+ /* +* Now that we are tracking alloc and free correctly +* we can add check to verify altmap free pages. +*/ Better remove the history lesson from the comment. "Verify that all vmemmap pages have actually been freed." + if (altmap) { + WA

Re: [PATCH v6 6/7] mm/memory_hotplug: Embed vmem_altmap details in memory block

2023-07-27 Thread Michal Hocko
On Thu 27-07-23 15:02:12, Aneesh Kumar K V wrote: > On 7/27/23 2:55 PM, Michal Hocko wrote: > > On Thu 27-07-23 13:32:31, Aneesh Kumar K.V wrote: > >> With memmap on memory, some architecture needs more details w.r.t altmap > >> such as base_pfn, end_pfn, etc to unmap vmemmap memory. Instead of > >

Re: [PATCH v6 6/7] mm/memory_hotplug: Embed vmem_altmap details in memory block

2023-07-27 Thread Aneesh Kumar K V
On 7/27/23 2:55 PM, Michal Hocko wrote: > On Thu 27-07-23 13:32:31, Aneesh Kumar K.V wrote: >> With memmap on memory, some architecture needs more details w.r.t altmap >> such as base_pfn, end_pfn, etc to unmap vmemmap memory. Instead of >> computing them again when we remove a memory block, embed

Re: [PATCH v6 6/7] mm/memory_hotplug: Embed vmem_altmap details in memory block

2023-07-27 Thread Michal Hocko
On Thu 27-07-23 13:32:31, Aneesh Kumar K.V wrote: > With memmap on memory, some architecture needs more details w.r.t altmap > such as base_pfn, end_pfn, etc to unmap vmemmap memory. Instead of > computing them again when we remove a memory block, embed vmem_altmap > details in struct memory_block