Re: [PATCH v6 2/3] drivers/vfio: EEH support for VFIO PCI device

2014-05-27 Thread Alex Williamson
On Sat, 2014-05-24 at 12:06 +1000, Gavin Shan wrote: > On Fri, May 23, 2014 at 08:29:59AM -0600, Alex Williamson wrote: > >On Fri, 2014-05-23 at 14:37 +1000, Gavin Shan wrote: > >> On Thu, May 22, 2014 at 09:10:53PM -0600, Alex Williamson wrote: > >> >On Thu, 2014-05-22 at 18:23 +1000, Gavin Shan w

Re: [PATCH v6 2/3] drivers/vfio: EEH support for VFIO PCI device

2014-05-23 Thread Gavin Shan
On Fri, May 23, 2014 at 08:29:59AM -0600, Alex Williamson wrote: >On Fri, 2014-05-23 at 14:37 +1000, Gavin Shan wrote: >> On Thu, May 22, 2014 at 09:10:53PM -0600, Alex Williamson wrote: >> >On Thu, 2014-05-22 at 18:23 +1000, Gavin Shan wrote: .../... >No, sorry, I mean how does the user get info

Re: [PATCH v6 2/3] drivers/vfio: EEH support for VFIO PCI device

2014-05-23 Thread Gavin Shan
On Fri, May 23, 2014 at 02:49:13PM +0200, Alexander Graf wrote: .../... > >VFIO_EEH_RECOVER? > Then it should contain VFIO_EEH_PE_RESET, which is part of the recovery. I don't expect the recovery to be done with one ioctl command :-) I personally prefer to keep VFIO_EEH_PE_CONFIUGRE, which mean

Re: [PATCH v6 2/3] drivers/vfio: EEH support for VFIO PCI device

2014-05-23 Thread Gavin Shan
On Fri, May 23, 2014 at 08:49:19AM -0600, Alex Williamson wrote: >On Fri, 2014-05-23 at 14:30 +0200, Alexander Graf wrote: >> On 23.05.14 13:58, Gavin Shan wrote: >> > On Fri, May 23, 2014 at 08:52:23AM +0200, Alexander Graf wrote: >> >>> Am 23.05.2014 um 05:23 schrieb Alex Williamson >> >>> : >>

Re: [PATCH v6 2/3] drivers/vfio: EEH support for VFIO PCI device

2014-05-23 Thread Alex Williamson
On Fri, 2014-05-23 at 14:30 +0200, Alexander Graf wrote: > On 23.05.14 13:58, Gavin Shan wrote: > > On Fri, May 23, 2014 at 08:52:23AM +0200, Alexander Graf wrote: > >> > >>> Am 23.05.2014 um 05:23 schrieb Alex Williamson > >>> : > >>> > On Fri, 2014-05-23 at 10:37 +1000, Gavin Shan wrote: >

Re: [PATCH v6 2/3] drivers/vfio: EEH support for VFIO PCI device

2014-05-23 Thread Alex Williamson
On Fri, 2014-05-23 at 15:00 +1000, Benjamin Herrenschmidt wrote: > On Fri, 2014-05-23 at 14:37 +1000, Gavin Shan wrote: > > >There's no notification, the user needs to observe the return value an > > >poll? Should we be enabling an eventfd to notify the user of the state > > >change? > > > > > >

Re: [PATCH v6 2/3] drivers/vfio: EEH support for VFIO PCI device

2014-05-23 Thread Alex Williamson
On Fri, 2014-05-23 at 14:37 +1000, Gavin Shan wrote: > On Thu, May 22, 2014 at 09:10:53PM -0600, Alex Williamson wrote: > >On Thu, 2014-05-22 at 18:23 +1000, Gavin Shan wrote: > >> The patch adds new IOCTL commands for VFIO PCI device to support > >> EEH functionality for PCI devices, which have be

Re: [PATCH v6 2/3] drivers/vfio: EEH support for VFIO PCI device

2014-05-23 Thread Alexander Graf
On 23.05.14 14:51, Alex Williamson wrote: On Fri, 2014-05-23 at 08:52 +0200, Alexander Graf wrote: Am 23.05.2014 um 05:23 schrieb Alex Williamson : On Fri, 2014-05-23 at 10:37 +1000, Gavin Shan wrote: On Fri, May 23, 2014 at 10:17:30AM +1000, Gavin Shan wrote: On Thu, May 22, 2014 at 11:55:

Re: [PATCH v6 2/3] drivers/vfio: EEH support for VFIO PCI device

2014-05-23 Thread Alex Williamson
On Fri, 2014-05-23 at 08:52 +0200, Alexander Graf wrote: > > > Am 23.05.2014 um 05:23 schrieb Alex Williamson : > > > >> On Fri, 2014-05-23 at 10:37 +1000, Gavin Shan wrote: > >>> On Fri, May 23, 2014 at 10:17:30AM +1000, Gavin Shan wrote: > On Thu, May 22, 2014 at 11:55:29AM +0200, Alexande

Re: [PATCH v6 2/3] drivers/vfio: EEH support for VFIO PCI device

2014-05-23 Thread Alexander Graf
On 23.05.14 14:43, Gavin Shan wrote: On Fri, May 23, 2014 at 01:58:50PM +0200, Alexander Graf wrote: On 23.05.14 13:55, Gavin Shan wrote: On Fri, May 23, 2014 at 11:58:22AM +0200, Alexander Graf wrote: On 23.05.14 09:37, Gavin Shan wrote: On Fri, May 23, 2014 at 08:55:15AM +0200, Alexander G

Re: [PATCH v6 2/3] drivers/vfio: EEH support for VFIO PCI device

2014-05-23 Thread Gavin Shan
On Fri, May 23, 2014 at 01:58:50PM +0200, Alexander Graf wrote: > >On 23.05.14 13:55, Gavin Shan wrote: >>On Fri, May 23, 2014 at 11:58:22AM +0200, Alexander Graf wrote: >>>On 23.05.14 09:37, Gavin Shan wrote: On Fri, May 23, 2014 at 08:55:15AM +0200, Alexander Graf wrote: >>Am 23.05.2014 u

Re: [PATCH v6 2/3] drivers/vfio: EEH support for VFIO PCI device

2014-05-23 Thread Alexander Graf
On 23.05.14 13:58, Gavin Shan wrote: On Fri, May 23, 2014 at 08:52:23AM +0200, Alexander Graf wrote: Am 23.05.2014 um 05:23 schrieb Alex Williamson : On Fri, 2014-05-23 at 10:37 +1000, Gavin Shan wrote: On Fri, May 23, 2014 at 10:17:30AM +1000, Gavin Shan wrote: On Thu, May 22, 2014 at 11

Re: [PATCH v6 2/3] drivers/vfio: EEH support for VFIO PCI device

2014-05-23 Thread Alexander Graf
On 23.05.14 13:55, Gavin Shan wrote: On Fri, May 23, 2014 at 11:58:22AM +0200, Alexander Graf wrote: On 23.05.14 09:37, Gavin Shan wrote: On Fri, May 23, 2014 at 08:55:15AM +0200, Alexander Graf wrote: Am 23.05.2014 um 06:37 schrieb Gavin Shan : On Thu, May 22, 2014 at 09:10:53PM -0600, Alex

Re: [PATCH v6 2/3] drivers/vfio: EEH support for VFIO PCI device

2014-05-23 Thread Gavin Shan
On Fri, May 23, 2014 at 08:52:23AM +0200, Alexander Graf wrote: > > >> Am 23.05.2014 um 05:23 schrieb Alex Williamson : >> >>> On Fri, 2014-05-23 at 10:37 +1000, Gavin Shan wrote: On Fri, May 23, 2014 at 10:17:30AM +1000, Gavin Shan wrote: > On Thu, May 22, 2014 at 11:55:29AM +0200, Alexa

Re: [PATCH v6 2/3] drivers/vfio: EEH support for VFIO PCI device

2014-05-23 Thread Gavin Shan
On Fri, May 23, 2014 at 11:58:22AM +0200, Alexander Graf wrote: > >On 23.05.14 09:37, Gavin Shan wrote: >>On Fri, May 23, 2014 at 08:55:15AM +0200, Alexander Graf wrote: Am 23.05.2014 um 06:37 schrieb Gavin Shan : >On Thu, May 22, 2014 at 09:10:53PM -0600, Alex Williamson wrote: >>On Th

Re: [PATCH v6 2/3] drivers/vfio: EEH support for VFIO PCI device

2014-05-23 Thread Alexander Graf
On 23.05.14 09:37, Gavin Shan wrote: On Fri, May 23, 2014 at 08:55:15AM +0200, Alexander Graf wrote: Am 23.05.2014 um 06:37 schrieb Gavin Shan : On Thu, May 22, 2014 at 09:10:53PM -0600, Alex Williamson wrote: On Thu, 2014-05-22 at 18:23 +1000, Gavin Shan wrote: The patch adds new IOCTL comma

Re: [PATCH v6 2/3] drivers/vfio: EEH support for VFIO PCI device

2014-05-23 Thread Gavin Shan
On Fri, May 23, 2014 at 08:55:15AM +0200, Alexander Graf wrote: >> Am 23.05.2014 um 06:37 schrieb Gavin Shan : >>> On Thu, May 22, 2014 at 09:10:53PM -0600, Alex Williamson wrote: On Thu, 2014-05-22 at 18:23 +1000, Gavin Shan wrote: The patch adds new IOCTL commands for VFIO PCI device to

Re: [PATCH v6 2/3] drivers/vfio: EEH support for VFIO PCI device

2014-05-22 Thread Alexander Graf
> Am 23.05.2014 um 06:37 schrieb Gavin Shan : > >> On Thu, May 22, 2014 at 09:10:53PM -0600, Alex Williamson wrote: >>> On Thu, 2014-05-22 at 18:23 +1000, Gavin Shan wrote: >>> The patch adds new IOCTL commands for VFIO PCI device to support >>> EEH functionality for PCI devices, which have been

Re: [PATCH v6 2/3] drivers/vfio: EEH support for VFIO PCI device

2014-05-22 Thread Alexander Graf
> Am 23.05.2014 um 05:23 schrieb Alex Williamson : > >> On Fri, 2014-05-23 at 10:37 +1000, Gavin Shan wrote: >>> On Fri, May 23, 2014 at 10:17:30AM +1000, Gavin Shan wrote: On Thu, May 22, 2014 at 11:55:29AM +0200, Alexander Graf wrote: On 22.05.14 10:23, Gavin Shan wrote: >> >> .../.

Re: [PATCH v6 2/3] drivers/vfio: EEH support for VFIO PCI device

2014-05-22 Thread Benjamin Herrenschmidt
On Fri, 2014-05-23 at 14:37 +1000, Gavin Shan wrote: > >There's no notification, the user needs to observe the return value an > >poll? Should we be enabling an eventfd to notify the user of the state > >change? > > > > Yes. The user needs to monitor the return value. we should have one > notifi

Re: [PATCH v6 2/3] drivers/vfio: EEH support for VFIO PCI device

2014-05-22 Thread Gavin Shan
On Thu, May 22, 2014 at 09:10:53PM -0600, Alex Williamson wrote: >On Thu, 2014-05-22 at 18:23 +1000, Gavin Shan wrote: >> The patch adds new IOCTL commands for VFIO PCI device to support >> EEH functionality for PCI devices, which have been passed through >> from host to somebody else via VFIO. >>

Re: [PATCH v6 2/3] drivers/vfio: EEH support for VFIO PCI device

2014-05-22 Thread Alex Williamson
On Fri, 2014-05-23 at 10:37 +1000, Gavin Shan wrote: > On Fri, May 23, 2014 at 10:17:30AM +1000, Gavin Shan wrote: > >On Thu, May 22, 2014 at 11:55:29AM +0200, Alexander Graf wrote: > >>On 22.05.14 10:23, Gavin Shan wrote: > > .../... > > >>>diff --git a/include/uapi/linux/vfio.h b/include/uapi/l

Re: [PATCH v6 2/3] drivers/vfio: EEH support for VFIO PCI device

2014-05-22 Thread Alex Williamson
On Thu, 2014-05-22 at 18:23 +1000, Gavin Shan wrote: > The patch adds new IOCTL commands for VFIO PCI device to support > EEH functionality for PCI devices, which have been passed through > from host to somebody else via VFIO. > > Signed-off-by: Gavin Shan > --- > Documentation/vfio.txt

Re: [PATCH v6 2/3] drivers/vfio: EEH support for VFIO PCI device

2014-05-22 Thread Gavin Shan
On Fri, May 23, 2014 at 10:17:30AM +1000, Gavin Shan wrote: >On Thu, May 22, 2014 at 11:55:29AM +0200, Alexander Graf wrote: >>On 22.05.14 10:23, Gavin Shan wrote: .../... >>>diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h >>>index cb9023d..ef55682 100644 >>>--- a/include/uapi/

Re: [PATCH v6 2/3] drivers/vfio: EEH support for VFIO PCI device

2014-05-22 Thread Gavin Shan
On Thu, May 22, 2014 at 11:55:29AM +0200, Alexander Graf wrote: > >On 22.05.14 10:23, Gavin Shan wrote: >>The patch adds new IOCTL commands for VFIO PCI device to support >>EEH functionality for PCI devices, which have been passed through >>from host to somebody else via VFIO. >> >>Signed-off-by: G

Re: [PATCH v6 2/3] drivers/vfio: EEH support for VFIO PCI device

2014-05-22 Thread Alexander Graf
On 22.05.14 10:23, Gavin Shan wrote: The patch adds new IOCTL commands for VFIO PCI device to support EEH functionality for PCI devices, which have been passed through from host to somebody else via VFIO. Signed-off-by: Gavin Shan This already looks a *lot* more sane than the previous versio