On Wed, 6 Mar 2024 15:38:10 +0200 Andy Shevchenko wrote:
> > It's minor, but you can avoid conditionals doing something like:
> >
> > netdev->stats.rx_over_errors += !!(flags &
> > QMC_RX_FLAG_HDLC_OVF);
>
> This is harder to read.
+1
On Wed, Mar 06, 2024 at 05:27:51AM -0800, Yury Norov wrote:
> On Wed, Mar 06, 2024 at 09:07:17AM +0100, Herve Codina wrote:
...
> It's minor, but you can avoid conditionals doing something like:
>
> netdev->stats.rx_over_errors += !!(flags &
> QMC_RX_FLAG_HDLC_OVF);
This is harde
On Wed, Mar 06, 2024 at 09:07:17AM +0100, Herve Codina wrote:
> The QMC HDLC driver provides support for HDLC using the QMC (QUICC
> Multichannel Controller) to transfer the HDLC data.
>
> Signed-off-by: Herve Codina
> Reviewed-by: Christophe Leroy
> Acked-by: Jakub Kicinski
> Reviewed-by: Andy
