Re: [PATCH v6 01/16] PCI/DPC: Initialize aer_err_info before using it

2025-05-20 Thread Bjorn Helgaas
On Tue, May 20, 2025 at 12:39:18PM +0300, Ilpo Järvinen wrote: > On Mon, 19 May 2025, Bjorn Helgaas wrote: > > > From: Bjorn Helgaas > > > > Previously the struct aer_err_info "info" was allocated on the stack > > without being initialized, so it contained junk except for the fields we > > expli

Re: [PATCH v6 01/16] PCI/DPC: Initialize aer_err_info before using it

2025-05-20 Thread Bjorn Helgaas
On Mon, May 19, 2025 at 03:41:50PM -0700, Sathyanarayanan Kuppuswamy wrote: > Hi, > > On 5/19/25 2:35 PM, Bjorn Helgaas wrote: > > From: Bjorn Helgaas > > > > Previously the struct aer_err_info "info" was allocated on the stack > > /s/Previously/Currently ? I prefer "previously" here because i

Re: [PATCH v6 01/16] PCI/DPC: Initialize aer_err_info before using it

2025-05-20 Thread Ilpo Järvinen
On Mon, 19 May 2025, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > Previously the struct aer_err_info "info" was allocated on the stack > without being initialized, so it contained junk except for the fields we > explicitly set later. > > Initialize "info" at declaration so it starts as all ze

Re: [PATCH v6 01/16] PCI/DPC: Initialize aer_err_info before using it

2025-05-19 Thread Sathyanarayanan Kuppuswamy
Hi, On 5/19/25 2:35 PM, Bjorn Helgaas wrote: From: Bjorn Helgaas Previously the struct aer_err_info "info" was allocated on the stack /s/Previously/Currently ? without being initialized, so it contained junk except for the fields we explicitly set later. Initialize "info" at declaration s