Re: [PATCH v5 3/4] powerpc/mm: add radix__remove_section_mapping()

2017-01-17 Thread Balbir Singh
On Tue, Jan 17, 2017 at 12:36:21PM -0600, Reza Arbab wrote: > On Tue, Jan 17, 2017 at 12:52:51PM +0530, Balbir Singh wrote: > > Shouldn't most of these functions have __meminit? > > I don't think so. The mapping functions are __meminit, but the unmapping > functions are completely within #ifdef CO

Re: [PATCH v5 3/4] powerpc/mm: add radix__remove_section_mapping()

2017-01-17 Thread Reza Arbab
On Tue, Jan 17, 2017 at 12:52:51PM +0530, Balbir Singh wrote: Shouldn't most of these functions have __meminit? I don't think so. The mapping functions are __meminit, but the unmapping functions are completely within #ifdef CONFIG_MEMORY_HOTPLUG already. On Mon, Jan 16, 2017 at 01:07:45PM -

Re: [PATCH v5 3/4] powerpc/mm: add radix__remove_section_mapping()

2017-01-16 Thread Balbir Singh
On Mon, Jan 16, 2017 at 01:07:45PM -0600, Reza Arbab wrote: > Tear down and free the four-level page tables of physical mappings > during memory hotremove. > > Borrow the basic structure of remove_pagetable() and friends from the > identically-named x86 functions. Reduce the frequency of tlb flush